From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qKdFOGKiTWLHNgAAWB0awg (envelope-from ) for ; Wed, 06 Apr 2022 10:23:30 -0400 Received: by simark.ca (Postfix, from userid 112) id E46C11F344; Wed, 6 Apr 2022 10:23:30 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 721B31ED17 for ; Wed, 6 Apr 2022 10:23:30 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AD8F4385DC02 for ; Wed, 6 Apr 2022 14:23:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AD8F4385DC02 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1649255009; bh=5xmmS9opwQM1/bXXKSEonEe+6D0nf+kLewpqyqjIWtE=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=Ktm4BUTcGwzAzQ4ce8sHgW92kFHnDbF7HVw9wIXfP51hoE06+l3v4kUr/QEZgWFnf KI65gp2EoAoYdtwF7JW8gKRNhGYZmdXsm7UaHWJ1V0oT8pgHfMPG67iWXfKACJ3Tgf OsQBOWKYf2uv61Bn0XILnsSTwA7yAQfHZDJf9mKw= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 69789385840C for ; Wed, 6 Apr 2022 14:23:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 69789385840C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 236EN3Z3006073 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 6 Apr 2022 10:23:08 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 236EN3Z3006073 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C4B931ED17; Wed, 6 Apr 2022 10:23:03 -0400 (EDT) Message-ID: <5a167830-a57e-1a6f-f271-019cef97a716@polymtl.ca> Date: Wed, 6 Apr 2022 10:23:03 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCHv2 11/16] gdb: remove reggroup_next and reggroup_prev Content-Language: en-US To: Andrew Burgess , gdb-patches@sourceware.org References: <3a1ef96c90157a4193af462837b63e90c0fcd6c8.1649246539.git.aburgess@redhat.com> <0b75bf81-3865-001e-8a8a-d6907f0ee296@polymtl.ca> In-Reply-To: <0b75bf81-3865-001e-8a8a-d6907f0ee296@polymtl.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 6 Apr 2022 14:23:03 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >> diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c >> index b968947fa1c..acffc75238a 100644 >> --- a/gdb/tui/tui-regs.c >> +++ b/gdb/tui/tui-regs.c >> @@ -514,34 +514,48 @@ tui_data_item_window::rerender (WINDOW *handle, int field_width) >> (void) wstandend (handle); >> } >> >> -/* Helper for "tui reg next", wraps a call to REGGROUP_NEXT, but adds wrap >> - around behaviour. Will never return nullptr. If CURRENT_GROUP is >> - nullptr (e.g. if the tui register window has only just been displayed >> - and has no current group selected), then the first register group will >> - be returned. */ >> +/* Helper for "tui reg next", returns the next register group after >> + CURRENT_GROUP in the register group list for GDBARCH, with wrap around >> + behaviour. >> + >> + If CURRENT_GROUP is nullptr (e.g. if the tui register window has only >> + just been displayed and has no current group selected) or the currently >> + selected register group can't be found (e.g. if the architecture has >> + changed since the register window was last updated), then the last >> + register group will be returned. */ > > last or next? This is for tui_reg_next. Sorry I meant "last or first".