On 4 Jun 2018, at 14:12, H.J. Lu wrote: > Please add > > #include "common/preprocessor.h" > > to gdb.c. The problem occurs in other source files too. (And I'm not a GDB maintainer, so I won't be adding anything to anything :-)) > Move gdb/common/diagnostics.h to include/diagnostics.h so that it can > be used in binutils. If the intention is to use include/diagnostics.h in binutils outwith GDB, then gdb/common/preprocessor.h will need to follow diagnostics.h to include/. (Or at least a definition of STRINGIFY will need to be in include/ -- but preprocessor.h seems as generic as diagnostics.h in any case, so it seems appropriate to just move it all.) John From gdb-patches-return-147917-listarch-gdb-patches=sources.redhat.com@sourceware.org Mon Jun 04 13:29:17 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 17935 invoked by alias); 4 Jun 2018 13:29:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 15066 invoked by uid 89); 4 Jun 2018 13:29:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=v30 X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com Received: from mail-ve1eur01on0042.outbound.protection.outlook.com (HELO EUR01-VE1-obe.outbound.protection.outlook.com) (104.47.1.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Jun 2018 13:29:12 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.226.148) by DB6PR0802MB2165.eurprd08.prod.outlook.com (10.172.227.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.820.13; Mon, 4 Jun 2018 13:29:08 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::d984:bdee:1856:c64]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::d984:bdee:1856:c64%7]) with mapi id 15.20.0820.010; Mon, 4 Jun 2018 13:29:08 +0000 From: Alan Hayward To: Simon Marchi , Pedro Alves CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH 6/8] Aarch64 SVE pseudo register support Date: Mon, 04 Jun 2018 13:29:00 -0000 Message-ID: References: <20180511105256.27388-1-alan.hayward@arm.com> <20180511105256.27388-7-alan.hayward@arm.com> In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DB6PR0802MB2165;7:cbAN5Q7AlcsBY6WrJiycnH6g9mPxATn462HpFJgmjfEF955pF+3ZvOQ24xQBNFUvt8RU0lkRZ/Tc0KvKwggz2tKh7gBJtNjH4kg+EAPWIscNSQejcP6PS8S+w9/D4qqketArH8Ly++Wr1yuTtsal72a85pobpLmVyPoPMsDrFKJZS7tvwn8o74EPtntfFsRwZ9C1y5lP4ZRRsAToMdYCejzWUfbIRUeWHb6I5cqwvxnEgVWSGPjDEZgXpP/SwXn7 x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:DB6PR0802MB2165; x-ms-traffictypediagnostic: DB6PR0802MB2165: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(37575265505322); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016);SRVR:DB6PR0802MB2165;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0802MB2165; x-forefront-prvs: 069373DFB6 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(366004)(396003)(39860400002)(39380400002)(376002)(346002)(189003)(199004)(26005)(3280700002)(53546011)(8676002)(59450400001)(6506007)(54906003)(76176011)(110136005)(81156014)(81166006)(72206003)(478600001)(6512007)(53936002)(6246003)(50226002)(25786009)(4326008)(8936002)(5250100002)(33656002)(5660300001)(68736007)(14454004)(106356001)(99286004)(105586002)(7736002)(66066001)(476003)(305945005)(6486002)(83716003)(229853002)(186003)(486006)(6436002)(82746002)(57306001)(2616005)(446003)(11346002)(6116002)(3846002)(3660700001)(2900100001)(102836004)(86362001)(2906002)(36756003)(316002)(97736004);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2165;H:DB6PR0802MB2133.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: gC2VpnWziRFAqIQZJS16+UbNk2+lruuB8gTX9KOpRvuewsdSwIafsCVYO5kU1gevY5YKaC341gkpl1o9TgL+a4wxh+EHuluCI5rxK1Qoozjash1wtK2j5quvVQGRtMQ/g2U7gq0J7hV9V6mVI7fX1nIFDtaJZUSiNGWIOGfN12QmLz1saeGWajgN9G2LvUPS spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 254aa4f1-0a3a-447f-cd74-08d5ca1f26b6 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 254aa4f1-0a3a-447f-cd74-08d5ca1f26b6 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jun 2018 13:29:08.3863 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2165 X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00060.txt.bz2 Content-length: 18317 VXBkYXRlIG9mIHBhdGNoIHBvc3RlZCBiZWxvdy4NCg0KDQo+IE9uIDMxIE1h eSAyMDE4LCBhdCAxNTo1NywgUGVkcm8gQWx2ZXMgPHBhbHZlc0ByZWRoYXQu Y29tPiB3cm90ZToNCj4gDQo+IE9uIDA1LzExLzIwMTggMTE6NTIgQU0sIEFs YW4gSGF5d2FyZCB3cm90ZToNCj4gDQo+PiArLyogUmV0dXJuIHRoZSB0eXBl IGZvciBhbiBBZHZTSVNEIFYgcmVnaXN0ZXIuICAqLw0KPj4gKw0KPj4gK3N0 YXRpYyBzdHJ1Y3QgdHlwZSAqDQo+PiArYWFyY2g2NF92bnZfdHlwZSAoc3Ry dWN0IGdkYmFyY2ggKmdkYmFyY2gpDQo+PiArew0KPj4gKyAgc3RydWN0IGdk YmFyY2hfdGRlcCAqdGRlcCA9IGdkYmFyY2hfdGRlcCAoZ2RiYXJjaCk7DQo+ PiArDQo+PiArICBpZiAodGRlcC0+dm52X3R5cGUgPT0gTlVMTCkNCj4+ICsg ICAgew0KPj4gKyAgICAgIHN0cnVjdCB0eXBlICp0Ow0KPj4gKyAgICAgIHN0 cnVjdCB0eXBlICplbGVtOw0KPiANCj4gRUxFTSBhcHBlYXJzIHVudXNlZC4g DQo+IA0KDQpMZWZ0b3ZlciBmcm9tIGNvcHkgcGFzdGUgb2YgcHJldmlvdXMg YmxvY2sgb2YgY29kZS4gUmVtb3ZlZC4NCg0KDQoNCj4gT24gMzEgTWF5IDIw MTgsIGF0IDEzOjIxLCBTaW1vbiBNYXJjaGkgPHNpbW9uLm1hcmNoaUBlcmlj c3Nvbi5jb20+IHdyb3RlOg0KPiANCj4gT24gMjAxOC0wNS0xMSAwNjo1MiBB TSwgQWxhbiBIYXl3YXJkIHdyb3RlOg0KPj4gQWRkIHRoZSBmdW5jdGlvbmFs aXR5IGZvciByZWFkaW5nL3dyaXRpbmcgcHN1ZWRvIHJlZ2lzdGVycy4NCj4g DQo+IOKAnHBzZXVkbyINCg0KRG9uZS4NCg0KPj4gDQo+PiBzdGF0aWMgc3Ry dWN0IHZhbHVlICoNCj4+IC1hYXJjaDY0X3BzZXVkb19yZWFkX3ZhbHVlXzIg KHJlYWRhYmxlX3JlZ2NhY2hlICpyZWdjYWNoZSwgaW50IHJlZ251bV9vZmZz ZXQsDQo+PiArYWFyY2g2NF9wc2V1ZG9fcmVhZF92YWx1ZV8yIChzdHJ1Y3Qg Z2RiYXJjaCAqZ2RiYXJjaCwNCj4+ICsJCQkgICAgIHJlYWRhYmxlX3JlZ2Nh Y2hlICpyZWdjYWNoZSwgaW50IHJlZ251bV9vZmZzZXQsDQo+PiAJCQkgICAg IGludCByZWdzaXplLCBzdHJ1Y3QgdmFsdWUgKnJlc3VsdF92YWx1ZSkNCj4+ IHsNCj4+IC0gIGdkYl9ieXRlIHJlZ19idWZbVl9SRUdJU1RFUl9TSVpFXTsN Cj4+ICsgIHN0cnVjdCBnZGJhcmNoX3RkZXAgKnRkZXAgPSBnZGJhcmNoX3Rk ZXAgKGdkYmFyY2gpOw0KPj4gKyAgZ2RiX2J5dGUgdl9idWZbVl9SRUdJU1RF Ul9TSVpFXSwgKnJlZ19idWY7DQo+PiArICBnZGJfYXNzZXJ0IChBQVJDSDY0 X1YwX1JFR05VTSA9PSBBQVJDSDY0X1NWRV9aMF9SRUdOVU0pOw0KPj4gICB1 bnNpZ25lZCB2X3JlZ251bSA9IEFBUkNINjRfVjBfUkVHTlVNICsgcmVnbnVt X29mZnNldDsNCj4+IA0KPj4gKyAgLyogRW5vdWdoIHNwYWNlIHRvIHJlYWQg YSBmdWxsIHZlY3RvciByZWdpc3Rlci4gICovDQo+PiArICBpZiAodGRlcC0+ aGFzX3N2ZSAoKSkNCj4+ICsgICAgcmVnX2J1ZiA9IChnZGJfYnl0ZSAqKSB4 bWFsbG9jIChyZWdpc3Rlcl9zaXplIChnZGJhcmNoLCBBQVJDSDY0X1YwX1JF R05VTSkpOw0KPj4gKyAgZWxzZQ0KPj4gKyAgICByZWdfYnVmID0gdl9idWY7 DQo+IA0KPiBJZiB0aGUgc2l6ZSBvZiBhIHJlZ2lzdGVyIChldmVuIHdpdGgg U1ZFKSB3aWxsIGFsd2F5cyBiZSByZWFzb25hYmxlIHRvIGFsbG9jYXRlIG9u IHRoZQ0KPiBzdGFjaywgbWF5YmUgeW91IGNvdWxkIGp1c3QgdXNlDQo+IA0K PiAgZ2RiX2J5dGUgcmVnX2J1ZltyZWdpc3Rlcl9zaXplIChnZGJhcmNoLCBB QVJDSDY0X1YwX1JFR05VTSldOw0KPiANCj4gKElmIHRoZXJlIGlzIGFsd2F5 cyBhIHJlZ2lzdGVyIHdpdGggbnVtYmVyIEFBUkNINjRfVjBfUkVHTlVNLCB0 aGF0IGlzKQ0KPiANCj4gT3RoZXJ3aXNlLCBpdCB3b3VsZCBiZSBnb29kIHRv IHVzZSBhbiBzdGQ6OnVuaXF1ZV9wdHIvZ2RiOjp1bmlxdWVfeG1hbGxvY19w dHIgdG8gYXZvaWQNCj4gdGhlIG1hbnVhbCB4ZnJlZS4NCj4gDQo+IFNhbWUg aW4gYWFyY2g2NF9wc2V1ZG9fd3JpdGVfMi4NCj4gDQoNClRoaW5raW5nIGFi b3V0IHRoaXMgYSBsaXR0bGUgbW9yZSwgb24gYW4gU1ZFIHN5c3RlbSwgYSBj b21waWxlcg0Kc3BpbGwgb2YgYSBTVkUgcmVnaXN0ZXIgaXMgZ29pbmcgdG8g cmVzdWx0IGluIGl0IGdvaW5nIHRvIHRoZQ0Kc3RhY2sgYW55d2F5Lg0KTWF4 IHNpemUgb2YgYW4gU1ZFIHJlZ2lzdGVyIHdlIHN1cHBvcnQgaXMgMjU2IGJ5 dGVzLCB3aGljaA0KZG9lc24ndCBzZWVtIHVucmVhc29uYWJsZSB0byBhZGQg dG8gdGhlIHN0YWNrLg0KDQpVcGRhdGVkIHRvIHVzZSBhbiBhcnJheS4gQXJl IHlvdSBoYXBweSB3aXRoIHRoZSBuZXcgdmVyc2lvbj8NCg0KDQpUaGFua3Ms DQpBbGFuLg0KDQoNCmRpZmYgLS1naXQgYS9nZGIvYWFyY2g2NC10ZGVwLmgg Yi9nZGIvYWFyY2g2NC10ZGVwLmgNCmluZGV4IGI2YjliMzBlNzE1MjkxZmIw NTEyZjIxNGE4OGNlNDk0NDVmYjI5MGIuLjc2MjQzYjdkZTUzNDgzYmY4Mzk0 YWRjMWY3YzQ5Mzc5OGRhMjViMDYgMTAwNjQ0DQotLS0gYS9nZGIvYWFyY2g2 NC10ZGVwLmgNCisrKyBiL2dkYi9hYXJjaDY0LXRkZXAuaA0KQEAgLTcwLDYg KzcwLDcgQEAgc3RydWN0IGdkYmFyY2hfdGRlcA0KICAgc3RydWN0IHR5cGUg KnZuc190eXBlOw0KICAgc3RydWN0IHR5cGUgKnZuaF90eXBlOw0KICAgc3Ry dWN0IHR5cGUgKnZuYl90eXBlOw0KKyAgc3RydWN0IHR5cGUgKnZudl90eXBl Ow0KDQogICAvKiBzeXNjYWxsIHJlY29yZC4gICovDQogICBpbnQgKCphYXJj aDY0X3N5c2NhbGxfcmVjb3JkKSAoc3RydWN0IHJlZ2NhY2hlICpyZWdjYWNo ZSwgdW5zaWduZWQgbG9uZyBzdmNfbnVtYmVyKTsNCmRpZmYgLS1naXQgYS9n ZGIvYWFyY2g2NC10ZGVwLmMgYi9nZGIvYWFyY2g2NC10ZGVwLmMNCmluZGV4 IGI3NTIzMzgxNzhmMjhhMTE2OTIzNGE3Njk0MWExNTQ2YmJjOWRmYTcuLmYw NDcyOWY0MDJlYzU2NDE2Y2Q3NzJlNWNhOTRmMDY4MWVhODViZWIgMTAwNjQ0 DQotLS0gYS9nZGIvYWFyY2g2NC10ZGVwLmMNCisrKyBiL2dkYi9hYXJjaDY0 LXRkZXAuYw0KQEAgLTY5LDYgKzY5LDcgQEANCiAjZGVmaW5lIEFBUkNINjRf UzBfUkVHTlVNIChBQVJDSDY0X0QwX1JFR05VTSArIDMyKQ0KICNkZWZpbmUg QUFSQ0g2NF9IMF9SRUdOVU0gKEFBUkNINjRfUzBfUkVHTlVNICsgMzIpDQog I2RlZmluZSBBQVJDSDY0X0IwX1JFR05VTSAoQUFSQ0g2NF9IMF9SRUdOVU0g KyAzMikNCisjZGVmaW5lIEFBUkNINjRfU1ZFX1YwX1JFR05VTSAoQUFSQ0g2 NF9CMF9SRUdOVU0gKyAzMikNCg0KIC8qIEFsbCBwb3NzaWJsZSBhYXJjaDY0 IHRhcmdldCBkZXNjcmlwdG9ycy4gICovDQogc3RydWN0IHRhcmdldF9kZXNj ICp0ZGVzY19hYXJjaDY0X2xpc3RbQUFSQ0g2NF9NQVhfU1ZFX1ZRICsgMV07 DQpAQCAtMTc2Niw2ICsxNzY3LDMwIEBAIGFhcmNoNjRfdm5iX3R5cGUgKHN0 cnVjdCBnZGJhcmNoICpnZGJhcmNoKQ0KICAgcmV0dXJuIHRkZXAtPnZuYl90 eXBlOw0KIH0NCg0KKy8qIFJldHVybiB0aGUgdHlwZSBmb3IgYW4gQWR2U0lT RCBWIHJlZ2lzdGVyLiAgKi8NCisNCitzdGF0aWMgc3RydWN0IHR5cGUgKg0K K2FhcmNoNjRfdm52X3R5cGUgKHN0cnVjdCBnZGJhcmNoICpnZGJhcmNoKQ0K K3sNCisgIHN0cnVjdCBnZGJhcmNoX3RkZXAgKnRkZXAgPSBnZGJhcmNoX3Rk ZXAgKGdkYmFyY2gpOw0KKw0KKyAgaWYgKHRkZXAtPnZudl90eXBlID09IE5V TEwpDQorICAgIHsNCisgICAgICBzdHJ1Y3QgdHlwZSAqdCA9IGFyY2hfY29t cG9zaXRlX3R5cGUgKGdkYmFyY2gsICJfX2dkYl9idWlsdGluX3R5cGVfdm52 IiwNCisJCQkJCSAgICBUWVBFX0NPREVfVU5JT04pOw0KKw0KKyAgICAgIGFw cGVuZF9jb21wb3NpdGVfdHlwZV9maWVsZCAodCwgImQiLCBhYXJjaDY0X3Zu ZF90eXBlIChnZGJhcmNoKSk7DQorICAgICAgYXBwZW5kX2NvbXBvc2l0ZV90 eXBlX2ZpZWxkICh0LCAicyIsIGFhcmNoNjRfdm5zX3R5cGUgKGdkYmFyY2gp KTsNCisgICAgICBhcHBlbmRfY29tcG9zaXRlX3R5cGVfZmllbGQgKHQsICJo IiwgYWFyY2g2NF92bmhfdHlwZSAoZ2RiYXJjaCkpOw0KKyAgICAgIGFwcGVu ZF9jb21wb3NpdGVfdHlwZV9maWVsZCAodCwgImIiLCBhYXJjaDY0X3ZuYl90 eXBlIChnZGJhcmNoKSk7DQorICAgICAgYXBwZW5kX2NvbXBvc2l0ZV90eXBl X2ZpZWxkICh0LCAicSIsIGFhcmNoNjRfdm5xX3R5cGUgKGdkYmFyY2gpKTsN CisNCisgICAgICB0ZGVwLT52bnZfdHlwZSA9IHQ7DQorICAgIH0NCisNCisg IHJldHVybiB0ZGVwLT52bnZfdHlwZTsNCit9DQorDQogLyogSW1wbGVtZW50 IHRoZSAiZHdhcmYyX3JlZ190b19yZWdudW0iIGdkYmFyY2ggbWV0aG9kLiAg Ki8NCg0KIHN0YXRpYyBpbnQNCkBAIC0yMTE0LDYgKzIxMzksOCBAQCBhYXJj aDY0X2dlbl9yZXR1cm5fYWRkcmVzcyAoc3RydWN0IGdkYmFyY2ggKmdkYmFy Y2gsDQogc3RhdGljIGNvbnN0IGNoYXIgKg0KIGFhcmNoNjRfcHNldWRvX3Jl Z2lzdGVyX25hbWUgKHN0cnVjdCBnZGJhcmNoICpnZGJhcmNoLCBpbnQgcmVn bnVtKQ0KIHsNCisgIHN0cnVjdCBnZGJhcmNoX3RkZXAgKnRkZXAgPSBnZGJh cmNoX3RkZXAgKGdkYmFyY2gpOw0KKw0KICAgc3RhdGljIGNvbnN0IGNoYXIg KmNvbnN0IHFfbmFtZVtdID0NCiAgICAgew0KICAgICAgICJxMCIsICJxMSIs ICJxMiIsICJxMyIsDQpAQCAtMjE5MSw2ICsyMjE4LDI1IEBAIGFhcmNoNjRf cHNldWRvX3JlZ2lzdGVyX25hbWUgKHN0cnVjdCBnZGJhcmNoICpnZGJhcmNo LCBpbnQgcmVnbnVtKQ0KICAgaWYgKHJlZ251bSA+PSBBQVJDSDY0X0IwX1JF R05VTSAmJiByZWdudW0gPCBBQVJDSDY0X0IwX1JFR05VTSArIDMyKQ0KICAg ICByZXR1cm4gYl9uYW1lW3JlZ251bSAtIEFBUkNINjRfQjBfUkVHTlVNXTsN Cg0KKyAgaWYgKHRkZXAtPmhhc19zdmUgKCkpDQorICAgIHsNCisgICAgICBz dGF0aWMgY29uc3QgY2hhciAqY29uc3Qgc3ZlX3ZfbmFtZVtdID0NCisJew0K KwkgICJ2MCIsICJ2MSIsICJ2MiIsICJ2MyIsDQorCSAgInY0IiwgInY1Iiwg InY2IiwgInY3IiwNCisJICAidjgiLCAidjkiLCAidjEwIiwgInYxMSIsDQor CSAgInYxMiIsICJ2MTMiLCAidjE0IiwgInYxNSIsDQorCSAgInYxNiIsICJ2 MTciLCAidjE4IiwgInYxOSIsDQorCSAgInYyMCIsICJ2MjEiLCAidjIyIiwg InYyMyIsDQorCSAgInYyNCIsICJ2MjUiLCAidjI2IiwgInYyNyIsDQorCSAg InYyOCIsICJ2MjkiLCAidjMwIiwgInYzMSIsDQorCX07DQorDQorICAgICAg aWYgKHJlZ251bSA+PSBBQVJDSDY0X1NWRV9WMF9SRUdOVU0NCisJICAmJiBy ZWdudW0gPCBBQVJDSDY0X1NWRV9WMF9SRUdOVU0gKyBBQVJDSDY0X1ZfUkVH U19OVU0pDQorCXJldHVybiBzdmVfdl9uYW1lW3JlZ251bSAtIEFBUkNINjRf U1ZFX1YwX1JFR05VTV07DQorICAgIH0NCisNCiAgIGludGVybmFsX2Vycm9y IChfX0ZJTEVfXywgX19MSU5FX18sDQogCQkgIF8oImFhcmNoNjRfcHNldWRv X3JlZ2lzdGVyX25hbWU6IGJhZCByZWdpc3RlciBudW1iZXIgJWQiKSwNCiAJ CSAgcmVnbnVtKTsNCkBAIC0yMjAxLDYgKzIyNDcsOCBAQCBhYXJjaDY0X3Bz ZXVkb19yZWdpc3Rlcl9uYW1lIChzdHJ1Y3QgZ2RiYXJjaCAqZ2RiYXJjaCwg aW50IHJlZ251bSkNCiBzdGF0aWMgc3RydWN0IHR5cGUgKg0KIGFhcmNoNjRf cHNldWRvX3JlZ2lzdGVyX3R5cGUgKHN0cnVjdCBnZGJhcmNoICpnZGJhcmNo LCBpbnQgcmVnbnVtKQ0KIHsNCisgIHN0cnVjdCBnZGJhcmNoX3RkZXAgKnRk ZXAgPSBnZGJhcmNoX3RkZXAgKGdkYmFyY2gpOw0KKw0KICAgcmVnbnVtIC09 IGdkYmFyY2hfbnVtX3JlZ3MgKGdkYmFyY2gpOw0KDQogICBpZiAocmVnbnVt ID49IEFBUkNINjRfUTBfUkVHTlVNICYmIHJlZ251bSA8IEFBUkNINjRfUTBf UkVHTlVNICsgMzIpDQpAQCAtMjIxOCw2ICsyMjY2LDEwIEBAIGFhcmNoNjRf cHNldWRvX3JlZ2lzdGVyX3R5cGUgKHN0cnVjdCBnZGJhcmNoICpnZGJhcmNo LCBpbnQgcmVnbnVtKQ0KICAgaWYgKHJlZ251bSA+PSBBQVJDSDY0X0IwX1JF R05VTSAmJiByZWdudW0gPCBBQVJDSDY0X0IwX1JFR05VTSArIDMyKQ0KICAg ICByZXR1cm4gYWFyY2g2NF92bmJfdHlwZSAoZ2RiYXJjaCk7DQoNCisgIGlm ICh0ZGVwLT5oYXNfc3ZlICgpICYmIHJlZ251bSA+PSBBQVJDSDY0X1NWRV9W MF9SRUdOVU0NCisgICAgICAmJiByZWdudW0gPCBBQVJDSDY0X1NWRV9WMF9S RUdOVU0gKyAzMikNCisgICAgcmV0dXJuIGFhcmNoNjRfdm52X3R5cGUgKGdk YmFyY2gpOw0KKw0KICAgaW50ZXJuYWxfZXJyb3IgKF9fRklMRV9fLCBfX0xJ TkVfXywNCiAJCSAgXygiYWFyY2g2NF9wc2V1ZG9fcmVnaXN0ZXJfdHlwZTog YmFkIHJlZ2lzdGVyIG51bWJlciAlZCIpLA0KIAkJICByZWdudW0pOw0KQEAg LTIyMjksNiArMjI4MSw4IEBAIHN0YXRpYyBpbnQNCiBhYXJjaDY0X3BzZXVk b19yZWdpc3Rlcl9yZWdncm91cF9wIChzdHJ1Y3QgZ2RiYXJjaCAqZ2RiYXJj aCwgaW50IHJlZ251bSwNCiAJCQkJICAgIHN0cnVjdCByZWdncm91cCAqZ3Jv dXApDQogew0KKyAgc3RydWN0IGdkYmFyY2hfdGRlcCAqdGRlcCA9IGdkYmFy Y2hfdGRlcCAoZ2RiYXJjaCk7DQorDQogICByZWdudW0gLT0gZ2RiYXJjaF9u dW1fcmVncyAoZ2RiYXJjaCk7DQoNCiAgIGlmIChyZWdudW0gPj0gQUFSQ0g2 NF9RMF9SRUdOVU0gJiYgcmVnbnVtIDwgQUFSQ0g2NF9RMF9SRUdOVU0gKyAz MikNCkBAIC0yMjQzLDYgKzIyOTcsOSBAQCBhYXJjaDY0X3BzZXVkb19yZWdp c3Rlcl9yZWdncm91cF9wIChzdHJ1Y3QgZ2RiYXJjaCAqZ2RiYXJjaCwgaW50 IHJlZ251bSwNCiAgICAgcmV0dXJuIGdyb3VwID09IGFsbF9yZWdncm91cCB8 fCBncm91cCA9PSB2ZWN0b3JfcmVnZ3JvdXA7DQogICBlbHNlIGlmIChyZWdu dW0gPj0gQUFSQ0g2NF9CMF9SRUdOVU0gJiYgcmVnbnVtIDwgQUFSQ0g2NF9C MF9SRUdOVU0gKyAzMikNCiAgICAgcmV0dXJuIGdyb3VwID09IGFsbF9yZWdn cm91cCB8fCBncm91cCA9PSB2ZWN0b3JfcmVnZ3JvdXA7DQorICBlbHNlIGlm ICh0ZGVwLT5oYXNfc3ZlICgpICYmIHJlZ251bSA+PSBBQVJDSDY0X1NWRV9W MF9SRUdOVU0NCisJICAgJiYgcmVnbnVtIDwgQUFSQ0g2NF9TVkVfVjBfUkVH TlVNICsgMzIpDQorICAgIHJldHVybiBncm91cCA9PSBhbGxfcmVnZ3JvdXAg fHwgZ3JvdXAgPT0gdmVjdG9yX3JlZ2dyb3VwOw0KDQogICByZXR1cm4gZ3Jv dXAgPT0gYWxsX3JlZ2dyb3VwOw0KIH0NCkBAIC0yMjUwLDE3ICsyMzA3LDIy IEBAIGFhcmNoNjRfcHNldWRvX3JlZ2lzdGVyX3JlZ2dyb3VwX3AgKHN0cnVj dCBnZGJhcmNoICpnZGJhcmNoLCBpbnQgcmVnbnVtLA0KIC8qIEhlbHBlciBm b3IgYWFyY2g2NF9wc2V1ZG9fcmVhZF92YWx1ZS4gICovDQoNCiBzdGF0aWMg c3RydWN0IHZhbHVlICoNCi1hYXJjaDY0X3BzZXVkb19yZWFkX3ZhbHVlXzEg KHJlYWRhYmxlX3JlZ2NhY2hlICpyZWdjYWNoZSwgaW50IHJlZ251bV9vZmZz ZXQsDQorYWFyY2g2NF9wc2V1ZG9fcmVhZF92YWx1ZV8xIChzdHJ1Y3QgZ2Ri YXJjaCAqZ2RiYXJjaCwNCisJCQkgICAgIHJlYWRhYmxlX3JlZ2NhY2hlICpy ZWdjYWNoZSwgaW50IHJlZ251bV9vZmZzZXQsDQogCQkJICAgICBpbnQgcmVn c2l6ZSwgc3RydWN0IHZhbHVlICpyZXN1bHRfdmFsdWUpDQogew0KLSAgZ2Ri X2J5dGUgcmVnX2J1ZltWX1JFR0lTVEVSX1NJWkVdOw0KICAgdW5zaWduZWQg dl9yZWdudW0gPSBBQVJDSDY0X1YwX1JFR05VTSArIHJlZ251bV9vZmZzZXQ7 DQoNCisgIC8qIEVub3VnaCBzcGFjZSBmb3IgYSBmdWxsIHZlY3RvciByZWdp c3Rlci4gICovDQorICBnZGJfYnl0ZSByZWdfYnVmW3JlZ2lzdGVyX3NpemUg KGdkYmFyY2gsIEFBUkNINjRfVjBfUkVHTlVNKV07DQorICBnZGJfYXNzZXJ0 IChBQVJDSDY0X1YwX1JFR05VTSA9PSBBQVJDSDY0X1NWRV9aMF9SRUdOVU0p Ow0KKw0KICAgaWYgKHJlZ2NhY2hlLT5yYXdfcmVhZCAodl9yZWdudW0sIHJl Z19idWYpICE9IFJFR19WQUxJRCkNCiAgICAgbWFya192YWx1ZV9ieXRlc191 bmF2YWlsYWJsZSAocmVzdWx0X3ZhbHVlLCAwLA0KIAkJCQkgIFRZUEVfTEVO R1RIICh2YWx1ZV90eXBlIChyZXN1bHRfdmFsdWUpKSk7DQogICBlbHNlDQog ICAgIG1lbWNweSAodmFsdWVfY29udGVudHNfcmF3IChyZXN1bHRfdmFsdWUp LCByZWdfYnVmLCByZWdzaXplKTsNCisNCiAgIHJldHVybiByZXN1bHRfdmFs dWU7DQogIH0NCg0KQEAgLTIyNzAsNiArMjMzMiw3IEBAIHN0YXRpYyBzdHJ1 Y3QgdmFsdWUgKg0KIGFhcmNoNjRfcHNldWRvX3JlYWRfdmFsdWUgKHN0cnVj dCBnZGJhcmNoICpnZGJhcmNoLCByZWFkYWJsZV9yZWdjYWNoZSAqcmVnY2Fj aGUsDQogCQkJICAgaW50IHJlZ251bSkNCiB7DQorICBzdHJ1Y3QgZ2RiYXJj aF90ZGVwICp0ZGVwID0gZ2RiYXJjaF90ZGVwIChnZGJhcmNoKTsNCiAgIHN0 cnVjdCB2YWx1ZSAqcmVzdWx0X3ZhbHVlID0gYWxsb2NhdGVfdmFsdWUgKHJl Z2lzdGVyX3R5cGUgKGdkYmFyY2gsIHJlZ251bSkpOw0KDQogICBWQUxVRV9M VkFMIChyZXN1bHRfdmFsdWUpID0gbHZhbF9yZWdpc3RlcjsNCkBAIC0yMjc4 LDQyICsyMzQxLDU2IEBAIGFhcmNoNjRfcHNldWRvX3JlYWRfdmFsdWUgKHN0 cnVjdCBnZGJhcmNoICpnZGJhcmNoLCByZWFkYWJsZV9yZWdjYWNoZSAqcmVn Y2FjaGUsDQogICByZWdudW0gLT0gZ2RiYXJjaF9udW1fcmVncyAoZ2RiYXJj aCk7DQoNCiAgIGlmIChyZWdudW0gPj0gQUFSQ0g2NF9RMF9SRUdOVU0gJiYg cmVnbnVtIDwgQUFSQ0g2NF9RMF9SRUdOVU0gKyAzMikNCi0gICAgcmV0dXJu IGFhcmNoNjRfcHNldWRvX3JlYWRfdmFsdWVfMSAocmVnY2FjaGUsIHJlZ251 bSAtIEFBUkNINjRfUTBfUkVHTlVNLA0KKyAgICByZXR1cm4gYWFyY2g2NF9w c2V1ZG9fcmVhZF92YWx1ZV8xIChnZGJhcmNoLCByZWdjYWNoZSwNCisJCQkJ CXJlZ251bSAtIEFBUkNINjRfUTBfUkVHTlVNLA0KIAkJCQkJUV9SRUdJU1RF Ul9TSVpFLCByZXN1bHRfdmFsdWUpOw0KDQogICBpZiAocmVnbnVtID49IEFB UkNINjRfRDBfUkVHTlVNICYmIHJlZ251bSA8IEFBUkNINjRfRDBfUkVHTlVN ICsgMzIpDQotICAgIHJldHVybiBhYXJjaDY0X3BzZXVkb19yZWFkX3ZhbHVl XzEgKHJlZ2NhY2hlLCByZWdudW0gLSBBQVJDSDY0X0QwX1JFR05VTSwNCisg ICAgcmV0dXJuIGFhcmNoNjRfcHNldWRvX3JlYWRfdmFsdWVfMSAoZ2RiYXJj aCwgcmVnY2FjaGUsDQorCQkJCQlyZWdudW0gLSBBQVJDSDY0X0QwX1JFR05V TSwNCiAJCQkJCURfUkVHSVNURVJfU0laRSwgcmVzdWx0X3ZhbHVlKTsNCg0K ICAgaWYgKHJlZ251bSA+PSBBQVJDSDY0X1MwX1JFR05VTSAmJiByZWdudW0g PCBBQVJDSDY0X1MwX1JFR05VTSArIDMyKQ0KLSAgICByZXR1cm4gYWFyY2g2 NF9wc2V1ZG9fcmVhZF92YWx1ZV8xIChyZWdjYWNoZSwgcmVnbnVtIC0gQUFS Q0g2NF9TMF9SRUdOVU0sDQorICAgIHJldHVybiBhYXJjaDY0X3BzZXVkb19y ZWFkX3ZhbHVlXzEgKGdkYmFyY2gsIHJlZ2NhY2hlLA0KKwkJCQkJcmVnbnVt IC0gQUFSQ0g2NF9TMF9SRUdOVU0sDQogCQkJCQlTX1JFR0lTVEVSX1NJWkUs IHJlc3VsdF92YWx1ZSk7DQoNCiAgIGlmIChyZWdudW0gPj0gQUFSQ0g2NF9I MF9SRUdOVU0gJiYgcmVnbnVtIDwgQUFSQ0g2NF9IMF9SRUdOVU0gKyAzMikN Ci0gICAgcmV0dXJuIGFhcmNoNjRfcHNldWRvX3JlYWRfdmFsdWVfMSAocmVn Y2FjaGUsIHJlZ251bSAtIEFBUkNINjRfSDBfUkVHTlVNLA0KKyAgICByZXR1 cm4gYWFyY2g2NF9wc2V1ZG9fcmVhZF92YWx1ZV8xIChnZGJhcmNoLCByZWdj YWNoZSwNCisJCQkJCXJlZ251bSAtIEFBUkNINjRfSDBfUkVHTlVNLA0KIAkJ CQkJSF9SRUdJU1RFUl9TSVpFLCByZXN1bHRfdmFsdWUpOw0KDQogICBpZiAo cmVnbnVtID49IEFBUkNINjRfQjBfUkVHTlVNICYmIHJlZ251bSA8IEFBUkNI NjRfQjBfUkVHTlVNICsgMzIpDQotICAgIHJldHVybiBhYXJjaDY0X3BzZXVk b19yZWFkX3ZhbHVlXzEgKHJlZ2NhY2hlLCByZWdudW0gLSBBQVJDSDY0X0Iw X1JFR05VTSwNCisgICAgcmV0dXJuIGFhcmNoNjRfcHNldWRvX3JlYWRfdmFs dWVfMSAoZ2RiYXJjaCwgcmVnY2FjaGUsDQorCQkJCQlyZWdudW0gLSBBQVJD SDY0X0IwX1JFR05VTSwNCiAJCQkJCUJfUkVHSVNURVJfU0laRSwgcmVzdWx0 X3ZhbHVlKTsNCg0KKyAgaWYgKHRkZXAtPmhhc19zdmUgKCkgJiYgcmVnbnVt ID49IEFBUkNINjRfU1ZFX1YwX1JFR05VTQ0KKyAgICAgICYmIHJlZ251bSA8 IEFBUkNINjRfU1ZFX1YwX1JFR05VTSArIDMyKQ0KKyAgICByZXR1cm4gYWFy Y2g2NF9wc2V1ZG9fcmVhZF92YWx1ZV8xIChnZGJhcmNoLCByZWdjYWNoZSwN CisJCQkJCXJlZ251bSAtIEFBUkNINjRfU1ZFX1YwX1JFR05VTSwNCisJCQkJ CVZfUkVHSVNURVJfU0laRSwgcmVzdWx0X3ZhbHVlKTsNCisNCiAgIGdkYl9h c3NlcnRfbm90X3JlYWNoZWQgKCJyZWdudW0gb3V0IG9mIGJvdW5kIik7DQog fQ0KDQogLyogSGVscGVyIGZvciBhYXJjaDY0X3BzZXVkb193cml0ZS4gICov DQoNCiBzdGF0aWMgdm9pZA0KLWFhcmNoNjRfcHNldWRvX3dyaXRlXzEgKHN0 cnVjdCByZWdjYWNoZSAqcmVnY2FjaGUsIGludCByZWdudW1fb2Zmc2V0LA0K LQkJCWludCByZWdzaXplLCBjb25zdCBnZGJfYnl0ZSAqYnVmKQ0KK2FhcmNo NjRfcHNldWRvX3dyaXRlXzEgKHN0cnVjdCBnZGJhcmNoICpnZGJhcmNoLCBz dHJ1Y3QgcmVnY2FjaGUgKnJlZ2NhY2hlLA0KKwkJCWludCByZWdudW1fb2Zm c2V0LCBpbnQgcmVnc2l6ZSwgY29uc3QgZ2RiX2J5dGUgKmJ1ZikNCiB7DQot ICBnZGJfYnl0ZSByZWdfYnVmW1ZfUkVHSVNURVJfU0laRV07DQogICB1bnNp Z25lZCB2X3JlZ251bSA9IEFBUkNINjRfVjBfUkVHTlVNICsgcmVnbnVtX29m ZnNldDsNCg0KKyAgLyogRW5vdWdoIHNwYWNlIGZvciBhIGZ1bGwgdmVjdG9y IHJlZ2lzdGVyLiAgKi8NCisgIGdkYl9ieXRlIHJlZ19idWZbcmVnaXN0ZXJf c2l6ZSAoZ2RiYXJjaCwgQUFSQ0g2NF9WMF9SRUdOVU0pXTsNCisgIGdkYl9h c3NlcnQgKEFBUkNINjRfVjBfUkVHTlVNID09IEFBUkNINjRfU1ZFX1owX1JF R05VTSk7DQorDQogICAvKiBFbnN1cmUgdGhlIHJlZ2lzdGVyIGJ1ZmZlciBp cyB6ZXJvLCB3ZSB3YW50IGdkYiB3cml0ZXMgb2YgdGhlDQogICAgICB2YXJp b3VzICdzY2FsYXInIHBzZXVkbyByZWdpc3RlcnMgdG8gYmVoYXZpb3IgbGlr ZSBhcmNoaXRlY3R1cmFsDQogICAgICB3cml0ZXMsIHJlZ2lzdGVyIHdpZHRo IGJ5dGVzIGFyZSB3cml0dGVuIHRoZSByZW1haW5kZXIgYXJlIHNldCB0bw0K ICAgICAgemVyby4gICovDQotICBtZW1zZXQgKHJlZ19idWYsIDAsIHNpemVv ZiAocmVnX2J1ZikpOw0KKyAgbWVtc2V0IChyZWdfYnVmLCAwLCByZWdpc3Rl cl9zaXplIChnZGJhcmNoLCBBQVJDSDY0X1YwX1JFR05VTSkpOw0KDQogICBt ZW1jcHkgKHJlZ19idWYsIGJ1ZiwgcmVnc2l6ZSk7DQogICByZWdjYWNoZS0+ cmF3X3dyaXRlICh2X3JlZ251bSwgcmVnX2J1Zik7DQpAQCAtMjMyNSwyNyAr MjQwMiwzOSBAQCBzdGF0aWMgdm9pZA0KIGFhcmNoNjRfcHNldWRvX3dyaXRl IChzdHJ1Y3QgZ2RiYXJjaCAqZ2RiYXJjaCwgc3RydWN0IHJlZ2NhY2hlICpy ZWdjYWNoZSwNCiAJCSAgICAgIGludCByZWdudW0sIGNvbnN0IGdkYl9ieXRl ICpidWYpDQogew0KKyAgc3RydWN0IGdkYmFyY2hfdGRlcCAqdGRlcCA9IGdk YmFyY2hfdGRlcCAoZ2RiYXJjaCk7DQogICByZWdudW0gLT0gZ2RiYXJjaF9u dW1fcmVncyAoZ2RiYXJjaCk7DQoNCiAgIGlmIChyZWdudW0gPj0gQUFSQ0g2 NF9RMF9SRUdOVU0gJiYgcmVnbnVtIDwgQUFSQ0g2NF9RMF9SRUdOVU0gKyAz MikNCi0gICAgcmV0dXJuIGFhcmNoNjRfcHNldWRvX3dyaXRlXzEgKHJlZ2Nh Y2hlLCByZWdudW0gLSBBQVJDSDY0X1EwX1JFR05VTSwNCi0JCQkJICAgUV9S RUdJU1RFUl9TSVpFLCBidWYpOw0KKyAgICByZXR1cm4gYWFyY2g2NF9wc2V1 ZG9fd3JpdGVfMSAoZ2RiYXJjaCwgcmVnY2FjaGUsDQorCQkJCSAgIHJlZ251 bSAtIEFBUkNINjRfUTBfUkVHTlVNLCBRX1JFR0lTVEVSX1NJWkUsDQorCQkJ CSAgIGJ1Zik7DQoNCiAgIGlmIChyZWdudW0gPj0gQUFSQ0g2NF9EMF9SRUdO VU0gJiYgcmVnbnVtIDwgQUFSQ0g2NF9EMF9SRUdOVU0gKyAzMikNCi0gICAg cmV0dXJuIGFhcmNoNjRfcHNldWRvX3dyaXRlXzEgKHJlZ2NhY2hlLCByZWdu dW0gLSBBQVJDSDY0X0QwX1JFR05VTSwNCi0JCQkJICAgRF9SRUdJU1RFUl9T SVpFLCBidWYpOw0KKyAgICByZXR1cm4gYWFyY2g2NF9wc2V1ZG9fd3JpdGVf MSAoZ2RiYXJjaCwgcmVnY2FjaGUsDQorCQkJCSAgIHJlZ251bSAtIEFBUkNI NjRfRDBfUkVHTlVNLCBEX1JFR0lTVEVSX1NJWkUsDQorCQkJCSAgIGJ1Zik7 DQoNCiAgIGlmIChyZWdudW0gPj0gQUFSQ0g2NF9TMF9SRUdOVU0gJiYgcmVn bnVtIDwgQUFSQ0g2NF9TMF9SRUdOVU0gKyAzMikNCi0gICAgcmV0dXJuIGFh cmNoNjRfcHNldWRvX3dyaXRlXzEgKHJlZ2NhY2hlLCByZWdudW0gLSBBQVJD SDY0X1MwX1JFR05VTSwNCi0JCQkJICAgU19SRUdJU1RFUl9TSVpFLCBidWYp Ow0KKyAgICByZXR1cm4gYWFyY2g2NF9wc2V1ZG9fd3JpdGVfMSAoZ2RiYXJj aCwgcmVnY2FjaGUsDQorCQkJCSAgIHJlZ251bSAtIEFBUkNINjRfUzBfUkVH TlVNLCBTX1JFR0lTVEVSX1NJWkUsDQorCQkJCSAgIGJ1Zik7DQoNCiAgIGlm IChyZWdudW0gPj0gQUFSQ0g2NF9IMF9SRUdOVU0gJiYgcmVnbnVtIDwgQUFS Q0g2NF9IMF9SRUdOVU0gKyAzMikNCi0gICAgcmV0dXJuIGFhcmNoNjRfcHNl dWRvX3dyaXRlXzEgKHJlZ2NhY2hlLCByZWdudW0gLSBBQVJDSDY0X0gwX1JF R05VTSwNCi0JCQkJICAgSF9SRUdJU1RFUl9TSVpFLCBidWYpOw0KKyAgICBy ZXR1cm4gYWFyY2g2NF9wc2V1ZG9fd3JpdGVfMSAoZ2RiYXJjaCwgcmVnY2Fj aGUsDQorCQkJCSAgIHJlZ251bSAtIEFBUkNINjRfSDBfUkVHTlVNLCBIX1JF R0lTVEVSX1NJWkUsDQorCQkJCSAgIGJ1Zik7DQoNCiAgIGlmIChyZWdudW0g Pj0gQUFSQ0g2NF9CMF9SRUdOVU0gJiYgcmVnbnVtIDwgQUFSQ0g2NF9CMF9S RUdOVU0gKyAzMikNCi0gICAgcmV0dXJuIGFhcmNoNjRfcHNldWRvX3dyaXRl XzEgKHJlZ2NhY2hlLCByZWdudW0gLSBBQVJDSDY0X0IwX1JFR05VTSwNCi0J CQkJICAgQl9SRUdJU1RFUl9TSVpFLCBidWYpOw0KKyAgICByZXR1cm4gYWFy Y2g2NF9wc2V1ZG9fd3JpdGVfMSAoZ2RiYXJjaCwgcmVnY2FjaGUsDQorCQkJ CSAgIHJlZ251bSAtIEFBUkNINjRfQjBfUkVHTlVNLCBCX1JFR0lTVEVSX1NJ WkUsDQorCQkJCSAgIGJ1Zik7DQorDQorICBpZiAodGRlcC0+aGFzX3N2ZSAo KSAmJiByZWdudW0gPj0gQUFSQ0g2NF9TVkVfVjBfUkVHTlVNDQorICAgICAg JiYgcmVnbnVtIDwgQUFSQ0g2NF9TVkVfVjBfUkVHTlVNICsgMzIpDQorICAg IHJldHVybiBhYXJjaDY0X3BzZXVkb193cml0ZV8xIChnZGJhcmNoLCByZWdj YWNoZSwNCisJCQkJICAgcmVnbnVtIC0gQUFSQ0g2NF9TVkVfVjBfUkVHTlVN LA0KKwkJCQkgICBWX1JFR0lTVEVSX1NJWkUsIGJ1Zik7DQoNCiAgIGdkYl9h c3NlcnRfbm90X3JlYWNoZWQgKCJyZWdudW0gb3V0IG9mIGJvdW5kIik7DQog fQ0KDQoNCg0KDQoFrom gdb-patches-return-147918-listarch-gdb-patches=sources.redhat.com@sourceware.org Mon Jun 04 13:31:02 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 104160 invoked by alias); 4 Jun 2018 13:31:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 103938 invoked by uid 89); 4 Jun 2018 13:30:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Google-Smtp-Source:ADUXVKK, H*i:sk:dLjk5Wk, H*i:CAMe9rOor6x, H*f:CAMe9rOor6x X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-ot0-f194.google.com Received: from mail-ot0-f194.google.com (HELO mail-ot0-f194.google.com) (74.125.82.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Jun 2018 13:30:43 +0000 Received: by mail-ot0-f194.google.com with SMTP id l12-v6so37628053oth.6; Mon, 04 Jun 2018 06:30:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d100.net; s 161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=XL/ez/5Rxbsw2ryq0aDeFqi34nYYxAH1QodfGuvs5+w=; bÖDobiYG6mXcg0kLjn1jBU5LXZ12ZsgLAiZfFG9D2Af7a201eLO1CADgJ4hCvGp/ex u9UusIcaYLaunG+4sdKPCl+XXJ/jzdn9R9Aqb3gPaX5TCOvqVOVX+jvxR7doPJZKiXpC is92jrNujyfNIMUBMN7yZ4mCH+98tCaqFKwZJqfM9uUe7aS0hDTdRP0aSHY6MEKZ2kbz Je0ADUogHNkVxNGwjKbtxAGDjM2RZ9La1Mk63qlftK9Fx76E1KkWEANsHupQPuenVprD Pvt5CbJWpSxwYN4p2vUzy1ZYavRxN9NEsyIVB7F4xsDNXFqOkb8AwWEu5EGfx5BaNelu jfxA=X-Gm-Message-State: ALKqPwep03b4o5v5T/Er4g8j4VF08tss1uNICQH+wK22f9qAq9T6RZAX KA2fo7zYkCPR9lmhS6OATO1xawsA6TxZBR/E4HsX-Google-Smtp-Source: ADUXVKK+pfRgfPtk1TYJA9ARAwvQRxFq+dE5KcOYK8kdww/zb6sGVJisNJtfgwH8BfUV8VNblGw0l2u/FPcXr5WYFZgX-Received: by 2002:a9d:11ab:: with SMTP id v40-v6mr12397799otf.125.1528119030806; Mon, 04 Jun 2018 06:30:30 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4a:7019:0:0:0:0:0 with HTTP; Mon, 4 Jun 2018 06:30:30 -0700 (PDT) In-Reply-To: References: <20180521121557.16535-1-hjl.tools@gmail.com> <20180521121557.16535-2-hjl.tools@gmail.com> <20180601101949.GA7660@bubble.grove.modra.org> <0d2578f3-f6c0-d19f-d036-fd07d1ff03d0@redhat.com> <2478bdec-0e72-ac94-aa97-8004999feb6e@redhat.com> From: "H.J. Lu" Date: Mon, 04 Jun 2018 13:31:00 -0000 Message-ID: Subject: Re: [PATCH 2/3] Add DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION To: Pedro Alves , John Marshall Cc: Nick Clifton , Alan Modra , Binutils , GDB Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00061.txt.bz2 Content-length: 1318 On Mon, Jun 4, 2018 at 5:46 AM, H.J. Lu wrote: > On Mon, Jun 4, 2018 at 5:19 AM, Pedro Alves wrote: >> On 06/04/2018 01:13 PM, Nick Clifton wrote: >>> Hi H.J. >>> >>>> +# if __GNUC__ == 8 && __GNUC_MINOR__ < 2 >>>> +# define DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION \ >>>> + DIAGNOSTIC_IGNORE ("-Wstringop-truncation") >>>> +# endif >>>> >>>> OK for master? >>> >>> Approved - please apply. >> >> Please don't. This is again going against the intention of >> the header. The GCC version checks should be put in the >> places where the warning needs to be suppressed. >> The current patch makes all current and future uses of >> DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION only apply to >> GCC 8.1. That is incorrect. Consider what you will >> have to do to suppress some -Wstrinop-truncation warning >> with DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION on GCC 8.2 or >> GCC 9 or whatever. > > This is what my original patch intended to do. But diagnostics.h from > GDB doesn't support GCC version. Should I extend it to match glibc? > >> Also, you can use GCC_VERSION to make the version check >> a little simpler. >> >> Thanks, >> Pedro Alves My second patch is needed for Darwin. I will check it in as is and update it with a follow up patch to support GCC version. -- H.J.