From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105909 invoked by alias); 7 Nov 2018 13:25:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105888 invoked by uid 89); 7 Nov 2018 13:25:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-HELO: prv1-mh.provo.novell.com Received: from prv1-mh.provo.novell.com (HELO prv1-mh.provo.novell.com) (137.65.248.33) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Nov 2018 13:25:57 +0000 Received: from INET-PRV1-MTA by prv1-mh.provo.novell.com with Novell_GroupWise; Wed, 07 Nov 2018 06:25:55 -0700 Message-Id: <5BE2E7E002000078001F91C6@prv1-mh.provo.novell.com> Date: Wed, 07 Nov 2018 13:25:00 -0000 From: "Jan Beulich" To: "Markus T Metzger" Cc: "Simon Marchi" , "Pedro Alves" ,"GDB" Subject: RE: Ping: [PATCH v2] x86-64: fix ZMM register state tracking References: <5B8FD8B302000078001E5940@prv1-mh.provo.novell.com> <5BD6E19202000078001F5BC4@prv1-mh.provo.novell.com> <8bafd220c79c3936de8ce3d6421a9c01@polymtl.ca> <5BE2AC5802000078001F8F7D@prv1-mh.provo.novell.com> In-Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-SW-Source: 2018-11/txt/msg00094.txt.bz2 >>> On 07.11.18 at 14:18, wrote: >> >>> On 07.11.18 at 10:07, wrote: >> >> On 2018-10-29 06:31, Jan Beulich wrote: >> >> >>>> On 10.10.18 at 17:12, wrote: >> >> >> The three AVX512 state components are entirely independent - one >> >> >> being in its "init state" has no implication whatsoever on either >> >> >> of the other two. Fully separate X86_XSTATE_ZMM_H and >> >> >> X86_XSTATE_ZMM handling, to prevent upper halves of the upper 16 >> >> >> ZMM registers to display as if they were zero (when they aren't) a= fter=20 > e.g. >> >> >> VZEROALL/VZEROUPPER. >> >> >> >> >> >> gdb/ >> >> >> 2018-10-10 Jan Beulich >> >> >> >> >> >> * i387-tdep.c (i387_supply_xsave): Split handling of >> >> >> X86_XSTATE_ZMM_H and X86_XSTATE_ZMM. >> >> >> (i387_collect_xsave): Likewise. >> >> >> >> >> >> gdb/testsuite/ >> >> >> 2018-10-10 Simon Marchi >> >> >> >> >> >> * testsuite/gdb.arch/i386-avx512.c, >> >> >> testsuite/gdb.arch/i386-avx512.exp: Add 7th test. >> >> >> >> >> >> --- >> >> >> v2: Attach comments to zmm_endlo_regnum declarations. Add testcase >> >> >> provided by Simon. >> >> >> >> The testcase obviously LGTM. I will let Markus approve the other cha= nges. >> > >> > The code already looked good to me in v1. Thanks for adding comments. >>=20 >> So can I translate this into an ack for me to commit the change? >> Or else, who would be the one to give the go-ahead? >=20 > Simon can approve your patch. >=20 > IIRC Pedro had a question regarding gdbserver. From a first look, it see= ms to get the > feature bits right but does not distinguish 32-bit and 64-bit mode regard= ing the number > of available registers. If there was a problem there, it was my understanding that this can (and should) be fixed in a separate patch, by someone able to test this. > Did you run the new test you added also in remote configuration? No, and I also have no idea how I would go about doing so. Jan