From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7236 invoked by alias); 3 Jul 2019 16:18:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7094 invoked by uid 89); 3 Jul 2019 16:18:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.5 required=5.0 tests=AWL,BAYES_00,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=ship X-HELO: EUR03-VE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr50086.outbound.protection.outlook.com (HELO EUR03-VE1-obe.outbound.protection.outlook.com) (40.107.5.86) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Jul 2019 16:18:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vp8/xjxNPBw8wx1YXd1/iVvUGRL8DYgS4cpzt5Z+U8g=; b=brvVgp/dFH8zZkATrvEsklFTS/be/Rqm6jI7a4VV1igHIN1Z6yFrrzAI5Z8MIEslkE9YlvmBzobQRHzVwqe6br0HbhtS5+b8iSxuNn+pkK2uiQJWn9aEn9figUJc94M4hXudf6/cdJ82/lB9SqoS+I5dx2jg3hMs9m+WfGiT0X4= Received: from VI1PR0801CA0083.eurprd08.prod.outlook.com (2603:10a6:800:7d::27) by AM6PR08MB4312.eurprd08.prod.outlook.com (2603:10a6:20b:b8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.17; Wed, 3 Jul 2019 16:18:39 +0000 Received: from DB5EUR03FT042.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e0a::207) by VI1PR0801CA0083.outlook.office365.com (2603:10a6:800:7d::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2052.17 via Frontend Transport; Wed, 3 Jul 2019 16:18:38 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT042.mail.protection.outlook.com (10.152.21.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2032.15 via Frontend Transport; Wed, 3 Jul 2019 16:18:36 +0000 Received: ("Tessian outbound 86cdd11d53e6:v23"); Wed, 03 Jul 2019 16:18:36 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 14c1f02ff02f04b5 X-CR-MTA-TID: 64aa7808 Received: from 95660daac486.1 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.1.52]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id D347641C-8DC4-403F-B992-DC80BA9F9B52.1; Wed, 03 Jul 2019 16:18:31 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01lp2052.outbound.protection.outlook.com [104.47.1.52]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 95660daac486.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384); Wed, 03 Jul 2019 16:18:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vp8/xjxNPBw8wx1YXd1/iVvUGRL8DYgS4cpzt5Z+U8g=; b=brvVgp/dFH8zZkATrvEsklFTS/be/Rqm6jI7a4VV1igHIN1Z6yFrrzAI5Z8MIEslkE9YlvmBzobQRHzVwqe6br0HbhtS5+b8iSxuNn+pkK2uiQJWn9aEn9figUJc94M4hXudf6/cdJ82/lB9SqoS+I5dx2jg3hMs9m+WfGiT0X4= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2216.eurprd08.prod.outlook.com (10.172.227.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2032.20; Wed, 3 Jul 2019 16:18:28 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::259b:8edf:fb65:2760]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::259b:8edf:fb65:2760%8]) with mapi id 15.20.2032.019; Wed, 3 Jul 2019 16:18:28 +0000 From: Alan Hayward To: Pedro Alves , Tom Tromey CC: "gdb-patches@sourceware.org" , nd Subject: Re: [RFC 2/2] Move gdb's xmalloc and friends to new file Date: Wed, 03 Jul 2019 16:18:00 -0000 Message-ID: <5B7E81C9-C5FC-47AA-AFE9-61031E9C276A@arm.com> References: <20190530213046.20542-1-tom@tromey.com> <20190530213046.20542-3-tom@tromey.com> <87a7egkszy.fsf@tromey.com> <43591E27-A08D-4138-BB6E-C09BFEA03524@arm.com> In-Reply-To: <43591E27-A08D-4138-BB6E-C09BFEA03524@arm.com> Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; X-Microsoft-Antispam-Untrusted: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:DB6PR0802MB2216; X-MS-Exchange-PUrlCount: 4 x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(136003)(376002)(346002)(39860400002)(366004)(396003)(199004)(189003)(186003)(99286004)(256004)(476003)(2906002)(2616005)(4326008)(57306001)(486006)(71200400001)(11346002)(36756003)(66556008)(66066001)(6486002)(66446008)(478600001)(73956011)(86362001)(316002)(64756008)(76116006)(5660300002)(66476007)(6246003)(446003)(91956017)(66946007)(6116002)(25786009)(71190400001)(6436002)(26005)(229853002)(33656002)(8936002)(68736007)(110136005)(16799955002)(54906003)(53936002)(53546011)(6512007)(102836004)(6306002)(6506007)(81166006)(7736002)(76176011)(81156014)(8676002)(14454004)(3846002)(305945005)(966005)(50226002)(72206003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2216;H:DB6PR0802MB2133.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: vkYTsacqe6hhAcdTLEzUbYHYjiVci0xGHuXrh9el6sdK94wjD1nOEX7ewiA2twhtHuZz4tTR3m7Ri5OkfXS5ddJ49v2LFrA+ubbGHTt8ZVxh4KJuexRgA1A0NVYIR05+6wPSSPBJH6i3SYYr15LOZmLB26vfm21uISaQaxzEeRrIyeuBKGXUYwthS94yfd4lPzh9alTxKlppUU7s5sprv3ru4p61/+UJYjxQSQyGOct0N4MAfwCNH50tF0kDxy60sn06y8EHR3vLM7anpWaz9Lncx5ecyHl/qvFH7p2EYrGzh/GkhFa3z7C+uxMipKyo5Vz5OXlmgL29MaKyQTRiZlOcvk6ZfBkeNsl1acZOS0B2Nna5uhN7ttWGmkDChEp4863SGQAMtbIiqScB9LngLMHqxDXi5OTDS52iH1mLnjo= Content-Type: text/plain; charset="utf-8" Content-ID: <935EBD2981A98C4282559177F68F4628@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; Return-Path: Alan.Hayward@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 072ebd64-b3c3-407d-990e-08d6ffd21548 X-IsSubscribed: yes X-SW-Source: 2019-07/txt/msg00070.txt.bz2 DQoNCj4gT24gMTggSnVuIDIwMTksIGF0IDEwOjMwLCBBbGFuIEhheXdhcmQg PEFsYW4uSGF5d2FyZEBhcm0uY29tPiB3cm90ZToNCj4gDQo+IA0KPiANCj4+ IE9uIDE3IEp1biAyMDE5LCBhdCAxOTozNywgUGVkcm8gQWx2ZXMgPHBhbHZl c0ByZWRoYXQuY29tPiB3cm90ZToNCj4+IA0KPj4gT24gNi8xNy8xOSA2OjQz IFBNLCBUb20gVHJvbWV5IHdyb3RlOg0KPj4+Pj4+Pj4gIkFsYW4iID09IEFs YW4gSGF5d2FyZCA8QWxhbi5IYXl3YXJkQGFybS5jb20+IHdyaXRlczoNCj4+ PiANCj4+PiBBbGFuPiBMb29rcyBsaWtlIHRoaXMgYnJlYWtzIHRoZSBidWls ZGluZyBvZiBhbGxvYy1pcGEubyB3aGVuIHVzaW5nIE1ha2UgMy44MQ0KPj4+ IEFsYW4+IEnigJl2ZSB0cmllZCB0aGlzIG9uIGEgZmV3IGRpZmZlcmVudCBt YWNoaW5lcy4NCj4+PiANCj4+PiBUaGFua3MuDQo+Pj4gDQo+Pj4gTXkgZmly c3QgdGhvdWdodCBpcyB0aGF0IG1heWJlIHdlIHNob3VsZCBzaW1wbHkgZGVj bGFyZSAzLjgxDQo+Pj4gdW5zdXBwb3J0ZWQuICBJdCB3YXMgYXBwYXJlbnRs eSByZWxlYXNlZCBpbiAyMDA2Og0KPj4+IA0KPj4+ICAgaHR0cHM6Ly9zYXZh bm5haC5nbnUub3JnL2ZvcnVtL2ZvcnVtLnBocD9mb3J1bV9pZD00MzgwDQo+ Pj4gDQo+Pj4gLi4uIHNvIGl0IGlzIHF1aXRlIGFuY2llbnQuDQo+Pj4gDQo+ Pj4gSXMgdGhlcmUgc29tZSBjb21wZWxsaW5nIHJlYXNvbiB0byBrZWVwIHN1 cHBvcnRpbmcgaXQ/DQo+Pj4gDQo+PiANCj4+IEkgdGhpbmsgaXQgZGVwZW5k cyBtb3JlIG9uIHdoYXQgZGlzdHJpYnV0aW9ucyBzaGlwIHRoYW4gd2hhdA0K Pj4gdGhlIHJlbGVhc2UgZGF0ZSB3YXMuICBFLmcuLCBpZiB5b3UgbG9vayBh cm91bmQgdGhlIGxhc3QgY291cGxlDQo+PiBzdGFibGUgcmVsZWFzZXMgb2Yg cG9wdWxhciBzdGFibGUgZGlzdHJvcyAoZS5nLiwgdWJ1bnR1LCBkZWJpYW4s IGZlZG9yYSksDQo+PiB3aGljaCBHTlUgTWFrZSB2ZXJzaW9uIGRpZCB0aGV5 IHNoaXA/ICBJZiB0aGUgR05VIE1ha2UgdmVyc2lvbiBzaGlwcGVkDQo+PiBi eSBkZWZhdWx0IGlzIG5vdCA0LngsIGlzIHRoZXJlIGFuIGVhc3kgb3B0aW9u YWwgcnBtL2RlYiBwYWNrYWdlDQo+PiBmb3IgR05VIE1ha2UgNC54IGF2YWls YWJsZT8NCj4+IA0KPj4gVGhpcyB3YXMgdGhlIHNhbWUga2luZCBvZiBpbnZl c3RpZ2F0aW9uIHRoYXQgbGVkIHRvIHRoZSBHQ0MgNC44DQo+PiBtaW5pbXVt IHJlcXVpcmVtZW50Lg0KPj4gDQo+PiBBbHNvLCBsb29raW5nIGFyb3VuZCB0 aGUgR0NDIGNvbXBpbGUgZmFybSBtYWNoaW5lIChpbmNsdWRpbmcgdGhlDQo+ PiAvb3B0LyBkaXJzKSBmb3Igd2hhdCBpcyBhdmFpbGFibGUgbWF5IGJlIGEg Z29vZCBoaW50L3Byb3h5IGZvcg0KPj4gZGV0ZXJtaW5pbmcgd2hldGhlciBi dW1waW5nIHRoZSByZXF1aXJlbWVudCBjb3VsZCBjYXVzZSB0cm91YmxlDQo+ PiBmb3IgcGVvcGxlLg0KPiANCj4gDQo+IEdsaWJjIHJlcXVpcmVzIDQuMDoN Cj4gaHR0cHM6Ly93d3cuc291cmNld2FyZS5vcmcvbWwvbGliYy1hbHBoYS8y MDE4LTA4L21zZzAwMDAzLmh0bWwNCj4gCUNoYW5nZXMgdG8gYnVpbGQgYW5k IHJ1bnRpbWUgcmVxdWlyZW1lbnRzOg0KPiAgCUdOVSBtYWtlIDQuMCBvciBs YXRlciBpcyBub3cgcmVxdWlyZWQgdG8gYnVpbGQgZ2xpYmMuDQo+IA0KPiAN Cj4gR0NDIHN0aWxsIGFsbG93cyAzLjg6DQo+IGh0dHBzOi8vZ2NjLmdudS5v cmcvaW5zdGFsbC9wcmVyZXF1aXNpdGVzLmh0bWwNCj4gCUdOVSBtYWtlIHZl cnNpb24gMy44MCAob3IgbGF0ZXIpDQo+IA0KDQpJ4oCZdmUgZG9uZSBhIGxp dHRsZSBtb3JlIGRpZ2dpbmcgaW50byBhcyBtYW55IG1hY2hpbmVzIGFzIEkg Y291bGQgZmluZDoNCg0KVWJ1bnR1IDE2LjA0LCAxOC4wNCAtIG1ha2UgNC4x DQpVYnVudHUgMTQuMDQgLSBtYWtlIDQuMA0KRmVkb3JhIDI3IC0gbWFrZSA0 LjIuMQ0KUmVkaGF0IDcuNSwgQ2VudG9zIDcuNSwgQ2VudG9zIDYgLSBtYWtl IDMuODINClJlZGhhdCA1LjgsIDYuOSAtIG1ha2UgMy44MQ0KT3BlblN1c2Ug NDIuMiAtIDQuMi4xDQoNCkFsc286IGh0dHBzOi8vc29mdHdhcmUub3BlbnN1 c2Uub3JnL3BhY2thZ2UvbWFrZSBjb25maXJtcyBhIG1peCBvZiA0LjIxIGFu ZA0KMy44MiBhcyB0aGUgdmVyc2lvbnMgaW4gdmFyaW91cyBsYXRlc3QgZGlz dHJvcy4NCg0KSeKAmXZlIHRyaWVkIGJ1aWxkaW5nIHVzaW5nIG1ha2UgMy44 MiwgYW5kIGl0IHdvcmtzIGZvciBtZS4NCk1ha2UgMy44MiB3YXMgcmVsZWFz ZWQgaW4gMjAxMC4NCg0KQW55IG9iamVjdGlvbiB1cHBpbmcgdGhlIG1pbmlt dW0gbWFrZSB2ZXJzaW9uIHRvIDMuODIgPw0KDQpJZiBzbyBJIGNhbiByYWlz ZSBhIHBhdGNoIHRvIGFkZCBhIHN0YXRlbWVudCB0byB0aGUgTkVXUyBmaWxl IChzaW1pbGFyIHRvDQp0aGUgb25lIHRoYXQgYWxyZWFkeSBleGlzdHMpLg0K DQoNCkFsYW4uDQoNCg0KDQoNCg== >From gdb-patches-return-157243-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Jul 03 16:25:18 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 90753 invoked by alias); 3 Jul 2019 16:25:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 88611 invoked by uid 89); 3 Jul 2019 16:25:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=quoting, whoever, day X-HELO: mail-wr1-f65.google.com Received: from mail-wr1-f65.google.com (HELO mail-wr1-f65.google.com) (209.85.221.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Jul 2019 16:25:15 +0000 Received: by mail-wr1-f65.google.com with SMTP id v14so3536974wrr.4 for ; Wed, 03 Jul 2019 09:25:09 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id l1sm2142652wmg.13.2019.07.03.09.25.07 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 03 Jul 2019 09:25:07 -0700 (PDT) Subject: Re: [PATCH 3/5] Teach gdb::option about string options To: Tom Tromey References: <20190627191427.20742-1-palves@redhat.com> <20190627191427.20742-4-palves@redhat.com> <87woh5zqw1.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <598989d8-1b67-7ee2-14a1-30a1eb74b098@redhat.com> Date: Wed, 03 Jul 2019 16:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <87woh5zqw1.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-07/txt/msg00071.txt.bz2 Content-length: 1188 On 6/28/19 4:11 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> This commit adds support for string options, mapped to var_string. > Pedro> For now, a string is parsed up until the first whitespace. I imagine > Pedro> that we'll need to add support for quoting so that we could do: > > Pedro> (gdb) cmd -option 'some -string' > > Pedro> without gdb confusing the "-string" for an option. > > Pedro> This doesn't seem important for pipe, so I'm leaving it for another > Pedro> day. > > I wonder if we should file bugs for known holes like this. > On the one hand it seems nice to write down what we know. > On the other hand, maybe nobody will ever look at these. Yeah on the later. I don't see anyone fixing that until we have some option that requires it, and then, whoever implements such an option will quickly run into it for sure. > > Pedro> + /* Disable the copy constructor. */ > Pedro> + option_def_and_value (const option_def_and_value &rval) = delete; > > I wonder if it makes sense to disable operator= as well. Indeed, I don't recall why I didn't use DISABLE_COPY_AND_ASSIGN. I've done that now. Thanks, Pedro Alves