From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12825 invoked by alias); 24 May 2011 12:41:37 -0000 Received: (qmail 12814 invoked by uid 22791); 24 May 2011 12:41:36 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 May 2011 12:41:22 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id DD5FFCB029D; Tue, 24 May 2011 14:41:21 +0200 (CEST) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9K2CG+n6CtOC; Tue, 24 May 2011 14:41:18 +0200 (CEST) Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id E32DFCB022E; Tue, 24 May 2011 14:41:18 +0200 (CEST) Subject: Re: [PATCH 1/4] Really make dwarf2_get_section_info public. Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Tristan Gingold In-Reply-To: Date: Tue, 24 May 2011 12:41:00 -0000 Cc: gdb-patches@sourceware.org Content-Transfer-Encoding: 7bit Message-Id: <5AB9D844-7575-4D93-83E3-DE79DFB2473A@adacore.com> References: <1306146544-3925-1-git-send-email-gingold@adacore.com> <1306146544-3925-2-git-send-email-gingold@adacore.com> To: Tom Tromey X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00561.txt.bz2 On May 23, 2011, at 5:15 PM, Tom Tromey wrote: >>>>>> "Tristan" == Tristan Gingold writes: > > Tristan> This patch is a preliminary clean-up. Instead of using the > Tristan> section name to get the section info, use an enum literal. > > Looks reasonable, just one nit. > > Tristan> It might be worth going farther and using an array of > Tristan> dwarf2_section_info in dwarf2_per_objfile (instead of record > Tristan> fields). I let this decision to maintainers. > > I think it is fine as is. > > Tristan> +enum dwarf2_section_enum { > Tristan> + dwarf2_debug_frame, > Tristan> + dwarf2_eh_frame > Tristan> +}; > > It is customary for enum constants to be upper-case. > Ok with this change. Thank, committed with the enum constants in upper-case. Tristan.