On 09/19/2018 06:56 AM, Tom Tromey wrote:
> [snip]
> 
> Perhaps the early returns should call "untested".  I'm on the fence
> about this, sometimes it is done, sometimes not.  I don't know if it
> matters to anybody -- I never really look at these lines.
> 
> https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#A.22untested.22_calls
> 
> Second, this particular check runs early.  I wonder if readline_is_used
> actually works at this spot, because I would imagine gdb isn't running yet.
> What does "runtest cpls-ops.exp" do?

Ooops, my bad.  :-(  I'd checked that the failures went away, but hadn't 
looked closely at the logs to see that it was complaining about an error 
there.

I've fixed it by moving the check after gdb is started, and also added 
the "untested" calls.  This is the version of the patch I've checked in.

-Sandra