From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106849 invoked by alias); 8 Jun 2017 20:52:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106579 invoked by uid 89); 8 Jun 2017 20:52:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 08 Jun 2017 20:51:58 +0000 Received: by simark.ca (Postfix, from userid 33) id 5013E1E4B1; Thu, 8 Jun 2017 16:52:01 -0400 (EDT) To: Stafford Horne Subject: Re: [PATCH 3/3] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 08 Jun 2017 20:52:00 -0000 From: Simon Marchi Cc: GDB patches In-Reply-To: <0c4f5b59a645a64535e7c8bb0f34b03df805f4e4.1496871270.git.shorne@gmail.com> References: <0c4f5b59a645a64535e7c8bb0f34b03df805f4e4.1496871270.git.shorne@gmail.com> Message-ID: <59d8e3de4d7d586a39306ac65a1c7638@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.5 X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00220.txt.bz2 Hi Stafford, On 2017-06-08 00:15, Stafford Horne wrote: > @@ -1081,17 +1080,13 @@ tdesc_remote_register_number (struct gdbarch > *gdbarch, int regno) > } > > /* Check whether REGNUM is a member of REGGROUP. Registers from the > - target description may be classified as general, float, or vector. > - Unlike a gdbarch register_reggroup_p method, this function will > - return -1 if it does not know; the caller should handle registers > - with no specified group. > - > - Arbitrary strings (other than "general", "float", and "vector") > - from the description are not used; they cause the register to be > - displayed in "info all-registers" but excluded from "info > - registers" et al. The names of containing features are also not > - used. This might be extended to display registers in some more > - useful groupings. > + target description may be classified as general, float, vector or > other > + register groups registerd with reggroup_add(). Unlike a gdbarch s/registerd/registered/ > @@ -1231,6 +1209,27 @@ tdesc_use_registers (struct gdbarch *gdbarch, > void **slot = htab_find_slot (reg_hash, reg, INSERT); > > *slot = reg; > + /* Add reggroup if its new. */ > + if (reg->group != NULL) > + { > + struct reggroup *group; > + bool group_exists = false; > + > + for (group = reggroup_next (gdbarch, NULL); > + group != NULL; > + group = reggroup_next (gdbarch, group)) > + { > + if (strcmp (reg->group, reggroup_name (group)) == 0) > + { > + group_exists = true; > + break; > + } > + } > + > + if (!group_exists) > + reggroup_add (gdbarch, reggroup_new (reg->group, > + USER_REGGROUP)); Is the memory allocated by reggroup_new ever freed? Simon