From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AU7sFT3axmkcFTwAWB0awg (envelope-from ) for ; Fri, 27 Mar 2026 15:27:57 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=windriver.com header.i=@windriver.com header.a=rsa-sha256 header.s=PPS06212021 header.b=iAaZZD6y; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 520801E08C; Fri, 27 Mar 2026 15:27:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 800911E08C for ; Fri, 27 Mar 2026 15:27:56 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 32E064BA23E5 for ; Fri, 27 Mar 2026 19:27:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 32E064BA23E5 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=windriver.com header.i=@windriver.com header.a=rsa-sha256 header.s=PPS06212021 header.b=iAaZZD6y Received: from mx0b-0064b401.pphosted.com (mx0b-0064b401.pphosted.com [205.220.178.238]) by sourceware.org (Postfix) with ESMTPS id C132D4BA23D5; Fri, 27 Mar 2026 19:27:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C132D4BA23D5 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=windriver.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=windriver.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C132D4BA23D5 Authentication-Results: server2.sourceware.org; arc=fail smtp.remote-ip=205.220.178.238 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1774639644; cv=fail; b=Z2fEwMF2m+YNQ5vrZgNxZjuqnTBAawOLqDG7gPYeL58SAN/mxazWgNFJWocj3KC8D25k9orLAtOHSOud8NrEQiazYU+WdKphbZCJdOcXwlrISHP3Kkfei2NWq1ADxXDgBFlg4tXAGu1H+tFKJcpZspWaUi2P4T1kNNQckJEkE24= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1774639644; c=relaxed/simple; bh=ZKbVkr0/gO5I8SfE6QlmGDR4j6oI07iRxTpKS+qqGxU=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=hLv2UZGSV4+mrQ5AyeoLTVE0n7gLQ2H+eSdGQyboVstTlJNd75b4hNjuLLHQGVRdxsBwXzRpvx7fI9MelKAXPtWDtj/KvK1rtJY+t4fSFEiWEeNCp3Ny2TJgbfJNs/0g4MSlPiRkOeFgHMpN/qpgKhDGb8fClhSvfroq75UmfAQ= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C132D4BA23D5 Received: from pps.filterd (m0250811.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62RCVLpT1485173; Fri, 27 Mar 2026 19:26:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=cc:content-transfer-encoding:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to; s= PPS06212021; bh=j8d0qU99WcDf2flYhcIb6Jbmp6XJa/o6b5/lnn7IXJI=; b= iAaZZD6y8B1a7sGoKuEfW4Esy7cZ6Sxd0H4tFosgDZS0z3HMQTUWT9jG6UO/pggx VA7OqU3Z0rswXpBnTYhc2T0aZHutevse0+j8rCqQDwLorTz3/oE+240GG5tDi3Qg Lc4En2qbrwT7uhbPlKcV28KiE+CkRqxXQuh7lK+pVqaxxrj/o/2/Eme06o7e6EbB wHdq+5RrnGR4WBcctzuUHg4lhzq3C6GN2vo87qCK2XjQ3R6KqJF184u8oC7ok8Yz Em5FoooLQqVqBvDij5z2gm3FQcg9GujrSVCqAv/MXo8pijiK6bHgheQAcrgeRPSM mY3qQGqVeg3owUZyah0JFA== Received: from bl2pr02cu003.outbound.protection.outlook.com (mail-eastusazon11011017.outbound.protection.outlook.com [52.101.52.17]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 4d5p52gp1r-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 27 Mar 2026 19:26:56 +0000 (GMT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QzsrqSA+IMSj18VtufVk65D/lCNSgKXseG/LNEGwikeitNGRoVinWduM8zqZeT5nMLb6mXAID4KLZnRVgbc5nG7/sJMqgboBWKpG0Zq5FFtDJq2g4U4H6XvDPLeSx+RcEjOlVsP3YxQv2VmSPhUUnVS7tZX6PIztEWu7B04KLMEd+mDq1Ms5fd5+RuC9lptMJQCIZxQmZxFvIgkjOiS3YbuZ/tBxXU7DjGcDRU5p2dofs1C9uBaw+ABuwTx+uoQLXq2YdlpFb1Gyvjy2M2xhtiyUbEGWcjmBFc0pqQyDBUH4+wotDvMUaf0KGqj7dEz/R5g/Y3/pUEe8FvO2eWa0ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j8d0qU99WcDf2flYhcIb6Jbmp6XJa/o6b5/lnn7IXJI=; b=l3vt1YHFv8L2HhCJYAt67PnBVQaXGb5rlSiWnPlqvvxx1szJx9tzuMV8UIjFZsPwtP1rDXTJugLh04uaylP+ISPP6RUllfO30tvcVlI1F8TTSvyOA/JddyZFPo4Rn3TsOP2dKdhGfyXeFWI8mkAQoSWKdgPi3xNgiuyi9TyoPxDVWMawAS3eG/4+mgqVrqMCEyiUKirX2Pjj1IJ1nWu9YI5A4BBjXe0mFxk/ka8Jd2luIqnkEmd1WFIgCo+N2NXEXA1VOgR0YOXRGomOvHtQvZtdB5cVVnzoxTsQasEOGMEuBacuUpPtX5vLnqXVsj5xAHJwGTgzxOt8HdEw7IAxmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from DS0PR11MB7901.namprd11.prod.outlook.com (2603:10b6:8:f4::20) by SA1PR11MB6871.namprd11.prod.outlook.com (2603:10b6:806:2b1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.7; Fri, 27 Mar 2026 19:26:53 +0000 Received: from DS0PR11MB7901.namprd11.prod.outlook.com ([fe80::4293:7c4b:a0b5:eb5f]) by DS0PR11MB7901.namprd11.prod.outlook.com ([fe80::4293:7c4b:a0b5:eb5f%3]) with mapi id 15.20.9769.006; Fri, 27 Mar 2026 19:26:53 +0000 Message-ID: <59bed5d9-b51e-4d37-b823-91c65b0e26c5@windriver.com> Date: Sat, 28 Mar 2026 00:56:43 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 0/2] PR gdb/33747: gdb/ser-unix: fix musl build failure and add POSIX custom baud rate support To: Kevin Buettner Cc: gdb-patches@sourceware.org, macro@orcam.me.uk, eliz@gnu.org, Randy.MacLeod@windriver.com, Sundeep.Kokkonda@windriver.com, schwab@linux-m68k.org, tromey@sourceware.org, simark@simark.ca References: <20260324164527.1446549-1-sunilkumar.dora@windriver.com> <20260327111515.3adb29a9@f42-zbm-amd> Content-Language: en-US From: Sunil Kumar Dora In-Reply-To: <20260327111515.3adb29a9@f42-zbm-amd> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MA0P287CA0007.INDP287.PROD.OUTLOOK.COM (2603:1096:a01:d9::18) To DS0PR11MB7901.namprd11.prod.outlook.com (2603:10b6:8:f4::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7901:EE_|SA1PR11MB6871:EE_ X-MS-Office365-Filtering-Correlation-Id: d57d3c06-e813-4124-308b-08de8c36cd04 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|1800799024|376014|22082099003|56012099003|18002099003; X-Microsoft-Antispam-Message-Info: Ev4W5QxCDUaCa60m5/WETGYDbWud7ceMlkUxAj9E3dDR+VnyyCw9HoLxlnoZLfovfI0HuH+jsCoM8P5mpj+Tiflz3yLaBiXQrhqvtg9wY8k9CydbXzSp4MiOWNLxYASqe/RBVJ92gf3b+eNijkLF27qKUIhWRkoux1B7l6+s+tyCJ7iqh4dSLuI8B8nzhPQPZE6yewYjzkQzgvuFLXCrv0rTXvtLSdGfg6xXHnzkVt2KF0JazSpyvk9XX/o8XNvlrx3QmPO6AD6xwLvAhH4WzciY1G3DbG9Jq6MKGDFNMkOdYj3Wcm7wGN3Zc4OwXpj/fMe+/t4YL0tjxEEeJtGF42AFgtikwBnuyWuJM61X5hLP0OPnlTGVXV+eMKGZ16wL4e5+WVVJJiANTgcrDqLbPgP6ixOXBimfN7I16rVaphyFdHkPffgw5wh+xxUM35d7PrwMru3Hn4AnbAc5ZVMwVjSDTfLlyQuQInEzxdruHwXyIFOc/Z4t0P1S8W/JlIHTeuROQtG8dMutOg90t8hEkB4wElHoLyMA2tLo28gl0z2yPDYJ01yZCuJgK8D92eu7w6EBPrBEAO0mXbU3/6uJc8RnOialtOvlDGMdMoTLrYb/yXuGDhJZ4OnBTr4HF3QQLTzRcO0yZD1bRRw9fmVLREhncWl3Dj2A9ZPrCCiqczHJQTMgQl8fcjn5AHt0Tz/B X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7901.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(22082099003)(56012099003)(18002099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVVaeFlrS3NOemxoSU5sbllqRnRUckRtR1hYTUgzTW1PcDBBSzBrc003cDZy?= =?utf-8?B?OEdwU3dPdE9TT21lZEt5MjFGN2gxNkwyczdrUk5GUjhQVUJPdktRM2lYYThW?= =?utf-8?B?NTNGYTRrUEdMSzdsbm50cG14YnZZY2RMc1pPSTBVR0IrUlk3VmZuWC9KaHkx?= =?utf-8?B?cllSdzJXWHV4SXVhazVxOGxtZzBOeTQ4amdwZnlOY2pFbUVETUhacmRhYVpy?= =?utf-8?B?MmpaeWx2Qm1CSURydGwzOWlWazF4bTJjdnp3NmF2dmZHMVJrZmprYWpzMllw?= =?utf-8?B?N29zUTRlbndlQUpkM0x5NktSOUZ2ZFJqZDd4VVJJdTFrdlk0RUgrYk5ickFn?= =?utf-8?B?dUNOR3NaQTVvVUhhMmc0SW9Sa3oyN3ZneFdYU2hMalRBRFNMZzhsTFc3d0xD?= =?utf-8?B?SXppUVZ3V3Y5cERJaWJoNmpsTTcwUDM1OTE1eUlaUU02My9mbmhOcC9DbnBk?= =?utf-8?B?TFZzNjJwdlRHNXV3bFlJd2JZNk1UMks0Zm1iY2o4K0Z0a2hFS3JvRDdEcHIy?= =?utf-8?B?VmFyRWFQOW51M09Hci9SRGVKblJQVnN3Y0szRUpjbVkvVjhPUGw3MHJzbklX?= =?utf-8?B?M2hUKzcyencyazJnV1hmWndHcGRUcUNhemF5MGVsWndQRHNwTnpkMld4bTkr?= =?utf-8?B?bk5XZWtDMnlVN1NRWVgrcHNlNHYxMVJvNE5OL1p2Vm8vZ0lDWmVzRGFoOTFl?= =?utf-8?B?QUhXUE5HdlA1YURoenVIS3JETE80aXFya29sa2U1KzlNQ0IyOFNQREpsTERG?= =?utf-8?B?QUp0elA3WnpUeGpwZFhjZXRZdDdSS3JNbU1hSFVlYnNjVnJyUzNaSUxxRDZp?= =?utf-8?B?azFQK2tpZXBWZVl6UjhTVTR0czVLOGt5WXk5ZlhBTThEU2VwR1VqdXBad05Z?= =?utf-8?B?WnNNUmVXL3plYldWaFdoWG0vMjFicUkxMkhZaUE5UTYwa3JpV295K3lueEwr?= =?utf-8?B?b0ZzSVhMdjUrRnhsVVdQb3V6akxjSEYwNlFRSVorTmwzNHM1bmp6YzA5WGdZ?= =?utf-8?B?R3VMYng0M2taaEhkZDA2TFpYVGRCeStQN2duK3JnM3VjWHdMcmFCOVhRaEY4?= =?utf-8?B?L3E1WHI1NzRYZnJQTnE2VS9kRVVFdStzVGlyVTdhc2FJcjRla0ZlZWgwdExo?= =?utf-8?B?UDJ2M0Vnd05GTHlLS1d0aWpIc0VjTGdPaDR1S2Ixa2RDb1lJZjA5T1FEYlha?= =?utf-8?B?Z21CSHdKOEZSVWlndXh2SHJMMllQNVlWNWRnaWlMNVJyOGRJRS9CV01xT29r?= =?utf-8?B?MW1TUUVDcUdndTl5WDFQSUVXRGxSaC9sK2VyUFBNeEFhd1JVcTZUNklpS3Zm?= =?utf-8?B?YzMrc3ZiOFZGSnRCWU85V3NmK0gwL0JJcElwVVRHRldyc29TYWo1ZzlDMWUv?= =?utf-8?B?SDJ3Rmh4UmYzeG1jL1IxWTBuL1pHN0hZamVOc1F1QzgreG5FR2s5RzFhR21k?= =?utf-8?B?LzAzUW1aQXBoeVQxeHNlaTFqRzNZWFd4VVZKRVNtdExEODZOMTBoSzR1M0Zk?= =?utf-8?B?TlkvdnBiVWwzMXRYMHZwQm8vSVgrUzJ6Zk42MWFGS1NyS2RGNGJWOVl6MUZM?= =?utf-8?B?clNjaTBPakpVUDFDMUhhRldEcitkUVZhSHpqcTIyUWRDTnZicHoxS0RDaUx3?= =?utf-8?B?YU9oM1MweFc4Q3RxdWhpb2hHZVNpRExFUWVUOWRkam1FS3lia1RMUk9Ldmh5?= =?utf-8?B?UGp5bis4eUJ1bE9DVmtwUjF0bnJWVHpWTmFyRTk1b0p0Z2J4clN0Sml4ZXB2?= =?utf-8?B?T0pjK0JkblRaMUNpa1cxUlBVaFVyZXp4dmxSdElnVW5waFY4RWtJa2c1VjBZ?= =?utf-8?B?Ui9wYlJOVGk1V0Ztc2FDdjczb1J2dGFmaDRCOFYwYUZHaXk1VjlVUDBvd0g5?= =?utf-8?B?YVRybTJMVmpDdWxuTmpwRXE5L0o0VHdzOUdJdkZob0VFQ2FLZUZjV2h0cFhy?= =?utf-8?B?VFRpelFMTmE4OTRVcTBHMzFvVnc0T042aWF3cEsyMXZJS3VUZW9zcVhudCtv?= =?utf-8?B?L0xWQUIzdHRQaUxJWUFkQ3J3c0VOeEUwcTF1RWcxUU9XL1FmT2NFSnE3bEVI?= =?utf-8?B?NlJjQURQd25ITm1ZbU9YaTJmVCtXWTMvQi9KWWNxYTNyUE1raWQ5ZzFSU2pV?= =?utf-8?B?RXFzNEM2b0ZTZnd2VGxGOWFpYmxRNkVINWFoWjBRRFJJOUJmRjhSR0VVYmU3?= =?utf-8?B?Z3crVGxTbFNIVktPbWF0Tk8zRGNkakU4N2FNT0FDUjd1dXhoRGJ1SWp4S2N2?= =?utf-8?B?SzNhcDZYRDBaNG0yWWk0MTdEWFc2QnpUR2dPWm40R21OWHA1eTZRclNmdVBz?= =?utf-8?B?RUE4VFFYU2hGL3Q3SnZwL1RVQkJPNVd0akJSYzJiVndBVDdBYy9OQkFuSEly?= =?utf-8?Q?3aHk0gwRI9b+ZUwo=3D?= X-Exchange-RoutingPolicyChecked: uD2rnCBsqJUJ0KXqlaor6hiOJKXq3L45Hyn9xX4YNmt3K4Dg9yLB33gSP75kRUr1OduhI3G9uNlDlEYpx+73Ui3GVJveZmLJ7k9MCmC5cO+GC6pn+vBxQlt6N0kqB7A0uxBunFHScCnPypvFVe1f8mJ2QTAg13Hl/lgm4/rD1xXxehMndI1JqdQTD+W5t3SLU6pBKSuTib1mhcVNOeUBJv0kZZ2MuanJLxv44ZQ3jIqtlcbu6mW04ozl1f/xX5lwFzSJtT7sE+ROTskER82pBt2OTl0dOnnFVBn5Pq/HUnG27ViYMVwpVApL51PTHRCY7oxToYkyv6y+zYni3Kev4w== X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: d57d3c06-e813-4124-308b-08de8c36cd04 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7901.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2026 19:26:53.2556 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Gdl5l6cwybG8jbvnAG4b+cteiUIwBb7qZZmphPqidJ80tZZP3PpYLyEvtC31AY+OHaocXq/ijg4Ayxw46FJ5gxILhlBRH6WY8B2py1EiFwQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6871 X-Proofpoint-ORIG-GUID: nhaTM0_c19SCW7bi0HMetxim3Ne9C5Qy X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI3MDEzNSBTYWx0ZWRfX89WGMNx0UXmO 8v6qufatNHXu6rEqNS/5jWkIKwTUvNPgHLUz4Z5oxBGAuamWKY/ozs315qhuaHoDjkHb/OHIObl 6ZX08bwrIEFaJBNR1xWKM/ZEZQPDsLQHmmIvECFoOdeS95hxS7vPNQQQ85e3b01qT12cdmochsm BPskY3iSbYmPdPHAvfQu6blAIU19Sxr904hXMATS30gXVcvNOCHkzpCounJd7NQYwIken53Qt1F L/DHEmfmj21yrB6ViAiiIe9aTf5iRy9lWnO0NObnJUhIleI6tfDgs5FwKovif5937V3HS+fvVsn fyH7gYeEXJ1uUOmae+DnCj7x1l3mzFaC7wa519bJprVVadOqIvWpBucBkOmCEs7AwoESihiyf5B QP1ZfslSuSwq624gbXBia8ud4CBNAnTFqqU376f6ZLJlAVEhpwSH+iXFv73cblxfVNcI7kzpoqQ aRFZfxS+4KNgEx8Vmnw== X-Authority-Analysis: v=2.4 cv=FeM6BZ+6 c=1 sm=1 tr=0 ts=69c6da00 cx=c_pps a=FRwzarAYk3lDJRtuO2pFeQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=bi6dqmuHe4P4UrxVR6um:22 a=klDOsUkWDRETUCZYPvoE:22 a=CCpqsmhAAAAA:8 a=t7CeM3EgAAAA:8 a=20KFwNOVAAAA:8 a=OPYyg0gGmbipu84Id0MA:9 a=QEXdDO2ut3YA:10 a=ul9cdbp4aOFLsgKbc677:22 a=FdTzh2GWekK77mhwV6Dw:22 X-Proofpoint-GUID: nhaTM0_c19SCW7bi0HMetxim3Ne9C5Qy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-27_01,2026-03-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 suspectscore=0 impostorscore=0 clxscore=1015 phishscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603270135 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Kevin, On 3/27/2026 11:45 PM, Kevin Buettner wrote: > CAUTION: This email comes from a non Wind River email account! > Do not click links or open attachments unless you recognize the sender and know the content is safe. > > On Tue, 24 Mar 2026 09:45:25 -0700 > sunilkumar.dora@windriver.com wrote: > >> From: Sunil Dora >> >> On musl-based systems exposes BOTHER, so the >> Linux-specific custom baud rate path was being compiled. However, >> musl's struct termios does not provide the public members c_ispeed >> and c_ospeed, causing a build failure. >> >> This series fixes the build issue at the macro level (patch 1). >> It then adds the preferred POSIX cfsetispeed/cfsetospeed path as the >> first choice on platforms where the host libc supports arbitrary baud >> rates, such as glibc 2.42 and later, GNU Hurd, and potentially other >> libc implementations (patch 2). The existing Linux (termios2/BOTHER) >> and Darwin (IOSSIOSPEED) paths remain as fallbacks. >> >> The two patches are independent: >> - Patch 1 is a pure build fix with no functional change. >> - Patch 2 adds the new POSIX feature on top of the fixed guard. >> >> set_custom_baudrate_linux is left unchanged. >> >> Changes since V4: >> - Split into two patches, with patch 1 as a pure build fix >> and patch 2 adding the POSIX interface. >> - Fixed #if guard formatting and added full stop to the >> AC_DEFINE description. >> - Removed parentheses from function name references in >> commit messages and comments. >> - Updated NEWS entry to describe which configurations are >> affected. >> >> v4: https://sourceware.org/pipermail/gdb-patches/2026-March/226133.html >> v3: https://sourceware.org/pipermail/gdb-patches/2026-March/225952.html >> v2: https://sourceware.org/pipermail/gdb-patches/2026-February/225251.html >> v1: https://sourceware.org/pipermail/gdb-patches/2026-February/224968.html >> >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33747 > Both parts are approved. Thanks for persevering through the many > requests for changes. > > One thing I noticed - Some error messages in ser-unix.c still use > "Can not" whereas you uniformly (and correctly IMO) use "Cannot". > If you're up for doing a follow-on patch, one which does > s/Can not/Cannot/ on the remaining occurrences would be appreciated. > > Approved-by: Kevin Buettner Thanks for the review and approval, Kevin! I'll send a follow-on patch to fix the "Can not" -> "Cannot" occurrences once this series is merged. Thanks, Sunil