[ was: Re: [PATCH 08/10] Use the linkage name if it exists ]
On 24-04-2020 22:50, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> Hmm, one thing that is odd about this test-case is that it constructs a
> Tom> C language CU, which contains a subprogram with DW_AT_MIPS_linkage_name
> Tom> attribute with a C++ mangled name.
> 
> This sounds very familiar.  I feel like I patched this at some point but
> now I don't know where that patch went.
> 
> Tom> If I update the testcase to use a c++ language CU, the test passes:
> 
> I think this is the correct thing to do.
> The main point of the test is to ensure that the linkage name with the
> wrong form doesn't cause a crash:
> 
> 		{DW_AT_MIPS_linkage_name 42 DW_FORM_data1}
> 
> I suggest you check this in.

Ack, committed as attached below.

Thanks,
- Tom