From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id PTVLCzvT8mC2BQAAWB0awg (envelope-from ) for ; Sat, 17 Jul 2021 08:55:23 -0400 Received: by simark.ca (Postfix, from userid 112) id 1F1C51EDF2; Sat, 17 Jul 2021 08:55:23 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5FF8E1E54D for ; Sat, 17 Jul 2021 08:55:22 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8B5D4384F018 for ; Sat, 17 Jul 2021 12:55:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8B5D4384F018 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1626526521; bh=IahzthUzs7u6LOzANDk/9ob3l8cjSu03ahoTleWYIeo=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=geFPUo5PVFg62CmvAR9gimCiSu6+sM6ppMgnBiwA5waMFIqFtGPcgUoaNqEkMgj+2 CXH+Cfs5jBRD1d43/eYq7NugEZQhl1xAysNSDJbUwalQdli2PMFH/jUJP+iF5fXkX8 CmPvtdKPaV6xKlvbl7gGRjYYIYkA79jsTguqNnYw= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id DE608385743B for ; Sat, 17 Jul 2021 12:55:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DE608385743B Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 16HCst28022878 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 17 Jul 2021 08:55:00 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 16HCst28022878 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 194391E54D; Sat, 17 Jul 2021 08:54:55 -0400 (EDT) Subject: Re: [PATCH] gdb: make all_inferiors_safe actually work To: Tom de Vries , gdb-patches@sourceware.org References: <61f3cd99-8b32-e14a-117e-52aa4c7e6343@polymtl.ca> <20210714201541.1883926-1-simon.marchi@polymtl.ca> Message-ID: <59a0853b-2192-e0c2-bfb2-0b14348e70ea@polymtl.ca> Date: Sat, 17 Jul 2021 08:54:54 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sat, 17 Jul 2021 12:54:55 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-07-15 6:15 a.m., Tom de Vries wrote: > For me as well. > > LGTM. > > One suggestion: I'd do > s%/home/simark/build/binutils-gdb/gdb/testsuite/outputs/gdb.threads/fork-plus-threads/fork-plus-threads%fork-plus-threads% > in the log message for readability. Do you mean in the snippet from gdb.log I pasted? I replaced those with /fork-plus-threads to make it clear that they were hand-edited. Pushed with that fixed, thanks. Simon