From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42141 invoked by alias); 1 Feb 2018 13:19:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 42131 invoked by uid 89); 1 Feb 2018 13:19:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=wasn, obs X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com Received: from mail-he1eur01on0069.outbound.protection.outlook.com (HELO EUR01-HE1-obe.outbound.protection.outlook.com) (104.47.0.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Feb 2018 13:19:52 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0021.eurprd08.prod.outlook.com (10.160.236.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11; Thu, 1 Feb 2018 13:19:48 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::c95:81b8:c681:ae2]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::c95:81b8:c681:ae2%17]) with mapi id 15.20.0464.012; Thu, 1 Feb 2018 13:19:48 +0000 From: Alan Hayward To: Philipp Rudo CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] Move arch/tdesc.h to common/common-tdesc.h Date: Thu, 01 Feb 2018 13:19:00 -0000 Message-ID: <59984094-96C1-4D84-89F6-384769471005@arm.com> References: <97948063-b3db-fd3a-f62e-b552935cb8dd@arm.com> <20180201121443.43322674@ThinkPad> In-Reply-To: <20180201121443.43322674@ThinkPad> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM3PR08MB0021;7:2Iazp61dnyGPfxbmdDUkCDNnNmTRfR14UNPYCJYs24ehRcl53Ry7WxCsM3wTbIHiRuu/365USQ7det6uDLTUUyTu0s1fXxHqnT2TWnD8HfQt0OY/I9xcyeCJgJd9nBUXvMWlOH0DDr4PZ7PTcJMcAidHoOgbuuM5bQDgt8KSqmIO7cd7lxcLGrfJkS9JN/ptrrPSw8VQcyxybua8tngEl4TNXPVqjYaO1l3t2mpYWXtxpxgsZa+AshSygR+1R3M0 x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ba2fd47a-f184-4af3-ed18-08d5697677d3 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020);SRVR:AM3PR08MB0021; x-ms-traffictypediagnostic: AM3PR08MB0021: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(104084551191319); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(3231101)(2400082)(944501161)(10201501046)(6055026)(6041288)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123562045)(6072148)(201708071742011);SRVR:AM3PR08MB0021;BCL:0;PCL:0;RULEID:;SRVR:AM3PR08MB0021; x-forefront-prvs: 0570F1F193 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(39860400002)(346002)(376002)(366004)(39380400002)(199004)(189003)(36756003)(3660700001)(3280700002)(102836004)(76176011)(6512007)(6436002)(53936002)(6246003)(26005)(99286004)(97736004)(53546011)(186003)(83716003)(6506007)(86362001)(316002)(54906003)(72206003)(106356001)(478600001)(68736007)(5660300001)(305945005)(7736002)(6916009)(25786009)(4326008)(82746002)(2950100002)(5250100002)(8676002)(14454004)(6116002)(3846002)(6486002)(66066001)(33656002)(8936002)(81156014)(2900100001)(105586002)(2906002)(229853002)(81166006);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0021;H:AM3PR08MB0101.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: G8SZcX0bWdmRc8Ff/3TKTXbGwP99WoT5U5kEPbp+tBd1QBq7zL/Bk3eq6jkWYBcRvDmoWnuRcRJdyGAcVjFOFA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba2fd47a-f184-4af3-ed18-08d5697677d3 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2018 13:19:47.9446 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0021 X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00008.txt.bz2 DQoNCj4gT24gMSBGZWIgMjAxOCwgYXQgMTE6MTQsIFBoaWxpcHAgUnVkbyA8 cHJ1ZG9AbGludXgudm5ldC5pYm0uY29tPiB3cm90ZToNCj4gDQo+IEhpIEFs YW4sDQo+IA0KPiB0aGUgcGF0Y2ggbG9va3MgZ29vZCB0byBtZS4NCj4gDQo+ IElmIGl0IHdlcmUgZm9yIG1lLCBJIHdvdWxkIGRyb3AgdGhlIGV4dHJhICdj b21tb24tJyBhbmQgY2FsbCB0aGUgZmlsZQ0KPiBqdXN0IGNvbW1vbi90ZGVz Yy5oIOKApg0KPiANCj4gT24gV2VkLCAzMSBKYW4gMjAxOCAxMzo0MDowNCAr MDAwMA0KPiBBbGFuIEhheXdhcmQgPGFsYW4uaGF5d2FyZEBhcm0uY29tPiB3 cm90ZToNCj4gDQo+PiBGb2xsb3dpbmcgb24gZnJvbSByZXZpZXcgY29tbWVu dHMgZm9yOg0KPj4gW1BBVENIIHYyIDUvOF0gVXNlIHRkZXNjIHR5cGVzIGlu IGdkYnNlcnZlciB0ZGVzYw0KPj4gDQo+PiBUaGlzIHBhdGNoIHNpbXBseSBt b3ZlcyBhcmNoL3RkZXNjLmggdG8gY29tbW9uL3RkZXNjLmguDQo+IA0KPiAu Li4gbGlrZSBzdGF0ZWQgaGVyZS4gQnV0IHRoYXQncyBqdXN0IG15IHRhc3Rl LiAgV2hlbiBsb29raW5nIGF0IHRoZSBnaXQgbG9nIGluDQo+IGNvbW1vbi8g SSBkb24ndCBzZWUgYW55IGNsZWFyIHBhdHRlcm4gZm9yIHRoZSBjdXJyZW50 IGJlc3QgcHJhY3RpY2UgaW4gbmFtaW5nDQo+IHRoZSBmaWxlcy4NCj4gDQoN ClRoYXQgcmVzdWx0cyBpbiBjb21tb24vdGRlc2MuaCBhbmQgZ2Ric2VydmVy L3RkZXNjLmgNClRoYXTigJlzIG5vdCBhIHByb2JsZW0gYnkgaXRzZWxmLCBi ZWNhdXNlIHdlIGNhbiBqdXN0IHByZWZpeCB0aGUgZGlyDQpuYW1lIGFzIHBh cnQgb2YgdGhlIGluY2x1ZGUuDQoNCk15IG5leHQgc2V0IG9mIHBhdGNoZXMg d2lsbCB0aGVuIGFkZCBjb21tb24vdGRlc2MuYy4NClRoaXMgaXMgc2xpZ2h0 bHkgbW9yZSB0cmlja3kgYmVjYXVzZSB3ZSBub3cgYnVpbGQgdHdvIHRkZXNj Lm8gZmlsZXMuDQpUaGUgZ2Ric2VydmVyIElQQSBydWxlcyB3aWxsIG5lZWQg dHdlYWtpbmcsIGFuZCBJ4oCZbSBub3Qgc3VyZSB0aGUgT0JTDQpsaXN0IHdp bGwgd29yayBhcyBpdCBpcyAoZ2l2ZW4gaXQgZG9lc27igJl0IGhhdmUgYW55 IGRpciBuYW1lcykuDQoNCkxpa2UgeW91LCBJIHdhc27igJl0IHN1cmUgaWYg dGhlcmUgd2FzIGEgbmFtaW5nIGNvbnZlbnRpb24gZm9yIGNvbW1vbi8uDQpJ biB0aGUgZW5kIEkgd2VudCB3aXRoIHRoZSBlYXNpZXN0IHNvbHV0aW9uIDop DQoNClRoYW5rcyBmb3IgcmV2aWV3aW5nIQ0KDQoNCkFsYW4uDQoNCg== >From gdb-patches-return-145206-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Feb 01 13:36:18 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 23486 invoked by alias); 1 Feb 2018 13:36:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 23476 invoked by uid 89); 1 Feb 2018 13:36:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Feb 2018 13:36:12 +0000 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w11Da3EX026123 for ; Thu, 1 Feb 2018 08:36:10 -0500 Received: from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111]) by mx0a-001b2d01.pphosted.com with ESMTP id 2fv2vnb0ac-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 01 Feb 2018 08:36:09 -0500 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 1 Feb 2018 13:36:05 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp15.uk.ibm.com (192.168.101.145) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 1 Feb 2018 13:36:01 -0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w11Da1GN61079608; Thu, 1 Feb 2018 13:36:01 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5D50B42045; Thu, 1 Feb 2018 13:29:06 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 39AD64203F; Thu, 1 Feb 2018 13:29:06 +0000 (GMT) Received: from ThinkPad (unknown [9.152.212.63]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 1 Feb 2018 13:29:06 +0000 (GMT) Date: Thu, 01 Feb 2018 13:36:00 -0000 From: Philipp Rudo To: Alan Hayward Cc: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] Move arch/tdesc.h to common/common-tdesc.h In-Reply-To: <59984094-96C1-4D84-89F6-384769471005@arm.com> References: <97948063-b3db-fd3a-f62e-b552935cb8dd@arm.com> <20180201121443.43322674@ThinkPad> <59984094-96C1-4D84-89F6-384769471005@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 x-cbid: 18020113-0020-0000-0000-000003F145E6 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18020113-0021-0000-0000-00004283AF71 Message-Id: <20180201143600.39465e4e@ThinkPad> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-02-01_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1802010178 X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00009.txt.bz2 Content-length: 1657 On Thu, 1 Feb 2018 13:19:47 +0000 Alan Hayward wrote: > > On 1 Feb 2018, at 11:14, Philipp Rudo wrote: > >=20 > > Hi Alan, > >=20 > > the patch looks good to me. > >=20 > > If it were for me, I would drop the extra 'common-' and call the file > > just common/tdesc.h =E2=80=A6 > >=20 > > On Wed, 31 Jan 2018 13:40:04 +0000 > > Alan Hayward wrote: > >=20=20=20 > >> Following on from review comments for: > >> [PATCH v2 5/8] Use tdesc types in gdbserver tdesc > >>=20 > >> This patch simply moves arch/tdesc.h to common/tdesc.h.=20=20 > >=20 > > ... like stated here. But that's just my taste. When looking at the gi= t log in > > common/ I don't see any clear pattern for the current best practice in = naming > > the files. > >=20=20=20 >=20 > That results in common/tdesc.h and gdbserver/tdesc.h > That=E2=80=99s not a problem by itself, because we can just prefix the dir > name as part of the include. >=20 > My next set of patches will then add common/tdesc.c. > This is slightly more tricky because we now build two tdesc.o files. > The gdbserver IPA rules will need tweaking, and I=E2=80=99m not sure the = OBS > list will work as it is (given it doesn=E2=80=99t have any dir names). Argh, i didn't thought about this. You are right the OBS list looks like t= he perfect source for trouble... > Like you, I wasn=E2=80=99t sure if there was a naming convention for comm= on/. > In the end I went with the easiest solution :) Well in this case the easiest solution also is the best :) Thanks for working on this Philipp =20 > Thanks for reviewing! >=20 >=20 > Alan. >=20