From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200]) by sourceware.org (Postfix) with ESMTPS id E99E03857C46 for ; Tue, 8 Sep 2020 00:07:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E99E03857C46 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=netbsd.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kamil@netbsd.org Received: from [IPv6:::1] (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id 06DB284CCD; Tue, 8 Sep 2020 00:07:17 +0000 (UTC) Subject: Re: [PATCH v2 09/10] Switch local native code to gdb/nat shared functions To: Simon Marchi , gdb-patches@sourceware.org Cc: tom@tromey.com References: <20200904002905.13616-1-n54@gmx.com> <20200904002905.13616-10-n54@gmx.com> From: Kamil Rytarowski Autocrypt: addr=kamil@netbsd.org; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCNLYW1pbCBSeXRh cm93c2tpIDxrYW1pbEBOZXRCU0Qub3JnPokCOQQTAQgAIwUCVbKF6wIbIwcLCQgHAwIBBhUI AgkKCwQWAgMBAh4BAheAAAoJEEuzCOmwLnZsrgwQAMdXTXDWkxtUciFgBnioE6hvZYOBV7Xa Gh3dwgVvS5rLwwq5ob1R9qdtCGMYxdaCAQCzo2hhUfe9ts11/Q4Pg0aDAb5CfdVVTmyvLMu+ gtK99t/sG4SfCdn8Bb8rCfRRDpkTq1cAGy6pp7rxyMrFBITTbdBWVcWdEdlMhEZtV8Z1BNDI kwEwZkYnM1UxOGW4rJNjNU+hBjNAscCTwBSbpG6NV1oBbgmgJ1PfaPCeAmGTLZyI57VLuFJy kR0Jlj8Ui7dAaJgO1WYdmvL+48s0N2QGEoHnrf50xoO34LlrIBUsCLmhtjWhZiuj0meCxNTr 5YpdBP13b2i64OCruH8/M4IO85GAIWxIMMv510rge9qSe38NHCzSmn9zcjFwVXIh9flZi7PK eqOP3yah6r1ZIBY68If/2FtvwDptUi1NHoSpN+dt0kRg26hDqMFOg+Jc6o7Wtm+3vFNDhU4I 8HkjDr62VlbHBxe6gDgVELcecWgXOydKgdrQhOPwCBJkPJigifsIz4EZQnyI3CchFja3qR9J Vo4iXwqAi6xN4RD0PS775JYDh56qUaaUsEctQ/D6Xm7Bbdv1VPlsYs/9uXxc/jWVhkd1sDn2 KZ3kv7uo04DoejVGWK9B4XEZ1ufRPzmlV0SYohX34ouLBq5Q6wbyw6+hUM+yM9RcvgkOCVgB laejuQINBFVwUF8BEAC61vNvzAAcYvkU89YoStDcGyun1ENNWpHOnuQEw613/Xgys6xZbKKa Xhee8Fiwm6FlaiYWh66Vw5cA+hMna9PDp6tZi106JnKZ9DcYxanHOCQ5V42OwUX0BDfwUIwq YgOz12Cf4pdIheVkDfiSEot3XrdI3lT8od9iWeehx5zfW77utVrWGUXkMFJKmiKzxyzjV+gF gLk2wH+L7KoYiV/MfLukLa7mTJAK4mi0sfjLStPlf5gELvPtyooKG0gs0MbDSG2qmzb1/A4Y ET8Vaa7wJulIePym+Du5TJBwptls0KEF9a04kp2Oc2zlUd/Z5z3lLBiZaXpfProbz3Ydjg4O 2+XTn+SHSq10l3agjiAkGwHH83Xnzn/clg3iTvwYgdOcwvfEnJ1FGz3DAzcBd/+IMaszJjuo dBVckt07mc97sseDjy+vIIyQGdMzDmI0U9UK7nDUFpnIfG5LYe+myBS1CgFrZAQ/WNg0j7aq CiIgbhVAOFi2sPRYlph2L8LZRUPFHLTt23vdJXdFDuKM6JSvPiDf914UpjXr/WSwT43lJzlO O3zgKGM7eclFsetDF3p0I4SVHvR7dHbIC5IHibssmk7bQgH0K1aGUX/QC18v3VY7wYYaotYH RnTiGbBGz+XxPhZYiXKQuyFu6dY3qOw/VjbsV6KVNn49z2Zg4RQV8QARAQABiQIfBBgBCAAJ BQJVcFBfAhsMAAoJEEuzCOmwLnZs9rIP/2MTyZ0252u51LFsMHa9/ylTyvl+UKq8iR852lkZ X9bH9nH4cUcen5vZo0EZI3IVOemHUq71u+DTq8PSj5vtJ0DW+sGBEbjW3Q4IjJ+96PPrlemK fYS0KWVwEzzNQLEejjduU43x83DvQ/URzSWgGnhMBqXUyJdsHyTFFNFwQ9U71gX00+wXHJyh aXRlK+7gRKtCWuNFtW/5bQXL9epxDAS0POIVAdBc1FtPLwg08Pj0KwHsGQpEr5/W8ybDtLF+ zISHIKCj1lZ8dv/7D1PmH5SEXzsv+bbzvPtb6zhoIA8HONshaG2eAYknAiCJZ0gj0npgktwc u9VkvDvHMD9+VyNzRV/M6Ak4nDeEG6QecTPv8IqCcAHDI27nY/49BvFVOJOMwqbTp5Xvfa71 ksP1mARrN+bIYMfOy7OhfCxGeZydvBhgCLKdL698aXmgy0xrmrOw+GXO69GVcebOvxWMXxz1 FOG/JnLIe1ZgCo2YF5wy8zTCGKCMx6gAwnku2nJmDGNsePVedV00FmB8mQ7Oxz+3B9+LtFim FHHR33PlRnViXlG+XTm9NontiGE0LvG4TzIY5CYNSw8PBao795dQMSsmMI4FHlvTIgupE9g1 PQWP+2H2C0RtnLUanRNUGRkze1+MNG7jc+fqJIo5s7+PSs26rUvA38QzEOJ95k7hdJty Message-ID: <597b2615-fc81-3bfc-aa46-8d364bb6be5f@netbsd.org> Date: Tue, 8 Sep 2020 02:04:27 +0200 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JGcQsuV01dl3fit8JL85RQXRMo2p81tP7" X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Sep 2020 00:07:21 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JGcQsuV01dl3fit8JL85RQXRMo2p81tP7 Content-Type: multipart/mixed; boundary="0CmabE9a3VUOJxR9mFf0bssap3OTlpjyC"; protected-headers="v1" From: Kamil Rytarowski To: Simon Marchi , gdb-patches@sourceware.org Cc: tom@tromey.com Message-ID: <597b2615-fc81-3bfc-aa46-8d364bb6be5f@netbsd.org> Subject: Re: [PATCH v2 09/10] Switch local native code to gdb/nat shared functions References: <20200904002905.13616-1-n54@gmx.com> <20200904002905.13616-10-n54@gmx.com> In-Reply-To: --0CmabE9a3VUOJxR9mFf0bssap3OTlpjyC Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 07.09.2020 21:24, Simon Marchi wrote: > On 2020-09-03 8:29 p.m., Kamil Rytarowski wrote: >> No functional change as the same functionality inlined in nbsd-nat.c >> is offered in gdb/nat/netbsd-nat.c. >> >> gdb/ChangeLog: >> >> * nbsd-nat.c: Include "nat/netbsd-nat.h". >> * (nbsd_nat_target::pid_to_exec_file) >> (nbsd_nat_target::thread_alive, nbsd_nat_target::thread_name) >> (nbsd_nat_target::post_startup_inferior) >> (nbsd_nat_target::post_attach, nbsd_nat_target::xfer_partial) >> (nbsd_add_threads): Switch local code to common gdb/nat functions. >> * (nbsd_pid_to_cmdline): Call sysctl from the global namespace. >> * (nbsd_thread_lister): Remove. >=20 > Just a though for next time: I think you could have done the changes he= re > progressively. For example, move netbsd_thread_lister to nat, adjust t= he > code here at the same time. Move the thread_alive function, adjust the= > code here, etc. It would have been easier to see that it was mostly ju= st > functionality moved from one place to the other, up to this patch I tho= ught > it was all new code. >=20 OK. > Simon >=20 --0CmabE9a3VUOJxR9mFf0bssap3OTlpjyC-- --JGcQsuV01dl3fit8JL85RQXRMo2p81tP7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAl9WyowACgkQS7MI6bAu dmzNpBAAoXSc+GMyTdwCmC9+vJyWhDxj+M7Dr4+Syr900bk/+o2ZFhxPA2zRBLaK N30fGgtdTK+tgChB0hDKilBlC19G+7Dm6SRL0fApGDjrjdp9gql3o4wXtfUyW69m fSSm7njioC8lDmszadvsB4LYobu2nrHj6YnCkjkUfqzaklW7eACwapuekTCL7FFg yG0T1bDz1uzPIuJUq7VesXbAkXCkqIUKWXFP+Q3yFp/g3E4zmSshxeHEadcw3h8w gixi3cynkRyFGcg3Hn7vcZIDsYFYgy4d+bNkajSYhZDCMCS3ws6YiFcZZdu6lcRJ n3lSWQ8xU79CDQr+Tehpged8r7BZt4Yxl4A7dEyno3cvkA3xZWry6+CtvCxdWq4S j5HBxUTiTmlt4p4BpwkaDlF2rkqZ/R3B/dzD5C2MVzl+u2D/m9PSzItHxkihvtIW SejMWUWQF+afVf6v9klp1MnJrxXMUW1YLSZRyxnEKGDvMWD1q/5U7kJ/YTsQEgWa XW6xLX17DClGyx05ezhLhOIkWB12IY6KgpSrEJb9cu1hMXTCHX05zygA5sVn8Ffr GNSXf3lNkZt8XWlPoMMCDTJ37PEodr0nSJoGMGl9PJkLML8OsM/44CxiDe1OjsVH h25vZyYhS8+bcEwGxa6EyBRvmqInBKNOWBPo6UnAG+N48ptyle4= =E/rK -----END PGP SIGNATURE----- --JGcQsuV01dl3fit8JL85RQXRMo2p81tP7--