From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127088 invoked by alias); 17 Jul 2017 19:02:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127066 invoked by uid 89); 17 Jul 2017 19:02:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=overwhelming, perfect X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Jul 2017 19:02:18 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7E204356E4 for ; Mon, 17 Jul 2017 19:02:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7E204356E4 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=keiths@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7E204356E4 Received: from valrhona.uglyboxes.com (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 43B7860F8A; Mon, 17 Jul 2017 19:02:17 +0000 (UTC) Subject: Re: [PATCH 18/40] A smarter linespec completer To: Pedro Alves , gdb-patches@sourceware.org References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-19-git-send-email-palves@redhat.com> <59695CC2.2090206@redhat.com> From: Keith Seitz Message-ID: <596D09B8.2010506@redhat.com> Date: Mon, 17 Jul 2017 19:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00229.txt.bz2 On 07/17/2017 11:21 AM, Pedro Alves wrote: >> >>> + int completion_quote_char; >> >> Why int? > > Mainly because the related readline code uses int too. Well, that's definitely a good reason! That's all I really wanted to know. > I can make this a char, and for consistency try to make completer_tracker > use char too, though I'd prefer to do that as a patch on top of this one > that touches every path in a single go, than update the few related > completer_tracker patches, mainly because gdb_rl_find_completion_word > is already in master. Would you mind that? It's up to you, really. IMO, I don't see any overwhelming reason to change this. In fact, a good case could be made for not changing it (now that I know what said reason is). > Here are the comments that I came up with. WDYT? Perfect! Thanks! Keith