From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47406 invoked by alias); 13 Jul 2017 20:28:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45187 invoked by uid 89); 13 Jul 2017 20:28:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*UA:38.1.0, H*u:38.1.0 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Jul 2017 20:28:25 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C6A0864A73 for ; Thu, 13 Jul 2017 20:28:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C6A0864A73 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=keiths@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C6A0864A73 Received: from valrhona.uglyboxes.com (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8F6845C7D7; Thu, 13 Jul 2017 20:28:23 +0000 (UTC) Subject: Re: [PATCH 03/40] Fix gdb.base/completion.exp with --target_board=dwarf4-gdb-index To: Pedro Alves , gdb-patches@sourceware.org References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-4-git-send-email-palves@redhat.com> From: Keith Seitz Message-ID: <5967D7E5.8000009@redhat.com> Date: Thu, 13 Jul 2017 20:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1496406158-12663-4-git-send-email-palves@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00168.txt.bz2 I've looked over this patch, and it looks fine to me. One little request: On 06/02/2017 05:22 AM, Pedro Alves wrote: > diff --git a/gdb/symtab.c b/gdb/symtab.c > index 22d81fa..69f3bc2 100644 > --- a/gdb/symtab.c > +++ b/gdb/symtab.c > @@ -5385,7 +5385,6 @@ static VEC (char_ptr) * > make_file_symbol_completion_list_1 (const char *text, const char *word, > const char *srcfile) > { > - struct symtab *s; > /* The symbol we are completing on. Points in same buffer as text. */ > const char *sym_text; > /* Length of sym_text. */ The comment for this function is (and also later when it is renamed to collect_file_symbol_completion_matches) /* Like collect_symbol_completion_matches, but collects a list of symbols defined in a source file FILE. */ ^^^^^^^^^^^^^^^^^^^^ I think that underlined bit should be updated to be a bit clearer. While it is pedantically correct, I think "in all source files named FILE" tells the reader of other important behavior/intent. Keith