Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Mark Wielaard <mark@klomp.org>, Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove stale "register" bits from gdb.cp/misc.cc (Re: [PATCH] Move "register" test out of classes.exp to a separate testcase)
Date: Sat, 22 Aug 2020 15:01:06 -0400	[thread overview]
Message-ID: <593b26e2-c765-3485-e028-21f2cf7db140@simark.ca> (raw)
In-Reply-To: <20200822185304.GA3854@wildebeest.org>

On 2020-08-22 2:53 p.m., Mark Wielaard wrote:
> On Sat, Aug 22, 2020 at 06:11:49PM +0100, Pedro Alves wrote:
>> On 8/22/20 6:08 PM, Pedro Alves wrote:
>>
>>> See patch below.  I propose we push this in instead.
>>
>> And then this on top.
> 
> I cannot claim to fully understand the patches, but they work on my
> setup, classes, misc and inherit all compile and PASS all tests (misc
> does have one duplicate "pointer addition with integer reference").
> 
> Cheers,
> 
> Mark
> 

Thanks, that LGTM.

Simon


  reply	other threads:[~2020-08-22 19:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-22 12:19 [PATCH] gdb/testsuite: ISO C++17 does not allow register storage class specifier Mark Wielaard
2020-08-22 14:54 ` Simon Marchi
2020-08-22 17:08   ` [PATCH] Move "register" test out of classes.exp to a separate testcase (Re: [PATCH] gdb/testsuite: ISO C++17 does not allow register storage class specifier.) Pedro Alves
2020-08-22 17:11     ` [PATCH] Remove stale "register" bits from gdb.cp/misc.cc (Re: [PATCH] Move "register" test out of classes.exp to a separate testcase) Pedro Alves
2020-08-22 18:53       ` Mark Wielaard
2020-08-22 19:01         ` Simon Marchi [this message]
2020-08-22 19:01           ` Simon Marchi
2020-09-13 16:40         ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=593b26e2-c765-3485-e028-21f2cf7db140@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=mark@klomp.org \
    --cc=pedro@palves.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox