From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by sourceware.org (Postfix) with ESMTPS id 577C23857032 for ; Wed, 22 Jul 2020 18:24:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 577C23857032 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wm1-f66.google.com with SMTP id 184so2913019wmb.0 for ; Wed, 22 Jul 2020 11:24:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8XQAM9gaAu7/EISQctz0YjKqVjCa/QEuDGzwTeb7w8o=; b=DNYUHVJ8yTn6VOr6rmbjLc4HV2vlGQ4XEcFQV2cm1w7E3haohU6K4fT0QIItrx8peI 1PUHgIi06xRrakhD4QY2kH6VVZ/D6XHwuFazLEygBABc5IcXeLYK1URsNXta53QUHvit uIRD+rNu4GpJO9IT3Ti1efHIDQ7vGRzWvrM9uini3C6Gs9sEBG0P0vP14RBvPWCi3abF 1YSBvmd72rZaehFW960Ff4zr/NfJfnGwmQ20Re3otu3cCXw3sD9efwGZa+D+30R5+Vf0 rF/JaFuYv2BzISVY4NmnBo1CmKvwZO/hqFzYlXsKkRbe2O6Zz8YzIzVKqjtp0qupwNma NI7A== X-Gm-Message-State: AOAM5314FPJm5SIvEa35Dxno/4oLXwPW3DiUjztCh9SQb93V3dw1mvHe T0WFejFSEYYo825ZcGa+Vq2I2hRC6c0= X-Google-Smtp-Source: ABdhPJyt/O7tm7jEggKij6Q2QW/DRS7sRo7vsMrtTAIRed43wsG+TA2zC1kxRwdZLJETWcxjmFtpZA== X-Received: by 2002:a1c:2d89:: with SMTP id t131mr800009wmt.151.1595442245938; Wed, 22 Jul 2020 11:24:05 -0700 (PDT) Received: from ?IPv6:2001:8a0:f91a:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f91a:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id 32sm883933wrn.86.2020.07.22.11.24.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jul 2020 11:24:04 -0700 (PDT) Subject: Re: [PATCH 0/3] Prevent bad conditions from putting breakpoints into broken state To: Tankut Baris Aktemur , gdb-patches@sourceware.org References: <1595322511-23245-1-git-send-email-tankut.baris.aktemur@intel.com> From: Pedro Alves Message-ID: <58ba7b97-03e9-4886-d502-0a5e4f82e501@palves.net> Date: Wed, 22 Jul 2020 19:24:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <1595322511-23245-1-git-send-email-tankut.baris.aktemur@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2020 18:24:09 -0000 On 7/21/20 10:08 AM, Tankut Baris Aktemur via Gdb-patches wrote: >> Hi, >> >> If the condition of a breakpoint is "bad" (e.g. has unresolved >> symbols, syntax errors, etc.), the breakpoint goes into a broken state >> where the condition string or the condition expressions are updated >> inadvertently. This small series attempts to fix that. > > > Kindly pinging for > > https://sourceware.org/pipermail/gdb-patches/2020-June/169954.html I'm confused -- are you proposing to merge patch #2 as it was, or with the two passes?