Re: [PATCH] Improve gdb_tilde_expand logic

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2021-01-08 4:30 a.m., Andrew Burgess wrote:
> There's only very limited unit testing within GDB.  You should write a
> test in gdb/testsuite/.... that triggers this behaviour and check the
> functionality that way.

It might be difficult to write a .exp test that specifically targets this
function... I think a selftest for this could be useful (in addition to
something in a .exp file, if this ends up used for the index-cache
directory, as discussed).

The selftest could just call gdb_tilde_expand with
"~/a/non/existent/directory" and make some simple assertions with the
result.  That selftest could probably be written directly in
gdbsupport/gdb_tilde_expand.cc.  That would be the first time a
selftest is put in a gdbsupport file, but I don't think that will
cause a problem.  That test will be available in both GDB and GDBserver.

You can check the test for gdb_realpath in gdb/utils.c if you want
an example.

Simon