From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107714 invoked by alias); 29 Mar 2017 16:38:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107608 invoked by uid 89); 29 Mar 2017 16:38:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=H*Ad:D*oracle.com X-Spam-User: qpsmtpd, 2 recipients X-HELO: userp1040.oracle.com Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Mar 2017 16:38:17 +0000 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v2TGcETb010964 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Mar 2017 16:38:14 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v2TGcDqa020839 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Wed, 29 Mar 2017 16:38:14 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id v2TGcBFb029277; Wed, 29 Mar 2017 16:38:12 GMT Received: from [10.133.144.218] (/10.133.144.218) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 29 Mar 2017 09:38:11 -0700 Reply-To: vladimir.mezentsev@oracle.com Subject: Re: [PATCH] gdb passes and returns incorrect values when dealing with small array on Sparc References: <1490721669-12560-1-git-send-email-vladimir.mezentsev@oracle.com> <5a3397ae-e986-8a36-13ba-ed2cfeb68a12@redhat.com> To: Pedro Alves , binutils@sourceware.org, gdb-patches@sourceware.org From: Vladimir Mezentsev Message-ID: <58DBE2F2.4080504@oracle.com> Date: Wed, 29 Mar 2017 16:38:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5a3397ae-e986-8a36-13ba-ed2cfeb68a12@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-03/txt/msg00510.txt.bz2 On 03/29/2017 02:56 AM, Pedro Alves wrote: > Hi Vladimir, > > gdb development happens on a separate list - gdb-patches@. Please resend > the patch there. TIA! Done. > > A question I'll have is whether this had any observable effect in testsuite > results, other than "no regressions". I.e., whether there were progressions, > or whether we're missing testsuite coverage. 6 tests ( from gdb/testsuite/gdb.base/gnu_vector.exp) failed on sparc64-Linux and on sparc-Solaris in 32- and 64-bit mode. Now all these tests passed. gdb/testsuite/gdb.base/gnu_vector.exp has 117 different cases for small (and not small) arrays and structures. I think we don't need an additional test in gdb/testsuite. -Vladimir > > On 03/28/2017 06:21 PM, vladimir.mezentsev@oracle.com wrote: >> From: Vladimir Mezentsev >> >> gdb has a special type (TYPE_CODE_ARRAY) to support the gcc extension >> (https://gcc.gnu.org/onlinedocs/gcc/Vector-Extensions.html). >> TYPE_CODE_ARRAY is handled incorrectly for both (32- and 64-bit) modes on Sparc machines. >> >> Tested on sparc64-linux-gnu and sparc-solaris (32- and 64-bit mode). >> No regressions. >> >> 2017-03-27 Vladimir Mezentsev >> >> * gdb/sparc-tdep.c (sparc_structure_return_p): New function. > Also, please drop "gdb/" here. Filename entries in ChangeLogs > are relative to the ChangeLog file path. > > Thanks, > Pedro Alves >