On 03/13/2017 11:52 AM, Pedro Alves wrote:
> 
> Typo, "ravlue".
> 

All corrected.

>> +set line [gdb_get_line_number {rvalue-ref-casts.exp: 1}]
>> +gdb_test "break $line" "Breakpoint.*at.* file .*$srcfile, line $line\\."
> 
> Please add an explicit test message in order to avoid it changing
> if/when $line changes.

Fixed.

> Is there a special reason for using concat here?  I'd think a
> continuation would do:
> 
> 	"let compiler cast base class rvalue reference to derived\
> 	 class rvalue reference"
> 
> TCL replaces continuation+newline+spaces/tabs with a single whitespace:
>  http://www.tcl.tk/man/tcl8.5/TclCmd/Tcl.htm#M24
> 

Ha. I'm such an old dog! [And learned/was reminded of a new trick...] Fixed.

>> +
>> +#
>> +# test running programs
>> +#

I've removed the above comment from all the rvalue-*.exp tests. They
don't actually serve to clarify anything anyway.

>> +proc gdb_start_again {text} {
>> +    global binfile
>> +    global srcfile
>> +
>> +    clean_restart $binfile
>> +
>> +    runto ${srcfile}:[gdb_get_line_number $text]
> 
> Should probably be wrapped with with_test_prefix to avoid
> duplicate messages from within clean_restart / runto,
> in case they fail.

Fixed.

>> +  short (&&rrat)[4] = std::move( at);
>> +
>> +    marker1();
>> +
>> +    main2();
>> +
>> +    return 0;
> 
> Indentation of these 3 statements above is odd.
> 

Yup. Fixed.

> 
> Same comment about with_test_prefix.  Actually, can we just
> remove the "eof" handling below making this procedure
> unnecessary?  (I know this is copied from the other file.)
> 

Indeed. I've replaced the gdb_test_multiple with the simpler gdb_test
and removed the gdb_start_again procedure.

Revision attached.

Keith