From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58159 invoked by alias); 28 Feb 2017 19:37:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58137 invoked by uid 89); 28 Feb 2017 19:37:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=assess, Insight, daily X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Feb 2017 19:37:42 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2538281245 for ; Tue, 28 Feb 2017 19:37:43 +0000 (UTC) Received: from valrhona.uglyboxes.com (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1SJbgOZ009226 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 28 Feb 2017 14:37:42 -0500 Subject: Re: [PATCH 00/11] Cleanup deprecated_*_hooks in defs.h To: gdb-patches@sourceware.org References: <20170228145016.22604-1-prudo@linux.vnet.ibm.com> From: Keith Seitz Message-ID: <58B5D185.80703@redhat.com> Date: Tue, 28 Feb 2017 19:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20170228145016.22604-1-prudo@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00730.txt.bz2 On 02/28/2017 06:50 AM, Philipp Rudo wrote: > this series cleans up several hooks in defs.h which were deprecated in 2004 > (9a4105ab). Most of these hooks are no longer used and can be removed without > problem. As Tom and Simon have already mentioned, Insight still uses many (all?) of these. [Don't laugh -- I still use Insight almost daily. I know, too, that I am not alone.] However, I don't think this patch should be dismissed solely because Insight still uses them. [Insight was "kicked out" of the official GDB repository several years ago.] Instead, I would like to ask maintainers to consider that the "true" deprecation of these hooks be phased in over a release or three to give time to either replace them or assess how much time may be needed to properly replace these hooks. Keith For the record, hooks currently used by Insight: deprecated_ui_loop_hook deprecated_call_command_hook deprecated_readline_begin_hook deprecated_readline_hook deprecated_readline_end_hook deprecated_print_frame_info_listing_hook deprecated_query_hook deprecated_warning_hook deprecated_interactive_hook deprecated_target_wait_hook deprecated_ui_load_progress_hook deprecated_ui_loop_hook deprecated_pre_add_symbol_hook deprecated_post_add_symbol_hook deprecated_file_changed_hook deprecated_attach_hook deprecated_detach_hook deprecated_context_hook deprecated_error_begin_hook deprecated_annotate_signal_hook deprecated_annotate_signalled_hook deprecated_warning_hook