From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121231 invoked by alias); 1 Feb 2017 12:34:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119500 invoked by uid 89); 1 Feb 2017 12:34:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,MIME_BASE64_BLANKS,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:ip*10.253.24.26, H*RU:HELO, Hx-spam-relays-external:HELO, H*r:sk:orsmga1 X-HELO: mga02.intel.com Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 01 Feb 2017 12:34:00 +0000 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP; 01 Feb 2017 04:33:58 -0800 X-ExtLoop1: 1 Received: from msturm-mobl2.ger.corp.intel.com (HELO [172.28.205.45]) ([172.28.205.45]) by fmsmga002.fm.intel.com with ESMTP; 01 Feb 2017 04:33:57 -0800 Subject: Re: [PATCH v3 5/5] Add support for Intel PKRU register to GDB and GDBserver. To: Pedro Alves , mark.kettenis@xs4all.nl, eliz@gnu.org References: <1481021894-29471-1-git-send-email-michael.sturm@intel.com> <1481021894-29471-6-git-send-email-michael.sturm@intel.com> <588B607A.9040507@intel.com> <8efd1e4f-47f9-8fe6-6db9-b6824970d91d@redhat.com> Cc: gdb-patches@sourceware.org From: "Sturm, Michael" Message-ID: <5891D5B4.3090206@intel.com> Date: Wed, 01 Feb 2017 12:34:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <8efd1e4f-47f9-8fe6-6db9-b6824970d91d@redhat.com> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: base64 X-SW-Source: 2017-02/txt/msg00017.txt.bz2 CgpPbiAyNy8wMS8yMDE3IDE2OjIyLCBQZWRybyBBbHZlcyB3cm90ZToKPiBP biAwMS8yNy8yMDE3IDAzOjAwIFBNLCBTdHVybSwgTWljaGFlbCB3cm90ZToK Pgo+Pj4gSW4gdGhlIHRlc3Q6Cj4+Pgo+Pj4+ICsjaW5jbHVkZSA8c3RkaW8u aD4KPj4+IFRoaXMgaXMgbm90IG5lZWRlZCwgcmlnaHQ/Cj4+IEl0J3MgbmVl ZGVkIHRvIHB1bGwgaW4gdGhlIGRlZmluaXRpb24gZm9yIE5VTEwgd2hpY2gg aXMgdXNlZCBpbiB0aGUgY2FsbAo+PiB0byBfX2dldF9jcHVpZF8KPiBBaC4g IENvdWxkIHlvdSBpbmNsdWRlIHN0ZGRlZi5oIGluc3RlYWQ/ICBXZSBhdm9p ZCB1c2luZyBzdGRpbyBpbiB0ZXN0cwo+IHVubGVzcyByZXF1aXJlZCBmb3Ig dGhlIHNwZWNpZmljcyBvZiB0aGUgdGVzdCwgaW4gb3JkZXIgdG8gYmUgYWJs ZSB0byBydW4KPiBhcyBtb3N0IHRlc3RzIGFzIHBvc3NpYmxlIGFnYWluc3Qg cmVtb3RlIHRhcmdldHMgdGhhdCBkb24ndCBzdXBwb3J0Cj4gcmVtb3RlIEkv TyAod2hpY2ggYXJlIG1vc3QsIHRob3VnaCB0aGUgbG9jYWwgZ2Ric2VydmVy IHRlc3RpbmcgYm9hcmRzIG5vd2FkYXlzCj4gd29yayBhcm91bmQgaXQpLiAg SnVzdCAjaW5jbHVkaW5nIDxzdGRpby5oPiB3aXRob3V0IHJlbHlpbmcgb24g cHJpbnRmIGV0Yy4gaXRzZWxmCj4gaXMgcHJvYmFibHkgbm90IHJlYWxseSBw cm9ibGVtYXRpYyBhbnl3aGVyZSwgYnV0IGl0J3MgYSBnb29kIHByb3h5Cj4g Zm9yIGlkZW50aWZ5aW5nIHRlc3RzIHRoYXQgd291bGRuJ3Qvc2hvdWxkbid0 IHdvcmsgaW4gc3VjaCB0YXJnZXRzLgo+Cj4gVGhhbmtzLAo+IFBlZHJvIEFs dmVzCj4KWWVzLCB3aWxsIGRvLiBWNCBvZiB0aGUgc2VyaWVzIHdpdGggY29t bWVudHMgYWRkcmVzc2VkIGFuZCByZWJhc2VkIHdpbGwgCmJlIGNvbWluZyBz b29uLgoKVGhhbmtzIGFuZCBSZWdhcmRzLApNaWNoYWVsCgpJbnRlbCBEZXV0 c2NobGFuZCBHbWJIClJlZ2lzdGVyZWQgQWRkcmVzczogQW0gQ2FtcGVvbiAx MC0xMiwgODU1NzkgTmV1YmliZXJnLCBHZXJtYW55ClRlbDogKzQ5IDg5IDk5 IDg4NTMtMCwgd3d3LmludGVsLmRlCk1hbmFnaW5nIERpcmVjdG9yczogQ2hy aXN0aW4gRWlzZW5zY2htaWQsIENocmlzdGlhbiBMYW1wcmVjaHRlcgpDaGFp cnBlcnNvbiBvZiB0aGUgU3VwZXJ2aXNvcnkgQm9hcmQ6IE5pY29sZSBMYXUK UmVnaXN0ZXJlZCBPZmZpY2U6IE11bmljaApDb21tZXJjaWFsIFJlZ2lzdGVy OiBBbXRzZ2VyaWNodCBNdWVuY2hlbiBIUkIgMTg2OTI4Cg== >From gdb-patches-return-136641-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Feb 01 12:42:42 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 41410 invoked by alias); 1 Feb 2017 12:42:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 41395 invoked by uid 89); 1 Feb 2017 12:42:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=trimmed, H*f:sk:38210a5, H*i:sk:38210a5, H*MI:sk:38210a5 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 01 Feb 2017 12:42:39 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cYuFB-0001F7-Lt from Luis_Gustavo@mentor.com ; Wed, 01 Feb 2017 04:42:37 -0800 Received: from [172.30.10.1] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Wed, 1 Feb 2017 04:42:34 -0800 Reply-To: Luis Machado Subject: Re: [PATCH 1/2] Add rdrand/rdseed record/replay tests References: <1485451129-16439-1-git-send-email-lgustavo@codesourcery.com> <38210a5e-14b5-23f6-456c-1ec1b900caf5@redhat.com> To: Pedro Alves , From: Luis Machado Message-ID: Date: Wed, 01 Feb 2017 12:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <38210a5e-14b5-23f6-456c-1ec1b900caf5@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-02.mgc.mentorg.com (147.34.90.202) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00018.txt.bz2 Content-length: 610 On 02/01/2017 05:09 AM, Pedro Alves wrote: > On 01/26/2017 05:18 PM, Luis Machado wrote: > >> +/* Fetches information from cpuid and sets flags indicating supported >> + features. */ > > What flags? > This is stale. The function should actually be called check_rdrand_support, so that's what it does. In my previous design it checked for a number of features, but i've trimmed it down. >> + >> +static unsigned int >> +check_cpu_support (void) >> +{ >> + unsigned int rdrand_mask = (1 << 30); >> + unsigned int eax, ebx, ecx, edx; >> + >> + __get_cpuid(1, &eax, &ebx, &ecx, &edx); > Fixed locally.