Re: [PATCH v3 1/5] Sync up x86-gcc-cpuid.h with cpuid.h from gcc-6 branch.

Sturm, Michael
2016-12-08T12:16:48Z

Hello Luis,

there are two comment sections at the beginning of this file. I've
updated the gcc version in the first one. The second one
is the copyright notice. It is unchanged from what is in mainline, which
I think is how it should be.
In the diff, there is only the opening /* as context at the end of the
first hunk.

So I think the patch is good to go...please let me know if you're after
something else.

Thanks and Regards,
Michael

On 07/12/2016 19:28, Luis Machado wrote:
> On 12/06/2016 04:58 AM, Michael Sturm wrote:
>> Pedro suggested a separate patch synching with GCCs cpuid.h
>> instead of just adding new bits for PKU feature.
>>
>> gdb/Changelog:
>> 2016-11-14 Michael Sturm <michael.sturm@intel.com>
>>
>> * nat/x86-gcc-cpuid.h: Replace with copy of cpuid.h
>> from gcc-6 branch.
>>
>> Change-Id: I16f8f7f2d0aa7c2e815701d15ed831a6c6b33d21
>> Signed-off-by: Michael Sturm <michael.sturm@intel.com>
>> ---
>> gdb/nat/x86-gcc-cpuid.h | 108
>> ++++++++++++++++++++++--------------------------
>> 1 file changed, 50 insertions(+), 58 deletions(-)
>>
>> diff --git a/gdb/nat/x86-gcc-cpuid.h b/gdb/nat/x86-gcc-cpuid.h
>> index 1045521..5969b88 100644
>> --- a/gdb/nat/x86-gcc-cpuid.h
>> +++ b/gdb/nat/x86-gcc-cpuid.h
>> @@ -1,5 +1,5 @@
>> /*
>> - * Helper cpuid.h file copied from gcc-4.8.0. Code in gdb should not
>> + * Helper cpuid.h file copied from gcc-6.0.0. Code in gdb should not
>> * include this directly, but pull in x86-cpuid.h and use that func.
>> */
>
> Copyright notice is still missing.

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928