From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 0DD31388A816 for ; Mon, 18 May 2020 14:13:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0DD31388A816 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-146-Uio_gOQXO4al1li_HmMLag-1; Mon, 18 May 2020 10:13:47 -0400 X-MC-Unique: Uio_gOQXO4al1li_HmMLag-1 Received: by mail-wm1-f72.google.com with SMTP id l26so3152674wmh.3 for ; Mon, 18 May 2020 07:13:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=n4Ld/Nm4Oo4SBgoSgWOz56sYb21beCJ4Ql7Ur7Jp2O8=; b=UpXdRj4+L9JF0omFu0zcCeNyD006/wiBTz2QvivnkDX2KlO/mxzIYVi8hgVchZ4sgi AExaJ2amGj9cHav+lRrzm8WG8lrT+VTZS+uBvNvkER/xH2jsC//qq8fwH4ZN+2sALmRr ABMfrF7t+rBtlP5mtKi39GX7fy4ihOacCmnqc3H2SyF5wszNOCHWGeAikueXewqRg7gK FKUEYUmWw7IbE7VnsxbiO1TnuHNkMD4C7d92vYPJHltHgqnJOXW2P+iMC5nA4yZDWvjG ZV9FjQd77kwcsMR/grRG3RohhEefgNOYt5g6buOytmYeQCe97dX2jJ1uWEwxlgOpiW4m YDkQ== X-Gm-Message-State: AOAM532/Nqu6IyBQ3xDXkfIPqDKQjvzij/UCkjkfl2n/GmQQT+/Nzjcg nQJNLYA+/ya7A+dmGbX2B8ldlkLICXEIcWu0fDUSbTDB4DIYSt105R0MzOomstyPw3swEy9Znav Edur5QdHU0jNj4pfjhWwifw== X-Received: by 2002:a7b:c394:: with SMTP id s20mr20627718wmj.40.1589811226301; Mon, 18 May 2020 07:13:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxc3dIHtTRZBEfGNjhM8T5ciR+qBMSKqwkrqxh32TQ0Ns5crpGvmVsany3VVao/d9UuUfRCsw== X-Received: by 2002:a7b:c394:: with SMTP id s20mr20627699wmj.40.1589811226058; Mon, 18 May 2020 07:13:46 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id q144sm17563211wme.0.2020.05.18.07.13.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2020 07:13:45 -0700 (PDT) Subject: Re: [committed][gdb/testsuite] Split up multi-exec test-cases To: Tom de Vries , gdb-patches@sourceware.org References: <20200514152530.GA19399@delia> <456ce125-df9d-6ca7-d08d-9dae83aaed10@redhat.com> From: Pedro Alves Message-ID: <58835fcd-a7b6-aa0a-4155-7aab4a0e6fd0@redhat.com> Date: Mon, 18 May 2020 15:13:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <456ce125-df9d-6ca7-d08d-9dae83aaed10@redhat.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 May 2020 14:13:53 -0000 On 5/14/20 6:04 PM, Pedro Alves via Gdb-patches wrote: > On 5/14/20 4:25 PM, Tom de Vries wrote: > No objection to the splitting, but the issue above should really be > fixed. It's a systematic issue, and requiring a file split to address it > seems like a heavy burden to me. Maybe we should disable exec-file-mismatch > detection from within gdb_target_cmd? At least, until we have buildid detection. > But that won't work on all hosts, either. Like, this fixes align.exp for me: > > diff --git c/gdb/testsuite/lib/gdbserver-support.exp w/gdb/testsuite/lib/gdbserver-support.exp > index a2cc80f28d7..fc79f1d60c6 100644 > --- c/gdb/testsuite/lib/gdbserver-support.exp > +++ w/gdb/testsuite/lib/gdbserver-support.exp > @@ -52,7 +52,7 @@ proc gdb_target_cmd_ext { targetname serialport {additional_text ""} } { > > set serialport_re [string_to_regexp $serialport] > for {set i 1} {$i <= 3} {incr i} { > - send_gdb "target $targetname $serialport\n" > + send_gdb "with exec-file-mismatch off -- target $targetname $serialport\n" > gdb_expect 60 { > -re "A program is being debugged already.*ill it.*y or n. $" { > send_gdb "y\n" To sort of close the loop here -- I no longer think that this a good approach. The exec-file-mismatch detection did actually find a bug in the testsuite: https://sourceware.org/pipermail/gdb-patches/2020-May/168680.html I'm now aiming at fixing this in GDB, by making GDB validate the exec file by comparing build IDs instead of filenames: https://sourceware.org/pipermail/gdb-patches/2020-May/168718.html Thanks, Pedro Alves