From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 387 invoked by alias); 21 Dec 2016 09:27:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 375 invoked by uid 89); 21 Dec 2016 09:27:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=BAYES_50,MIME_BASE64_BLANKS,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:10.253.24, nicole, Nicole, H*RU:HELO X-HELO: mga06.intel.com Received: from mga06.intel.com (HELO mga06.intel.com) (134.134.136.31) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Dec 2016 09:27:27 +0000 Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP; 21 Dec 2016 01:27:25 -0800 X-ExtLoop1: 1 Received: from heckel-mobl3.ger.corp.intel.com (HELO [172.28.205.41]) ([172.28.205.41]) by fmsmga006.fm.intel.com with ESMTP; 21 Dec 2016 01:27:24 -0800 Subject: Re: [PATCH V2 2/2] Prologue: Add selftests to x64/x32 architecture. To: Yao Qi References: <1481896716-1233-1-git-send-email-bernhard.heckel@intel.com> <1481896716-1233-3-git-send-email-bernhard.heckel@intel.com> <20161220092011.GB18061@E107787-LIN> Cc: gdb-patches@sourceware.org From: Bernhard Heckel Message-ID: <585A4AFB.6000201@intel.com> Date: Wed, 21 Dec 2016 09:27:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20161220092011.GB18061@E107787-LIN> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2016-12/txt/msg00369.txt.bz2 T24gMjAvMTIvMjAxNiAxMDoyMCwgWWFvIFFpIHdyb3RlOgo+IE9uIDE2LTEy LTE2IDE0OjU4OjM2LCBCZXJuaGFyZCBIZWNrZWwgd3JvdGU6Cj4+ICsKPj4g K2NsYXNzIGNvZGVfcmVhZGVyIDogcHVibGljIGFic3RyYWN0X2NvZGVfcmVh ZGVyCj4+ICt7Cj4+ICtwdWJsaWM6Cj4+ICsgIGNvZGVfcmVhZGVyICh2b2lk KQo+PiArICB7Cj4+ICsgICAgdGFyZ2V0X21lbW9yeSA9IDE7Cj4+ICsgIH0K Pj4gKwo+PiArICB2b2lkIHJlYWQgKENPUkVfQUREUiBtZW1hZGRyLCBnZGJf Ynl0ZSAqYnVmZmVyLCBzc2l6ZV90IGxlbikKPj4gKyAgewo+PiArICAgIHJl YWRfY29kZSAobWVtYWRkciwgYnVmZmVyLCBsZW4pOwo+IENhbiB3ZSB1c2Ug dGFyZ2V0X3JlYWRfY29kZSBoZXJlPyAgSXQgZG9lc24ndCB0aHJvdyBhbiBl cnJvciBpZiBpdAo+IGNhbid0IHJlYWQuICBNZXRob2QgJ3JlYWQnIGJlY29t ZXMKPgo+IGludCByZWFkIChDT1JFX0FERFIgbWVtYWRkciwgZ2RiX2J5dGUg KmJ1ZmZlciwgc3NpemVfdCBsZW4pCj4KPiBzbyB0aGF0IHdlIG1heSBldmVu IHNoYXJlIG1vcmUgY29kZSB3aXRoIGRpc2Fzc2VtYmx5LiAgU2VlIFBlZHJv J3MKPiBQT0MgcGF0Y2guCj4KQ2FuIHlvdSBwb2ludCBtZSB0byB0aGUgUGVk cm8ncyBwYXRjaD8KCgpJbnRlbCBEZXV0c2NobGFuZCBHbWJIClJlZ2lzdGVy ZWQgQWRkcmVzczogQW0gQ2FtcGVvbiAxMC0xMiwgODU1NzkgTmV1YmliZXJn LCBHZXJtYW55ClRlbDogKzQ5IDg5IDk5IDg4NTMtMCwgd3d3LmludGVsLmRl Ck1hbmFnaW5nIERpcmVjdG9yczogQ2hyaXN0aW4gRWlzZW5zY2htaWQsIENo cmlzdGlhbiBMYW1wcmVjaHRlcgpDaGFpcnBlcnNvbiBvZiB0aGUgU3VwZXJ2 aXNvcnkgQm9hcmQ6IE5pY29sZSBMYXUKUmVnaXN0ZXJlZCBPZmZpY2U6IE11 bmljaApDb21tZXJjaWFsIFJlZ2lzdGVyOiBBbXRzZ2VyaWNodCBNdWVuY2hl biBIUkIgMTg2OTI4Cg== >From gdb-patches-return-135868-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Dec 21 11:34:50 2016 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 104538 invoked by alias); 21 Dec 2016 11:34:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 104505 invoked by uid 89); 21 Dec 2016 11:34:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*F:U*nickc X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Dec 2016 11:34:47 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CE2CC80510; Wed, 21 Dec 2016 11:34:46 +0000 (UTC) Received: from [10.33.32.3] ([10.33.32.3]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uBLBYiuq027763 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 21 Dec 2016 06:34:46 -0500 Subject: Re: [PATCH] aarch64 sim bug fix for fcmp and infinity To: Jim Wilson , gdb-patches@sourceware.org References: From: Nick Clifton Message-ID: Date: Wed, 21 Dec 2016 11:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-12/txt/msg00370.txt.bz2 Content-length: 804 Hi Jim, > Debugging another gcc testsuite failure, I see that fcmp can fail when > both operands are infinities. The code tries to compute the compare > result by subtracting operands, but this can yield NaN when both > operands are inifinities. This is fixed by explicitly checking for > and handling this case. > > While writing the tescase, I noticed that qNan and sNan are not > handled correctly, but this appears to be broken in more than just the > compare instructions, so I just added comments to document the problem > and will leave it to a later patch to fix. > > The new testcase fails without the patch, and works with the patch. > Also, the gcc C testsuite unexpected failures drop from 2627 to 2568. Approved - please apply - and thanks for the continued testing. Cheers Nick