From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43450 invoked by alias); 19 Dec 2016 09:17:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43422 invoked by uid 89); 19 Dec 2016 09:17:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_50,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Envelope-From:sk:michael, H*r:sk:fmsmga1, H*r:10.7.209, Commercial X-HELO: mga05.intel.com Received: from mga05.intel.com (HELO mga05.intel.com) (192.55.52.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 Dec 2016 09:17:32 +0000 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP; 19 Dec 2016 01:17:31 -0800 X-ExtLoop1: 1 Received: from msturm-mobl2.ger.corp.intel.com (HELO [172.28.205.43]) ([172.28.205.43]) by orsmga001.jf.intel.com with ESMTP; 19 Dec 2016 01:17:29 -0800 Subject: Re: [PATCH v2 5/5] Add support for Intel PKRU register to GDB and GDBserver. To: Pedro Alves , Luis Machado , mark.kettenis@xs4all.nl, eliz@gnu.org References: <1480599538-30543-1-git-send-email-michael.sturm@intel.com> <1480599538-30543-6-git-send-email-michael.sturm@intel.com> <4d5f3401-de26-ea46-740c-516e237a7305@redhat.com> Cc: gdb-patches@sourceware.org From: "Sturm, Michael" Message-ID: <5857A5A8.8040206@intel.com> Date: Mon, 19 Dec 2016 09:17:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <4d5f3401-de26-ea46-740c-516e237a7305@redhat.com> Content-Type: text/plain; charset="windows-1252"; format="flowed" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2016-12/txt/msg00337.txt.bz2 Hello, thanks for the feedback, I'll go and change this. How about the rest of=20 the series - is it good to commit? Thanks and Regards, Michael On 09/12/2016 18:15, Pedro Alves wrote: > On 12/02/2016 01:59 AM, Luis Machado wrote: > >>> +set comp_flags "-I${srcdir}/../nat/" >>> + >>> +if { [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile} \ >>> + [list debug additional_flags=3D${comp_flags}]] } { >> Add 'untested "failed to compile"' > Nope, that's already handled by prepare_for_testing itself. > The test message used is the first argument to prepare_for_testing > above. Unfortunately, many tests blindly pass "${testfile}.exp"... > > From build_executable_from_specs (called by prepare_for_testing): > > [....] > # TESTNAME is the name of the test; this is passed to 'untested' if > # something fails. > [....] > > I had started using: > > prepare_for_testing "failed to prepare" .... > > a while ago. See: > > grep "prepare_for_testing \"[A-Za-z0-9_ ]\+" -rn > > Thanks, > Pedro Alves > Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928