From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33692 invoked by alias); 22 Sep 2017 11:19:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 33683 invoked by uid 89); 22 Sep 2017 11:19:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*M:ab25 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Sep 2017 11:19:05 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5613F267C8 for ; Fri, 22 Sep 2017 11:19:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5613F267C8 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5C26E60A98; Fri, 22 Sep 2017 11:19:01 +0000 (UTC) Subject: Re: [PATCH v3 2/5] Get rid of "gdb_dirbuf" and use "getcwd (NULL, 0)" To: Sergio Durigan Junior , GDB Patches References: <20170912042325.14927-1-sergiodj@redhat.com> <20170921225926.23132-1-sergiodj@redhat.com> <20170921225926.23132-3-sergiodj@redhat.com> From: Pedro Alves Message-ID: <584ed105-72a1-e0dc-ab25-a1c89d2b2dcd@redhat.com> Date: Fri, 22 Sep 2017 11:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170921225926.23132-3-sergiodj@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00670.txt.bz2 On 09/21/2017 11:59 PM, Sergio Durigan Junior wrote: > > gdb/ChangeLog: > yyyy-mm-dd Sergio Durigan Junior > > * cli/cli-cmds.c (pwd_command): Use "getcwd (NULL, 0)". > (cd_command): Likewise. Free "current_directory" before > assigning to it. > * main.c (captured_main_1): Use "getcwd (NULL, 0)". > * mi/mi-cmd-env.c (mi_cmd_env_pwd): Likewise. > * top.c (gdb_dirbuf): Remove global declaration. > * top.h (gdb_dirbuf): Likewise. OK. And trying the new thing: Reviewed-by: Pedro Alves ... provided the nit below is addressed. You can push patches 1 and 2 now, without waiting for the rest of the series. > diff --git a/gdb/mi/mi-cmd-env.c b/gdb/mi/mi-cmd-env.c > index 977b6e274d..db87ead33d 100644 > --- a/gdb/mi/mi-cmd-env.c > +++ b/gdb/mi/mi-cmd-env.c > @@ -73,12 +73,12 @@ mi_cmd_env_pwd (const char *command, char **argv, int argc) > } > > /* Otherwise the mi level is 2 or higher. */ > - > - if (! getcwd (gdb_dirbuf, sizeof (gdb_dirbuf))) Please leave the empty line after the comment. That comment is logically related to the code above, not the getcwd call. > + gdb::unique_xmalloc_ptr cwd (getcwd (NULL, 0)); > + if (cwd == NULL) > error (_("-environment-pwd: error finding name of working directory: %s"), > safe_strerror (errno)); > - > - uiout->field_string ("cwd", gdb_dirbuf); > + > + uiout->field_string ("cwd", cwd.get ()); > } Thanks, Pedro Alves