On 28-09-19 22:09, Kevin Buettner wrote:
> On Thu, 22 Aug 2019 16:42:22 +0200
> Tom de Vries <tdevries@suse.de> wrote:
> 
>> When running a test-case gdb.base/foo.exp with cc-with-dwz-m, a file
>> build/gdb/testsuite/outputs/gdb.base/foo/foo.dwz will be created, alongside
>> executable build/gdb/testsuite/outputs/gdb.base/foo/foo.
>>
>> This can cause problems in f.i. test-cases that test file name completion.
>>
>> Make these problems less likely by moving foo.dwz to a .tmp subdir:
>> build/gdb/testsuite/outputs/gdb.base/foo/.tmp/foo.dwz.
>>
>> Tested on x86_64-linux.
>>
>> OK for trunk?
>>
>> Thanks,
>> - Tom
>>
>> [gdb/contrib] cc-with-tweaks.sh: Create .dwz file in .tmp subdir
>>
>> gdb/ChangeLog:
>>
>> 2019-08-22  Tom de Vries  <tdevries@suse.de>
>>
>> 	* contrib/cc-with-tweaks.sh (get_tmpdir): New function.
>> 	Use $tmpdir/$(basename "$output_file").dwz instead of
>> 	"${output_file}.dwz".
> 
> LGTM.

Thanks for the review, committed.

I retested before committing and found a regression because I didn't
update gdb.dwarf2/gdb-index.exp accordingly. That's fixed in the
committed version, attached below.

Thanks,
- Tom