Re: [Patch, microblaze]: Fix for remote G Packet message too long error for baremetal.

Michael Eager
2014-06-12T14:52:09Z

On 06/12/14 01:56, Ajit Kumar Agarwal wrote:
> Based on the feedbacks, all changes have been incorporated.

Thanks!

This patch addresses some of the issues raised, such as eliminating
gdbserver changes which were unrelated. There were a number of other
issues raised previously. I'll let you know if there were any which
still need to be addressed.

>
> May I know who will committing this patch to the upstream ?

When approved, as MicroBlaze maintainer, I will apply the patch.

>
> [Patch, microblaze]: Fix for remote G Packet message too long error for baremetal.
>
> Prior to version MicroBlaze v8.10.a,EDK 13.1, XMD's gdbserver stub returned 57
> registers in response to GDB's G request. Starting with version MicroBlaze
> v8.10.a, EDK 13.1, XMD added the slr and shr register, for a count of 59
> registers.This patch adds these registers to the expected G response. This
> fixes the above problem for baremetal and also supports the backward compatibility.
>
> ChangeLog:
>
> 2014-06-12 Ajit Agarwal <ajitkum@xilinx.com>
>
> * microblaze-tdep.c (microblaze_register_names): Add
> the rshr and rslr register names.
> (microblaze_gdbarch_init): Use of tdesc_has_registers.
> Use of tdesc_find_feature. Use of tdesc_data_alloc.
> Use of tdesc_numbered_register. Use of
> microblaze_register_g_packet_guesses. Use of
> tdesc_use_registers. Use of set_gdbarch_register_type.
> (microblaze_register_g_packet_guesses): New.
>
> * microblaze-tdep.h (microblaze_reg_num): Add
> field MICROBLAZE_SLR_REGNUM and MICROBLAZE_SHR_REGNUM
> MICROBLAZE_NUM_REGS.
> (microblaze_frame_cache): Use of MICROBLAZE_NUM_REGS.
>
> * features/microblaze-cpu.xml: New file.
>
> * features/microblaze-linux.c: New file.
>
> * features/microblaze-linux.xml: New file.
>
> * regformats/reg-microblaze.dat: New file.
>
> * features/Makefile (microblaze-linux): Add microblaze-linux
> and microblaze-expedite.
>
> Signed-off-by:Ajit Agarwal ajitkum@xilinx.com
>
> Thanks & Regards
> Ajit
>

--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077