From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4JZ8IJkm82ViCgcAWB0awg (envelope-from ) for ; Thu, 14 Mar 2024 12:32:25 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ObOqJYB4; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=u+aXxTgk; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ObOqJYB4; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=u+aXxTgk; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7EED71E0BB; Thu, 14 Mar 2024 12:32:25 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 64F5A1E01D for ; Thu, 14 Mar 2024 12:32:23 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C6D8D38460A8 for ; Thu, 14 Mar 2024 16:32:22 +0000 (GMT) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 25DFF384B11A for ; Thu, 14 Mar 2024 16:32:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 25DFF384B11A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 25DFF384B11A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710433925; cv=none; b=XpUSyvLRnozHTHH9d66aVvBgKkuJ8orS8kWVGEtfv+nWdAYnqrUR9bWLR4psm/vOaOjy39E1rKzT+001UXI8SMfcgO7BZxFjBGOKzW5xtiHW90pIUVwQMBEuIRdapBjPsr41okcSlCg6IYcLQkcU+v9rNVKagJYDmbV3TEQttKU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710433925; c=relaxed/simple; bh=NvsnUbEmzNWE7geSj13x2Z5pPeksZ9LgkIboM4l4ZYw=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=OQdqCC88TsVuTMPXmwVB7DZCUekKdJCakFKorUASpdHATzqVBxl1Slgz+4wyU5ExWvidG1ecnU8MR6R0CpxqMEGteyeEx3/Or9n4KWZX2sWBt2z4V3i83we6uyMCl3sis7QrtWyQ6l6RzBq8TbLAe6I2M2MBTb+vrDSS5Ar/iuw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 050311F84E; Thu, 14 Mar 2024 16:32:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1710433923; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JNKCQIZw4yaDNx11WKILFDn07JvlE1u3xVIRWJ/dOI0=; b=ObOqJYB4uTnVp4cUzUtlOG5+ZPRdfzBt7rhKBoAKh5ex5/JAwrz7SenYJOEmvLLLDPmhdA nDvPwSbqrYePiANwPym5qBf0lgk5Uhl56ulXehnv4QRw6xVC08efdlQJKSK9LHCTU4j27t uB6yxD6pFUkO4ZyT1in5b36T/WBbMr8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1710433923; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JNKCQIZw4yaDNx11WKILFDn07JvlE1u3xVIRWJ/dOI0=; b=u+aXxTgk/+9nKeBIzkaj0UWdHdkdxhZqmJZ9aCWAL8J/IxJqdVPh5p0e6dt4Z+J0TTpjIl 5GB32jDLFeWo86Ag== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1710433923; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JNKCQIZw4yaDNx11WKILFDn07JvlE1u3xVIRWJ/dOI0=; b=ObOqJYB4uTnVp4cUzUtlOG5+ZPRdfzBt7rhKBoAKh5ex5/JAwrz7SenYJOEmvLLLDPmhdA nDvPwSbqrYePiANwPym5qBf0lgk5Uhl56ulXehnv4QRw6xVC08efdlQJKSK9LHCTU4j27t uB6yxD6pFUkO4ZyT1in5b36T/WBbMr8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1710433923; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JNKCQIZw4yaDNx11WKILFDn07JvlE1u3xVIRWJ/dOI0=; b=u+aXxTgk/+9nKeBIzkaj0UWdHdkdxhZqmJZ9aCWAL8J/IxJqdVPh5p0e6dt4Z+J0TTpjIl 5GB32jDLFeWo86Ag== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D78321368C; Thu, 14 Mar 2024 16:32:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id W2I6M4Im82VVPwAAD6G6ig (envelope-from ); Thu, 14 Mar 2024 16:32:02 +0000 Message-ID: <57c12445-8c2b-4883-b3dd-2f7395427e39@suse.de> Date: Thu, 14 Mar 2024 17:32:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/build] Fix build on postmarketos Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20240314095440.23256-1-tdevries@suse.de> <87zfv1kmqm.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87zfv1kmqm.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.00 X-Spamd-Result: default: False [-1.00 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-0.71)[83.56%]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCPT_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,sourceware.org:url]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Level: Authentication-Results: smtp-out2.suse.de; none X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 3/14/24 13:43, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> I tried building gdbserver on postmarketos (which is based on alpine linux, > Tom> which uses musl libc), and ran into: > Tom> ... > Tom> gdbserver/linux-low.cc: In lambda function: > Tom> gdbserver/linux-low.cc:1907:41: error: \ > Tom> 'W_EXITCODE' was not declared in this scope > Tom> 1907 | mark_lwp_dead (leader_lp, W_EXITCODE (0, 0), true); > Tom> | ^~~~~~~~~~ > Tom> ... > > Tom> The macro W_EXITCODE is not defined in gdbsupport/gdb_wait.h, but WSETEXIT is: > Tom> ... > Tom> /* These are not defined in POSIX, but are used by our programs. */ > > Tom> #ifndef WSETEXIT > Tom> # ifdef W_EXITCODE > Tom> #define WSETEXIT(w,status) ((w) = W_EXITCODE(status,0)) > Tom> # else > Tom> #define WSETEXIT(w,status) ((w) = (0 | ((status) << 8))) > Tom> # endif > Tom> #endif > Tom> ... > > I think it'd be better to change this to define W_EXITCODE. > WSETEXIT isn't used in the tree at all AFAICT. Thanks for the review. Fine by me, I've submitted a v2 here ( https://sourceware.org/pipermail/gdb-patches/2024-March/207288.html ). Thanks, - Tom