From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72925 invoked by alias); 20 Oct 2017 12:17:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72777 invoked by uid 89); 20 Oct 2017 12:17:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-7.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=5-7, 71, 6.7, 6.8 X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Oct 2017 12:17:43 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 6BB7C815A8 for ; Fri, 20 Oct 2017 14:17:41 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YSIIH9QdRgrs for ; Fri, 20 Oct 2017 14:17:41 +0200 (CEST) Received: from Xaviers-MacBook-Pro.local (unknown [10.10.8.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id 1606B8150F for ; Fri, 20 Oct 2017 14:17:40 +0200 (CEST) Subject: Re: [RFA v3] enable/disable sub breakpoint range To: gdb-patches@sourceware.org References: <83lgks1e1h.fsf@gnu.org> From: Xavier Roirand Message-ID: <57a9cdc7-a5fc-0852-8ebe-c7c32c78d475@adacore.com> Date: Fri, 20 Oct 2017 12:17:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00659.txt.bz2 Hello, Le 10/3/17 à 6:02 PM, Pedro Alves a écrit : > On 10/03/2017 03:50 PM, Eli Zaretskii wrote: >>> From: Xavier Roirand > > I'm wondering whether it wouldn't be better to expand this section > of the manual: > > @cindex breakpoint ranges > @cindex breakpoint lists > @cindex ranges of breakpoints > @cindex lists of breakpoints > Some @value{GDBN} commands accept a space-separated list of breakpoints > on which to operate. A list element can be either a single breakpoint number, > like @samp{5}, or a range of such numbers, like @samp{5-7}. > When a breakpoint list is given to a command, all breakpoints in that list > are operated on. > > To describe locations as well. Similarly to how we describe > "thread ID lists", where we have: > > @anchor{thread ID lists} > @cindex thread ID lists > Some commands accept a space-separated @dfn{thread ID list} as > argument. A list element can be: > > @enumerate > @item > A thread ID as shown in the first field of the @samp{info threads} > display, with or without an inferior qualifier. E.g., @samp{2.1} or > @samp{1}. > > @item > A range of thread numbers, again with or without an inferior > qualifier, as in @var{inf}.@var{thr1}-@var{thr2} or > @var{thr1}-@var{thr2}. E.g., @samp{1.2-4} or @samp{2-4}. > > @item > All threads of an inferior, specified with a star wildcard, with or > without an inferior qualifier, as in @var{inf}.@code{*} (e.g., > @samp{1.*}) or @code{*}. The former refers to all threads of the > given inferior, and the latter form without an inferior qualifier > refers to all threads of the current inferior. > > @end enumerate > > For example, if the current inferior is 1, and inferior 7 has one > thread with ID 7.1, the thread list @samp{1 2-3 4.5 6.7-9 7.*} > includes threads 1 to 3 of inferior 1, thread 5 of inferior 4, threads > 7 to 9 of inferior 6 and all threads of inferior 7. That is, in > expanded qualified form, the same as @samp{1.1 1.2 1.3 4.5 6.7 6.8 6.9 > 7.1}. > > Then commands that accept a thread ID list xref here. > > We'd do the same to breakpoint commands, i.e., commands that take > an breakpoint/location list would xref the description of breakpoint > lists. > > See commit 5d5658a1d3c3 ("Per-inferior/Inferior-qualified thread IDs") > for how that looked like before support for '*' ranges was added. > > (And now I wonder whether it'd make sense to model the breakpoint > number parsing on a simplified version of the thread ID number > parsing. See gdb/tid-parse.h / tid_range_parser.) > Unfortunately I don't have enough time to work on a simplified version of the thread id number parsing in order to provide this enable/disable sub range feature. What I can add in my current patch is the support for .* notation if you think this is something really useful. Let me know what do you think so I can propose a new patch. Regards. > Thanks, > Pedro Alves >