From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75821 invoked by alias); 28 Sep 2016 14:58:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75812 invoked by uid 89); 28 Sep 2016 14:58:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_20,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=blvd, Blvd, 1960, alto X-HELO: homiemail-a43.g.dreamhost.com Received: from sub5.mail.dreamhost.com (HELO homiemail-a43.g.dreamhost.com) (208.113.200.129) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Sep 2016 14:58:09 +0000 Received: from homiemail-a43.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a43.g.dreamhost.com (Postfix) with ESMTP id 11568600477F for ; Wed, 28 Sep 2016 07:58:08 -0700 (PDT) Received: from vm-fedora21.eagercon.com (c-71-202-23-94.hsd1.ca.comcast.net [71.202.23.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by homiemail-a43.g.dreamhost.com (Postfix) with ESMTPSA id E3CC2600477D for ; Wed, 28 Sep 2016 07:58:07 -0700 (PDT) Subject: Re: [PATCH 03/13] gdbarch_breakpoint_from_pc doesn't return NULL To: gdb-patches@sourceware.org References: <1472655965-12212-1-git-send-email-yao.qi@linaro.org> <1472655965-12212-4-git-send-email-yao.qi@linaro.org> From: Michael Eager Message-ID: <57EBDA7F.7000003@eagerm.com> Date: Wed, 28 Sep 2016 15:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1472655965-12212-4-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg00399.txt.bz2 On 08/31/2016 08:05 AM, Yao Qi wrote: > gdbarch_breakpoint_from_pc doesn't return NULL except for > ia64_breakpoint_from_pc, and we checked its return value in three > places. In microblaze_linux_memory_remove_breakpoint and > ppc_linux_memory_remove_breakpoint, gdbarch_breakpoint_from_pc never > returns NULL, so we can remove the NULL checking. In > default_memory_insert_breakpoint, gdbarch_breakpoint_from_pc can't > returns NULL too because ia64 defines its own memory_insert_breakpoint. > > gdb: > > 2016-08-30 Yao Qi > > * mem-break.c (default_memory_insert_breakpoint): Don't check > 'bp' against NULL. > * microblaze-linux-tdep.c (microblaze_linux_memory_remove_breakpoint): > Likewise. > * ppc-linux-tdep.c (ppc_linux_memory_remove_breakpoint): Likewise. Microblaze change OK. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077