From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73343 invoked by alias); 12 Feb 2020 13:30:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 73268 invoked by uid 89); 12 Feb 2020 13:30:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 spammy= X-HELO: FRA01-MR2-obe.outbound.protection.outlook.com Received: from mail-eopbgr90055.outbound.protection.outlook.com (HELO FRA01-MR2-obe.outbound.protection.outlook.com) (40.107.9.55) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Feb 2020 13:30:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wKBIN3vjOVJMsJQxgs7gYtqcrAGv2mBA0IaTr9OaK0w=; b=wV0/wB6qBmh+t+3E+QOba1xzN+5jVGyks3cj4KjOPV6t4rP5yVqEFA134Ml8sKzQSgUw4590+R/Q1jLkV9BSjtb1GkxHoZQs2VstqygV0CnG24vf92rEQJhqpGhgbt3RGeecJXniQ0WdCBrwSTJZHabHpK/Y9E4shH7NBOM7sTs= Received: from DB6PR0801CA0056.eurprd08.prod.outlook.com (2603:10a6:4:2b::24) by PR2PR08MB4665.eurprd08.prod.outlook.com (2603:10a6:101:25::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.22; Wed, 12 Feb 2020 13:29:56 +0000 Received: from AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::204) by DB6PR0801CA0056.outlook.office365.com (2603:10a6:4:2b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.22 via Frontend Transport; Wed, 12 Feb 2020 13:29:56 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT055.mail.protection.outlook.com (10.152.17.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.18 via Frontend Transport; Wed, 12 Feb 2020 13:29:56 +0000 Received: ("Tessian outbound d1ceabc7047e:v42"); Wed, 12 Feb 2020 13:29:56 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: f872d2a9bc606050 X-CR-MTA-TID: 64aa7808 Received: from 42faa6197ad4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1E1E8C9A-C9C5-4AD3-BFB8-836CD5549BE8.1; Wed, 12 Feb 2020 13:29:49 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 42faa6197ad4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 12 Feb 2020 13:29:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NjE9x3yKXIKYpM8cw8x3c+ZMS050W5JtbcORUj+mtGY5UaAVMAqlseenKAWPsPw6PwuVbbJehxCNPv2ch+m3C5P37iTfOrUy4YmVquMKA1rTx4wdG0J6vozvbTgDXP0SZ52U9iulFW8+yGpl/zGssrDzJ9EH2AUup4L4f0I6hYlfRPsINi44FFjfT6cuoi3+oq3VkiDgurXeAzxAMPnpUAwTchvPAqputF3RJ+EP10F5Ck/BFSDnT/x7sCxAJD4kV9uBcmR4WCFPyGUnPBSdxoJgjGXhFJb56IoJKi0RJ03Gyfh2P19nJVu7iZaG0u/jcmMRaqXpOVljq/yY6iaoxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wKBIN3vjOVJMsJQxgs7gYtqcrAGv2mBA0IaTr9OaK0w=; b=WymJAcgiWuIeYnJ+WyZbJd08iRFGiEx/bdXl+gMUJ1Tzx9Z0V6zjPHnNYdA4PK3D4VpnR2NUf8F/7eKkmkRBzPw97qDGP1l0txyDGRIJz0QDfxViCffCkp06NaDCXcATNmnX63YWtOhk8MdDX2JWqe1MrCId/qx1N/qqPV4XvQilfcU0QIAsggvkpPraZmBh5j0IqHnQvi6leYdkAh3ciLR2APDxbV9xEENBZnoiK6pWqxlbUZLvUQ/j62DR7MRkCKKOb1wO97O00Na6Cyl8WcDCqYy8I8YwrhnyrCOmQN8eHn0rXmgWPuBOo9o8wpoelOTKMOpaa+qIZ6K4DnsSZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wKBIN3vjOVJMsJQxgs7gYtqcrAGv2mBA0IaTr9OaK0w=; b=wV0/wB6qBmh+t+3E+QOba1xzN+5jVGyks3cj4KjOPV6t4rP5yVqEFA134Ml8sKzQSgUw4590+R/Q1jLkV9BSjtb1GkxHoZQs2VstqygV0CnG24vf92rEQJhqpGhgbt3RGeecJXniQ0WdCBrwSTJZHabHpK/Y9E4shH7NBOM7sTs= Received: from HE1PR08MB2826.eurprd08.prod.outlook.com (10.170.245.11) by HE1PR08MB2939.eurprd08.prod.outlook.com (10.170.244.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2707.26; Wed, 12 Feb 2020 13:29:48 +0000 Received: from HE1PR08MB2826.eurprd08.prod.outlook.com ([fe80::51da:426:423b:aa21]) by HE1PR08MB2826.eurprd08.prod.outlook.com ([fe80::51da:426:423b:aa21%6]) with mapi id 15.20.2707.030; Wed, 12 Feb 2020 13:29:48 +0000 From: Alan Hayward To: Christian Biesinger CC: gdb-patches , nd Subject: Re: [PATCH] Fix arm-netbsd build error Date: Wed, 12 Feb 2020 13:30:00 -0000 Message-ID: <57C0F31A-7085-4722-93B6-062DF7A10E58@arm.com> References: <20200211225503.32992-1-cbiesinger@google.com> In-Reply-To: Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:1923;OLM:1923; X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10001)(10009020)(4636009)(39860400002)(396003)(346002)(366004)(376002)(136003)(199004)(189003)(316002)(6486002)(36756003)(54906003)(966005)(2906002)(6512007)(6506007)(71200400001)(81156014)(26005)(33656002)(81166006)(186003)(5660300002)(8936002)(53546011)(8676002)(2616005)(4326008)(64756008)(91956017)(66446008)(66946007)(66476007)(6916009)(76116006)(86362001)(478600001)(66556008);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR08MB2939;H:HE1PR08MB2826.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: uv8ysLa+H4SYGzWgz2n3+Z8rTy3JOdZzol9xhcK8ilZVFQpYd4gBFZmIyA27L+VQ22joEPEPNyWD9A8AHWKgSLo1J5KyDlmVP128gFgo2/zU06+6DJRHveLLXbVKYTfRhMC0nSVFoPF8ZRwMyrl9z0OMu1mVN/l0YeBSskc3qn+6Hb++TFCvliz1ZYAXlZ5TMbuYapQLqOI0QSJ77/BvjOtc8iLJNqVzRlh2X6jH+nDPqK7J6NpvyCwemyoCPL6yfwmU3iHI4AJt4nVop1hWp6mbvfgzo1MGqjlnihoaA1Q3Jlm+OqmEp3fRSG3TJTVscejRoZXZo+08eb1R/enn3ffRCxGcfuGOuy7HZnLgPqTKZTMSemkELZ3b6KRWkfOKw1CoI5FUCsi7CEIbsDjF1HyOFX9jeNd6o9VS7B9Z7cRT+8uA28gqhWHsr/hHNMOVfWKen22XD3D4XSoBbSqcJXKaTFhq+7llD07sSPcsypgTjZlm1h+ynxR/vnKWOG9NQ2VIeFDTwGJ8955RBVKjH6QWrAkjDtpMBEkwiDViC1zUS4LpL7vxtGV0oE5NaC9RHGGuM3bx5amdH8uLcHSD+A== x-ms-exchange-antispam-messagedata: IOxuDbQzlNgvmmPsl2nqNp2tLkTqYMx5anFGawb5D3fAPCcOuTRVk5nNLTSzfQRNrArrQFQLbmA39j0Als3wH1dZOmYTurA9Z7ikICbYeSjk/SyUg8AWxheTR9kZ0xlr0dcjp3ltgTd+T0uMDC7qVg== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; Return-Path: Alan.Hayward@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: a510c0e8-b2fe-4d2f-af26-08d7afbfa1f0 X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00449.txt.bz2 DQoNCj4gT24gMTEgRmViIDIwMjAsIGF0IDIzOjM0LCBDaHJpc3RpYW4gQmll c2luZ2VyIHZpYSBnZGItcGF0Y2hlcyA8Z2RiLXBhdGNoZXNAc291cmNld2Fy ZS5vcmc+IHdyb3RlOg0KPiANCj4gT24gVHVlLCBGZWIgMTEsIDIwMjAgYXQg NDo1NSBQTSBDaHJpc3RpYW4gQmllc2luZ2VyDQo+IDxjYmllc2luZ2VyQGdv b2dsZS5jb20+IHdyb3RlOg0KPj4gDQo+PiBUaGUgZmxvYXRpbmcgcG9pbnQg cmVnaXN0ZXIgaW50ZXJmYWNlIGhhcyBjaGFuZ2VkIHRvIHRoaXM6DQo+PiBo dHRwczovL2dpdGh1Yi5jb20vTmV0QlNEL3NyYy9ibG9iL3RydW5rL3N5cy9h cmNoL2FybS9pbmNsdWRlL3JlZy5oDQo+PiANCj4+IEl0IG5vdyB1c2VzIFZG UCBpbnN0ZWFkIG9mIEZQQSByZWdpc3RlcnMuIFRoaXMgcGF0Y2ggdXBkYXRl cw0KPj4gYXJtLW5ic2QtbmF0LmMgYWNjb3JkaW5nbHkuDQo+PiANCj4+IFRl c3RlZCBieSBjb21waWxpbmcgb24gYXJtLW5ldGJzZCBvbiBxZW11LiBGb3Ig YWN0dWFsbHkgdGVzdGluZywgdGhlcmUNCj4+IHNlZW1zIHRvIGJlIHNvbWV0 aGluZyBtaXNzaW5nIGFzICJpbmZvIHJlZ2lzdGVycyIgb25seSBzaG93cyBG UEENCj4+IHJlZ2lzdGVycyBhbmQgbm8gVkZQIG9uZXMuIEkgYW0gc3RpbGwg aW52ZXN0aWdhdGluZyB3aHkgdGhpcyBpczsNCj4+IHBsZWFzZSBsZXQgbWUg a25vdyBpZiB5b3Uga25vdy4gSG93ZXZlciwgSSB0aGluayB0aGlzIGlzIHN0 aWxsIGdvb2QNCj4+IHRvIGNoZWNrIGluIGFzLWlzLg0KPiANCj4gSG0uLi4g dGhpcyBpcyBwZXJoYXBzIGJlY2F1c2UgYXJtX25ldGJzZF9uYXRfdGFyZ2V0 IGRvZXMgbm90IGltcGxlbWVudA0KPiByZWFkX2Rlc2NyaXB0aW9uOyBpZiBp dCByZXR1cm5lZCBhcm1fcmVhZF9kZXNjcmlwdGlvbg0KPiAoQVJNX0ZQX1RZ UEVfVkZQVjIpIHRoaXMgbWF5IHdvcms/DQo+IA0KDQpZZXMsIGxvb2tzIGxp a2UgbmV0YnNkIGlzbuKAmXQgdXNpbmcgYW55IHRhcmdldCBkZXNjcmlwdGlv biBmdW5jdGlvbmFsaXR5Lg0KDQpJIHN1c3BlY3QgdGhlIGNvZGUgaXMgZ2V0 dGluZyBpbnRvIGFybV9nZGJhcmNoX2luaXQoKSB3aXRoIGEgbnVsbCB0ZGVz YywNCmFuZCB0aGVuIHVzaW5nIHRoZSBBVVRPIHNldHRpbmcuIEJ1dCB0aGF0 4oCZcyBqdXN0IGEgZ3Vlc3MuDQoNCkltcGxlbWVudGluZyByZWFkX2Rlc2Ny aXB0aW9uIGFzIHlvdSBzdWdnZXN0IHNob3VsZCBoZWxwLiBIb3dldmVyLA0K cmVhZF9kZXNjcmlwdGlvbiBzaG91bGQgcHJvYmFibHkgZG8gSFdDQVAgY2hl Y2tpbmcgc2ltaWxhciB0byB0aGUNCmFybV9saW51eF9uYXRfdGFyZ2V0IGFu ZCBhcm1fZmJzZF9uYXRfdGFyZ2V0IHZlcnNpb25zLg0KDQpXaXRob3V0IHRo YXQsIEnigJlkIHdvcnJ5IHRoYXQgeW91ciBwYXRjaCBiZWxvdyBtaWdodCBz dGFydCB3cml0aW5nIG9mZiB0aGUNCmVuZCBvZiB0aGUgcmVnY2FjaGUgdGhh dCBoYWQgYmVlbiBhbGxvY2F0ZWQgZm9yIGEgZmV3ZXIgbnVtYmVyIG9mIHJl Z2lzdGVycy4NCg0KPj4gDQo+PiBnZGIvQ2hhbmdlTG9nOg0KPj4gDQo+PiAy MDIwLTAyLTExICBDaHJpc3RpYW4gQmllc2luZ2VyICA8Y2JpZXNpbmdlckBn b29nbGUuY29tPg0KPj4gDQo+PiAgICAgICAgKiBhcm0tbmJzZC1uYXQuYyAo YXJtX3N1cHBseV9mcGFyZWdzZXQpOiBSZW5hbWUgdG8uLi4NCj4+ICAgICAg ICAoYXJtX3N1cHBseV92ZnByZWdzZXQpOiAuLi50aGlzLCBhbmQgdXBkYXRl IHRvIHVzZSBWRlAgcmVnaXN0ZXJzLg0KPj4gICAgICAgIChmZXRjaF9mcF9y ZWdpc3Rlcik6IFVwZGF0ZS4NCj4+ICAgICAgICAoZmV0Y2hfZnBfcmVncyk6 IFVwZGF0ZS4NCj4+ICAgICAgICAoc3RvcmVfZnBfcmVnaXN0ZXIpOiBVcGRh dGUuDQo+PiAgICAgICAgKHN0b3JlX2ZwX3JlZ3MpOiBVcGRhdGUuDQo+PiAg ICAgICAgKGZldGNoX2VsZmNvcmVfcmVnaXN0ZXJzKTogVXBkYXRlLg0KPj4g LS0tDQo+PiBnZGIvYXJtLW5ic2QtbmF0LmMgfCA4MCArKysrKysrKysrKysr KysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tDQo+PiAxIGZpbGUg Y2hhbmdlZCwgMzQgaW5zZXJ0aW9ucygrKSwgNDYgZGVsZXRpb25zKC0pDQo+ PiANCj4+IGRpZmYgLS1naXQgYS9nZGIvYXJtLW5ic2QtbmF0LmMgYi9nZGIv YXJtLW5ic2QtbmF0LmMNCj4+IGluZGV4IDExYWZjMjg5YzMuLjgwMjdmNTRk ZmUgMTAwNjQ0DQo+PiAtLS0gYS9nZGIvYXJtLW5ic2QtbmF0LmMNCj4+ICsr KyBiL2dkYi9hcm0tbmJzZC1uYXQuYw0KPj4gQEAgLTY1LDE1ICs2NSwxMyBA QCBhcm1fc3VwcGx5X2dyZWdzZXQgKHN0cnVjdCByZWdjYWNoZSAqcmVnY2Fj aGUsIHN0cnVjdCByZWcgKmdyZWdzZXQpDQo+PiB9DQo+PiANCj4+IHN0YXRp YyB2b2lkDQo+PiAtYXJtX3N1cHBseV9mcGFyZWdzZXQgKHN0cnVjdCByZWdj YWNoZSAqcmVnY2FjaGUsIHN0cnVjdCBmcHJlZyAqZnBhcmVnc2V0KQ0KPj4g K2FybV9zdXBwbHlfdmZwcmVnc2V0IChzdHJ1Y3QgcmVnY2FjaGUgKnJlZ2Nh Y2hlLCBzdHJ1Y3QgZnByZWcgKmZwcmVnc2V0KQ0KPj4gew0KPj4gLSAgaW50 IHJlZ25vOw0KPj4gLQ0KPj4gLSAgZm9yIChyZWdubyA9IEFSTV9GMF9SRUdO VU07IHJlZ25vIDw9IEFSTV9GN19SRUdOVU07IHJlZ25vKyspDQo+PiAtICAg IHJlZ2NhY2hlLT5yYXdfc3VwcGx5IChyZWdubywNCj4+IC0gICAgICAgICAg ICAgICAgICAgICAgICAgKGNoYXIgKikgJmZwYXJlZ3NldC0+ZnByW3JlZ25v IC0gQVJNX0YwX1JFR05VTV0pOw0KPj4gKyAgc3RydWN0IHZmcHJlZyAmdmZw ID0gZnByZWdzZXQtPmZwcl92ZnA7DQo+PiArICBmb3IgKGludCByZWdubyA9 IEFSTV9EMF9SRUdOVU07IHJlZ25vIDw9IEFSTV9EMzFfUkVHTlVNOyByZWdu bysrKQ0KPj4gKyAgICByZWdjYWNoZS0+cmF3X3N1cHBseSAocmVnbm8sIChj aGFyICopICZ2ZnAudmZwX3JlZ3NbcmVnbm8gLSBBUk1fRDBfUkVHTlVNXSk7 DQo+PiANCj4+IC0gIHJlZ2NhY2hlLT5yYXdfc3VwcGx5IChBUk1fRlBTX1JF R05VTSwgKGNoYXIgKikgJmZwYXJlZ3NldC0+ZnByX2Zwc3IpOw0KPj4gKyAg cmVnY2FjaGUtPnJhd19zdXBwbHkgKEFSTV9GUFNDUl9SRUdOVU0sIChjaGFy ICopICZ2ZnAudmZwX2Zwc2NyKTsNCj4+IH0NCj4+IA0KPj4gc3RhdGljIHZv aWQNCj4+IEBAIC0xNDcsMTAgKzE0NSwxMCBAQCBzdGF0aWMgdm9pZA0KPj4g ZmV0Y2hfZnBfcmVnaXN0ZXIgKHN0cnVjdCByZWdjYWNoZSAqcmVnY2FjaGUs IGludCByZWdubykNCj4+IHsNCj4+ICAgc3RydWN0IGZwcmVnIGluZmVyaW9y X2ZwX3JlZ2lzdGVyczsNCj4+IC0gIGludCByZXQ7DQo+PiArICBpbnQgcmV0 ID0gcHRyYWNlIChQVF9HRVRGUFJFR1MsIHJlZ2NhY2hlLT5wdGlkICgpLnBp ZCAoKSwNCj4+ICsgICAgICAgICAgICAgICAgICAgKFBUUkFDRV9UWVBFX0FS RzMpICZpbmZlcmlvcl9mcF9yZWdpc3RlcnMsIDApOw0KPj4gDQo+PiAtICBy ZXQgPSBwdHJhY2UgKFBUX0dFVEZQUkVHUywgcmVnY2FjaGUtPnB0aWQgKCku cGlkICgpLA0KPj4gLSAgICAgICAgICAgICAgIChQVFJBQ0VfVFlQRV9BUkcz KSAmaW5mZXJpb3JfZnBfcmVnaXN0ZXJzLCAwKTsNCj4+ICsgIHN0cnVjdCB2 ZnByZWcgJnZmcCA9IGluZmVyaW9yX2ZwX3JlZ2lzdGVycy5mcHJfdmZwOw0K Pj4gDQo+PiAgIGlmIChyZXQgPCAwKQ0KPj4gICAgIHsNCj4+IEBAIC0xNTgs MTggKzE1NiwxNSBAQCBmZXRjaF9mcF9yZWdpc3RlciAoc3RydWN0IHJlZ2Nh Y2hlICpyZWdjYWNoZSwgaW50IHJlZ25vKQ0KPj4gICAgICAgcmV0dXJuOw0K Pj4gICAgIH0NCj4+IA0KPj4gLSAgc3dpdGNoIChyZWdubykNCj4+ICsgIGlm IChyZWdubyA9PSBBUk1fRlBTQ1JfUkVHTlVNKQ0KPj4gKyAgICByZWdjYWNo ZS0+cmF3X3N1cHBseSAoQVJNX0ZQU0NSX1JFR05VTSwgKGNoYXIgKikgJnZm cC52ZnBfZnBzY3IpOw0KPj4gKyAgZWxzZSBpZiAocmVnbm8gPj0gQVJNX0Qw X1JFR05VTSAmJiByZWdubyA8PSBBUk1fRDMxX1JFR05VTSkNCj4+ICAgICB7 DQo+PiAtICAgIGNhc2UgQVJNX0ZQU19SRUdOVU06DQo+PiAtICAgICAgcmVn Y2FjaGUtPnJhd19zdXBwbHkgKEFSTV9GUFNfUkVHTlVNLA0KPj4gLSAgICAg ICAgICAgICAgICAgICAgICAgICAgIChjaGFyICopICZpbmZlcmlvcl9mcF9y ZWdpc3RlcnMuZnByX2Zwc3IpOw0KPj4gLSAgICAgIGJyZWFrOw0KPj4gLQ0K Pj4gLSAgICBkZWZhdWx0Og0KPj4gLSAgICAgIHJlZ2NhY2hlLT5yYXdfc3Vw cGx5DQo+PiAtICAgICAgIChyZWdubywgKGNoYXIgKikgJmluZmVyaW9yX2Zw X3JlZ2lzdGVycy5mcHJbcmVnbm8gLSBBUk1fRjBfUkVHTlVNXSk7DQo+PiAt ICAgICAgYnJlYWs7DQo+PiArICAgICAgcmVnY2FjaGUtPnJhd19zdXBwbHkg KHJlZ25vLA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgIChjaGFy ICopICZ2ZnAudmZwX3JlZ3NbcmVnbm8gLSBBUk1fRDBfUkVHTlVNXSk7DQo+ PiAgICAgfQ0KPj4gKyAgZWxzZQ0KPj4gKyAgICB3YXJuaW5nIChfKCJJbnZh bGlkIHJlZ2lzdGVyIG51bWJlci4iKSk7DQo+PiB9DQo+PiANCj4+IHN0YXRp YyB2b2lkDQo+PiBAQCAtMTg4LDcgKzE4Myw3IEBAIGZldGNoX2ZwX3JlZ3Mg KHN0cnVjdCByZWdjYWNoZSAqcmVnY2FjaGUpDQo+PiAgICAgICByZXR1cm47 DQo+PiAgICAgfQ0KPj4gDQo+PiAtICBhcm1fc3VwcGx5X2ZwYXJlZ3NldCAo cmVnY2FjaGUsICZpbmZlcmlvcl9mcF9yZWdpc3RlcnMpOw0KPj4gKyAgYXJt X3N1cHBseV92ZnByZWdzZXQgKHJlZ2NhY2hlLCAmaW5mZXJpb3JfZnBfcmVn aXN0ZXJzKTsNCj4+IH0NCj4+IA0KPj4gdm9pZA0KPj4gQEAgLTMyNywxMCAr MzIyLDkgQEAgc3RhdGljIHZvaWQNCj4+IHN0b3JlX2ZwX3JlZ2lzdGVyIChj b25zdCBzdHJ1Y3QgcmVnY2FjaGUgKnJlZ2NhY2hlLCBpbnQgcmVnbm8pDQo+ PiB7DQo+PiAgIHN0cnVjdCBmcHJlZyBpbmZlcmlvcl9mcF9yZWdpc3RlcnM7 DQo+PiAtICBpbnQgcmV0Ow0KPj4gLQ0KPj4gLSAgcmV0ID0gcHRyYWNlIChQ VF9HRVRGUFJFR1MsIHJlZ2NhY2hlLT5wdGlkICgpLnBpZCAoKSwNCj4+IC0g ICAgICAgICAgICAgICAoUFRSQUNFX1RZUEVfQVJHMykgJmluZmVyaW9yX2Zw X3JlZ2lzdGVycywgMCk7DQo+PiArICBpbnQgcmV0ID0gcHRyYWNlIChQVF9H RVRGUFJFR1MsIHJlZ2NhY2hlLT5wdGlkICgpLnBpZCAoKSwNCj4+ICsgICAg ICAgICAgICAgICAgICAgKFBUUkFDRV9UWVBFX0FSRzMpICZpbmZlcmlvcl9m cF9yZWdpc3RlcnMsIDApOw0KPj4gKyAgc3RydWN0IHZmcHJlZyAmdmZwID0g aW5mZXJpb3JfZnBfcmVnaXN0ZXJzLmZwcl92ZnA7DQo+PiANCj4+ICAgaWYg KHJldCA8IDApDQo+PiAgICAgew0KPj4gQEAgLTMzOCwxOCArMzMyLDE1IEBA IHN0b3JlX2ZwX3JlZ2lzdGVyIChjb25zdCBzdHJ1Y3QgcmVnY2FjaGUgKnJl Z2NhY2hlLCBpbnQgcmVnbm8pDQo+PiAgICAgICByZXR1cm47DQo+PiAgICAg fQ0KPj4gDQo+PiAtICBzd2l0Y2ggKHJlZ25vKQ0KPj4gKyAgaWYgKHJlZ25v ID09IEFSTV9GUFNDUl9SRUdOVU0pDQo+PiArICAgIHJlZ2NhY2hlLT5yYXdf Y29sbGVjdCAoQVJNX0ZQU0NSX1JFR05VTSwgKGNoYXIgKikgJnZmcC52ZnBf ZnBzY3IpOw0KPj4gKyAgZWxzZSBpZiAocmVnbm8gPj0gQVJNX0QwX1JFR05V TSAmJiByZWdubyA8PSBBUk1fRDMxX1JFR05VTSkNCj4+ICAgICB7DQo+PiAt ICAgIGNhc2UgQVJNX0ZQU19SRUdOVU06DQo+PiAtICAgICAgcmVnY2FjaGUt PnJhd19jb2xsZWN0IChBUk1fRlBTX1JFR05VTSwNCj4+IC0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgKGNoYXIgKikgJmluZmVyaW9yX2ZwX3JlZ2lz dGVycy5mcHJfZnBzcik7DQo+PiAtICAgICAgYnJlYWs7DQo+PiAtDQo+PiAt ICAgIGRlZmF1bHQ6DQo+PiAtICAgICAgcmVnY2FjaGUtPnJhd19jb2xsZWN0 DQo+PiAtICAgICAgIChyZWdubywgKGNoYXIgKikgJmluZmVyaW9yX2ZwX3Jl Z2lzdGVycy5mcHJbcmVnbm8gLSBBUk1fRjBfUkVHTlVNXSk7DQo+PiAtICAg ICAgYnJlYWs7DQo+PiArICAgICAgcmVnY2FjaGUtPnJhd19jb2xsZWN0IChy ZWdubywNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGNoYXIg KikgJnZmcC52ZnBfcmVnc1tyZWdubyAtIEFSTV9EMF9SRUdOVU1dKTsNCj4+ ICAgICB9DQo+PiArICBlbHNlDQo+PiArICAgIHdhcm5pbmcgKF8oIkludmFs aWQgcmVnaXN0ZXIgbnVtYmVyLiIpKTsNCj4+IA0KPj4gICByZXQgPSBwdHJh Y2UgKFBUX1NFVEZQUkVHUywgcmVnY2FjaGUtPnB0aWQgKCkucGlkICgpLA0K Pj4gICAgICAgICAgICAgICAgKFBUUkFDRV9UWVBFX0FSRzMpICZpbmZlcmlv cl9mcF9yZWdpc3RlcnMsIDApOw0KPj4gQEAgLTM2MSwyMCArMzUyLDE3IEBA IHN0b3JlX2ZwX3JlZ2lzdGVyIChjb25zdCBzdHJ1Y3QgcmVnY2FjaGUgKnJl Z2NhY2hlLCBpbnQgcmVnbm8pDQo+PiBzdGF0aWMgdm9pZA0KPj4gc3RvcmVf ZnBfcmVncyAoY29uc3Qgc3RydWN0IHJlZ2NhY2hlICpyZWdjYWNoZSkNCj4+ IHsNCj4+IC0gIHN0cnVjdCBmcHJlZyBpbmZlcmlvcl9mcF9yZWdpc3RlcnM7 DQo+PiAtICBpbnQgcmV0Ow0KPj4gLSAgaW50IHJlZ25vOw0KPj4gKyAgc3Ry dWN0IGZwcmVnIGZwcmVnczsNCj4+IA0KPj4gLQ0KPj4gLSAgZm9yIChyZWdu byA9IEFSTV9GMF9SRUdOVU07IHJlZ25vIDw9IEFSTV9GN19SRUdOVU07IHJl Z25vKyspDQo+PiArICBmb3IgKGludCByZWdubyA9IEFSTV9EMF9SRUdOVU07 IHJlZ25vIDw9IEFSTV9EMzFfUkVHTlVNOyByZWdubysrKQ0KPj4gICAgIHJl Z2NhY2hlLT5yYXdfY29sbGVjdA0KPj4gLSAgICAgIChyZWdubywgKGNoYXIg KikgJmluZmVyaW9yX2ZwX3JlZ2lzdGVycy5mcHJbcmVnbm8gLSBBUk1fRjBf UkVHTlVNXSk7DQo+PiArICAgICAgKHJlZ25vLCAoY2hhciAqKSAmZnByZWdz LmZwcl92ZnAudmZwX3JlZ3NbcmVnbm8gLSBBUk1fRDBfUkVHTlVNXSk7DQo+ PiANCj4+IC0gIHJlZ2NhY2hlLT5yYXdfY29sbGVjdCAoQVJNX0ZQU19SRUdO VU0sDQo+PiAtICAgICAgICAgICAgICAgICAgICAgICAgKGNoYXIgKikgJmlu ZmVyaW9yX2ZwX3JlZ2lzdGVycy5mcHJfZnBzcik7DQo+PiArICByZWdjYWNo ZS0+cmF3X2NvbGxlY3QgKEFSTV9GUFNDUl9SRUdOVU0sDQo+PiArICAgICAg ICAgICAgICAgICAgICAgICAgKGNoYXIgKikgJmZwcmVncy5mcHJfdmZwLnZm cF9mcHNjcik7DQo+PiANCj4+IC0gIHJldCA9IHB0cmFjZSAoUFRfU0VURlBS RUdTLCByZWdjYWNoZS0+cHRpZCAoKS5waWQgKCksDQo+PiAtICAgICAgICAg ICAgICAgKFBUUkFDRV9UWVBFX0FSRzMpICZpbmZlcmlvcl9mcF9yZWdpc3Rl cnMsIDApOw0KPj4gKyAgaW50IHJldCA9IHB0cmFjZSAoUFRfU0VURlBSRUdT LCByZWdjYWNoZS0+cHRpZCAoKS5waWQgKCksDQo+PiArICAgICAgICAgICAg ICAgICAgIChQVFJBQ0VfVFlQRV9BUkczKSAmZnByZWdzLCAwKTsNCj4+IA0K Pj4gICBpZiAocmV0IDwgMCkNCj4+ICAgICB3YXJuaW5nIChfKCJ1bmFibGUg dG8gc3RvcmUgZmxvYXRpbmctcG9pbnQgcmVnaXN0ZXJzIikpOw0KPj4gQEAg LTQyNyw3ICs0MTUsNyBAQCBmZXRjaF9lbGZjb3JlX3JlZ2lzdGVycyAoc3Ry dWN0IHJlZ2NhY2hlICpyZWdjYWNoZSwNCj4+ICAgICAgICAgIC8qIFRoZSBt ZW1jcHkgbWF5IGJlIHVubmVjZXNzYXJ5LCBidXQgd2UgY2FuJ3QgcmVhbGx5 IGJlIHN1cmUNCj4+ICAgICAgICAgICAgIG9mIHRoZSBhbGlnbm1lbnQgb2Yg dGhlIGRhdGEgaW4gdGhlIGNvcmUgZmlsZS4gICovDQo+PiAgICAgICAgICBt ZW1jcHkgKCZmcGFyZWdzZXQsIGNvcmVfcmVnX3NlY3QsIHNpemVvZiAoZnBh cmVnc2V0KSk7DQo+PiAtICAgICAgICAgYXJtX3N1cHBseV9mcGFyZWdzZXQg KHJlZ2NhY2hlLCAmZnBhcmVnc2V0KTsNCj4+ICsgICAgICAgICBhcm1fc3Vw cGx5X3ZmcHJlZ3NldCAocmVnY2FjaGUsICZmcGFyZWdzZXQpOw0KPj4gICAg ICAgIH0NCj4+ICAgICAgIGJyZWFrOw0KPj4gDQo+PiAtLQ0KPj4gMi4yNS4w LjIyNS5nMTI1ZTIxZWJjNy1nb29nDQo+PiANCg0K >From gdb-patches-return-164148-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Feb 12 13:56:30 2020 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 109778 invoked by alias); 12 Feb 2020 13:56:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 109754 invoked by uid 89); 12 Feb 2020 13:56:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 spammy= X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (207.211.31.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Feb 2020 13:56:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581515786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V5RcYNDSJmYu2j5NOWYkc9bU6nDW2n0Cck3LUCqLki4=; b=FzeqP40uyvaLJtgCpPJlqFZQjTIFFm+n2VZLViIRiUoP6N8CcQO6e40wZEE+8fAlz+Rvf0 yCukkl3rykHa34thwuPIUlR3SA+T4EWwaQmVE3d0yGktl1YE1/zNjbxcM2xEmrwkOFuAeN 9kD+5/4OsoK00puzPvefEYNTXcshdSA= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-77-3XUqfvEANjK1DFOP_5Qf0g-1; Wed, 12 Feb 2020 08:56:20 -0500 Received: by mail-wr1-f69.google.com with SMTP id p8so847319wrw.5 for ; Wed, 12 Feb 2020 05:56:20 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id s8sm758525wrt.57.2020.02.12.05.56.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Feb 2020 05:56:16 -0800 (PST) Subject: Re: [PATCH] configure: Re-disable building cross-gdbserver To: "Maciej W. Rozycki" , Tom Tromey References: <87a75p9mg9.fsf@tromey.com> Cc: "gcc-patches@gcc.gnu.org" , "gdb-patches@sourceware.org" , "binutils@sourceware.org" From: Pedro Alves Message-ID: <23ccb2bf-7e7a-3896-cc87-fd5398a158ca@redhat.com> Date: Wed, 12 Feb 2020 13:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg00450.txt.bz2 Content-length: 4205 On 2/11/20 9:01 PM, Maciej W. Rozycki wrote: > On Tue, 11 Feb 2020, Tom Tromey wrote: > >> Maciej> Correct fallout from commit 919adfe84092 ("Move gdbserver to top level") >> Maciej> and revert to not building `gdbserver' in a cross-configuration, that is >> Maciej> where host != target, matching the documented behaviour. We have no way >> Maciej> to support non-native `gdbserver', and native `gdbserver' is usually of >> Maciej> no use with cross-GDB of the chosen host. >> >> Pedro had a different way to do this, that keeps the decision under >> gdbserver's control: >> >> https://sourceware.org/ml/gdb-patches/2020-02/msg00383.html > > That's actually quite similar to what I considered first, before I > changed my mind. Whatever. Doing it in gdbserver/ has the advantage that it stays under gdbserver's control, so it doesn't need syncing code with the gcc tree. I know of at least one off-tree port that uses gdbserver in a host != target scenario, so I imagine that this condition will evolve over time. Also, this way, changes in this area don't require running autoconf to regenerate configure. I'm not seeing any downside. > > However I would expect `exit' not to be what we want in a sourced script > (I did this differently; see below). Good point, somehow did not think of that. It worked in my patch because we source the script in a sub-shell. But it's clearer/better to not rely on that. > > case "${host}" in > + ${target}) > + gdbserver_host=${host} > + ;; > + *) > + gdbserver_host=NONE > + ;; if/else reads more to-the-point to me, so I tweaked it that way, and merged it in (to binutils-gdb), like below. I'm sorry for not noticing your earlier patch. >From f20e3e823d56e54ffe56792ea6a2fe947c2dec0d Mon Sep 17 00:00:00 2001 From: "Maciej W. Rozycki" Date: Wed, 12 Feb 2020 13:50:30 +0000 Subject: [PATCH] Disable gdbserver on host != target configurations Correct fallout from commit 919adfe84092 ("Move gdbserver to top level") and revert to not building `gdbserver' in a cross-configuration, that is where host != target, matching the documented behaviour. We have no way to support non-native `gdbserver', and native `gdbserver' is usually of no use with cross-GDB of the chosen host. gdbserver/ChangeLog: 2020-02-12 Maciej W. Rozycki Pedro Alves Skip building gdbserver in a cross-configuration. * configure.srv: Set $gdbserver_host depending on whether $target is $host. Use $gdbserver_host instead of $host. --- gdbserver/ChangeLog | 7 +++++++ gdbserver/configure.srv | 11 +++++++++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog index 09707067730..709ef23674c 100644 --- a/gdbserver/ChangeLog +++ b/gdbserver/ChangeLog @@ -1,3 +1,10 @@ +2020-02-12 Maciej W. Rozycki + Pedro Alves + + Skip building gdbserver in a cross-configuration. + * configure.srv: Set $gdbserver_host depending on whether $target + is $host. Use $gdbserver_host instead of $host. + 2020-02-11 Simon Marchi * configure: Re-generate. diff --git a/gdbserver/configure.srv b/gdbserver/configure.srv index 2e83cbdc07f..375ac0aeb2a 100644 --- a/gdbserver/configure.srv +++ b/gdbserver/configure.srv @@ -33,9 +33,16 @@ ipa_ppc_linux_regobj="powerpc-32l-ipa.o powerpc-altivec32l-ipa.o powerpc-vsx32l- # these files over and over again. srv_linux_obj="linux-low.o nat/linux-osdata.o nat/linux-procfs.o nat/linux-ptrace.o nat/linux-waitpid.o nat/linux-personality.o nat/linux-namespaces.o fork-child.o nat/fork-inferior.o" -# Input is taken from the "${host}" variable. +# Input is taken from the "${host}" and "${target}" variables. -case "${host}" in +# GDBserver can only debug native programs. +if test "${target}" = "${host}"; then + gdbserver_host=${host} +else + gdbserver_host= +fi + +case "${gdbserver_host}" in aarch64*-*-linux*) srv_tgtobj="linux-aarch64-low.o" srv_tgtobj="$srv_tgtobj nat/aarch64-linux-hw-point.o" srv_tgtobj="$srv_tgtobj linux-aarch32-low.o" base-commit: 38de8abe21fe17c31888094bd860a84f88cb5749 -- 2.14.5