From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125261 invoked by alias); 5 Jul 2016 17:19:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125246 invoked by uid 89); 5 Jul 2016 17:19:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1488, our, morning, avenue X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 05 Jul 2016 17:19:15 +0000 Received: from EUSAAHC004.ericsson.se (Unknown_Domain [147.117.188.84]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id 72.52.03614.0DBEB775; Tue, 5 Jul 2016 19:18:08 +0200 (CEST) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.86) with Microsoft SMTP Server id 14.3.294.0; Tue, 5 Jul 2016 13:19:12 -0400 Subject: Re: gdbserver/ada testing broken To: Joel Brobecker , Pedro Alves References: <1462538104-19109-1-git-send-email-palves@redhat.com> <1462538104-19109-32-git-send-email-palves@redhat.com> <5772DBCA.4090802@ericsson.com> <813555f3-c917-cd95-6d41-3ec64cad2cf6@redhat.com> <14e113dd-0488-79d0-6cde-82cdb1562793@redhat.com> <20160705163611.GJ3295@adacore.com> CC: From: Simon Marchi Message-ID: <577BEC10.9040605@ericsson.com> Date: Tue, 05 Jul 2016 17:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160705163611.GJ3295@adacore.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-07/txt/msg00077.txt.bz2 On 16-07-05 12:36 PM, Joel Brobecker wrote: >> This is probably because gdb_remote_download only minds "tail" when >> deciding the destination filename: >> >> proc gdb_remote_download {dest fromfile {tofile {}}} { >> # If TOFILE is not given, default to the same filename as FROMFILE. >> if {[string length $tofile] == 0} { >> set tofile [file tail $fromfile] >> } > > Looks like this code is indirectly assuming that the code is in the same > directory as the .exp. That's why it can extract the target directory > via a simple "tail". I tried looking at whether we could make sure > "tofile" was explicitly passed at least for Ada, but it doesn't look > really like an option, as I think this comes from gdb_file_cmd where, > logically, all we care about is which executable to load into GDB. Hi Joel, I posted this patch this morning, I should have CC'ed you: https://sourceware.org/ml/gdb-patches/2016-07/msg00068.html I think it solves it. > I am running out of time to investigate this for now, but to me, > thinking this further, I think the most promising avenue is probably > to look at eliminating the subdirectory, since our testing procedure > now creates one per test already. But I'm not sure how this is going > to affect in-tree testing. I think it will work regardless of in-tree/out-of-tree, since we always use the same layout, under the "outputs" directory. I tested it before sending my patch and it seemed to work fine. Simon