From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id l2CDJp00L2kCYhEAWB0awg (envelope-from ) for ; Tue, 02 Dec 2025 13:49:01 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=labware.com header.i=@labware.com header.a=rsa-sha256 header.s=mimecast20220511 header.b=OvtT4C7Z; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8A9CD1E08D; Tue, 02 Dec 2025 13:49:01 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BC7BE1E08D for ; Tue, 02 Dec 2025 13:48:59 -0500 (EST) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 457384BB58D3 for ; Tue, 2 Dec 2025 18:48:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 457384BB58D3 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=labware.com header.i=@labware.com header.a=rsa-sha256 header.s=mimecast20220511 header.b=OvtT4C7Z Received: from us-smtp-delivery-114.mimecast.com (us-smtp-delivery-114.mimecast.com [170.10.133.114]) by sourceware.org (Postfix) with ESMTP id 91E5A4BB3BD2 for ; Tue, 2 Dec 2025 18:48:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 91E5A4BB3BD2 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=labware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=labware.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 91E5A4BB3BD2 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.114 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764701311; cv=none; b=fQJYrv2v07q4HDqNAbniAQLTev64tkpf0/6Avp09CWh6+pFTsSq9gmGHP27FANFrZ+SI4t2tiE16O7l5RL8Jl10N3XXUpNCo/qtzazuCFm4jFAmBqPR3IbcoU/NZQRmTJWqXAebhAoE6ljcsK/wzJ46qh5CUqEuLs817Sb79lWs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764701311; c=relaxed/simple; bh=byiOQoGOTEPBKOE9rTkGHZj2Mj7o4Eyan8TdTRQEwc8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=UF8dTOAa1QjZTOCHnxvn5lmAQSE11zXiOObEp4MGZGzYczehiBTgNj+Tde9mJeUahnsvppv8Uoz0E8W1UIeLhHZ1As7WGT0lryDP3fzfotSbyH6NTYLllGp+4eiYLvQGoDp2wf0RaitSGImVfCtbYVsAWxvuBOWvXx+m2L/ok6o= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 91E5A4BB3BD2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=labware.com; s=mimecast20220511; t=1764701311; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HQM9mysimg8cgkuFsUMXBXiXaEER8IoO3yY8MGxWJB8=; b=OvtT4C7Z1NlZBYM7521JYryVTjGteu73dK25RxFI2eGWvDWsbOHSY3yTK6qu/Q7Jd8VMuv mqWJg20gknJashM4XGuOX/MSYWNU3fjnknbEYBeFdhR/yXllZWgAuryYKnsgHIWv+Mxclr +XUFdwbQ73Y/eQcGKCKYhVM+gjWXZVw= Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11020101.outbound.protection.outlook.com [52.101.85.101]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-54-5fy7gujAPB-6QcQDy88Epw-1; Tue, 02 Dec 2025 13:48:30 -0500 X-MC-Unique: 5fy7gujAPB-6QcQDy88Epw-1 X-Mimecast-MFC-AGG-ID: 5fy7gujAPB-6QcQDy88Epw_1764701309 Received: from SA1PR17MB5365.namprd17.prod.outlook.com (2603:10b6:806:1d8::11) by MW4PR17MB4467.namprd17.prod.outlook.com (2603:10b6:303:65::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.9; Tue, 2 Dec 2025 18:48:27 +0000 Received: from SA1PR17MB5365.namprd17.prod.outlook.com ([fe80::9a:538a:fa42:730e]) by SA1PR17MB5365.namprd17.prod.outlook.com ([fe80::9a:538a:fa42:730e%3]) with mapi id 15.20.9388.003; Tue, 2 Dec 2025 18:48:26 +0000 From: =?iso-8859-15?Q?Jan_Vran=FD?= To: "tom@tromey.com" CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH v2 13/13] gdb: update message in symbol_file_add_with_addrs after changes in readnow_functions Thread-Topic: [PATCH v2 13/13] gdb: update message in symbol_file_add_with_addrs after changes in readnow_functions Thread-Index: AQHcXXyMIk8DqPM2aEm+hyTMfXjBFbUOp5wQgAAV5YA= Date: Tue, 2 Dec 2025 18:48:26 +0000 Message-ID: <576dde3ff5c99574ff024b6590c255ea356b1a1b.camel@labware.com> References: <20251124195535.2116845-1-jan.vrany@labware.com> <20251124195535.2116845-14-jan.vrany@labware.com> <87ikeo94hb.fsf@tromey.com> In-Reply-To: <87ikeo94hb.fsf@tromey.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR17MB5365:EE_|MW4PR17MB4467:EE_ x-ms-office365-filtering-correlation-id: 2b5b34d7-4e86-4d5e-4b05-08de31d360ff x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|366016|1800799024|38070700021 x-microsoft-antispam-message-info: =?iso-8859-15?Q?wQwQfCArNzqkUY7B0kZ85tWM/ZxHFGVbP8ZNf1Q6LpK9DOWIZ9XbIyLCV?= =?iso-8859-15?Q?x6qkyor2e0IjHreUzzc57fCrk4BkyGzn9adPz0i/aIf9j9fRrIikd1uwA?= =?iso-8859-15?Q?AEYrReVhNpN5tPE4cWuXtqqBGaFr25cOa40mL2EQm2FsnZ5X2rB0sKKVt?= =?iso-8859-15?Q?iPtfJ96W3UtDSpKn5xqDD8TyilHXyD0DevSjXsXO3i2PaV/xVc17iuW6a?= =?iso-8859-15?Q?dO0vRpd5lNn57eDWgcP/MAU4R1i2sE4WThBLdLqdXaGyHDBFwvqHQFIeg?= =?iso-8859-15?Q?8Qyxye2UItoD2YcrttOCo/WHeZCyp6XHBOPYKNuKuhjWui6lfHxg2vDXa?= =?iso-8859-15?Q?E+ocGUZcHhL62ttti9kEXCiIa4Ss4EpB5mwPXWJMMvsPHTFIjQF2/9+qv?= =?iso-8859-15?Q?+WTT9aYJK5xqjZiP9ILQDpa67/3u8APiTtcO6DK5ZdewPyaDbo0Hb6CJF?= =?iso-8859-15?Q?2jP2i/bMd9INOeTSMx3i67XrXktKlpMIObOQAPcG/HC1tFZwsqQqNmWub?= =?iso-8859-15?Q?gruXuYD+LYv6Mjvq3/QpBMta4nMp+UIzqeYHJUNRmKP5oxId9P98PnwKi?= =?iso-8859-15?Q?95JRWHc17nFJHEkOUYFyLHpN6disW6TxWuQTtYx3EaVTOe4mba9iBt4SR?= =?iso-8859-15?Q?78cq+oLhfF8+n8vcjb9C7r+7LIS6/E79keAIKkIIPD8AhF+WO4e4r0u40?= =?iso-8859-15?Q?BAziy17UK6RCajntovxzKKlHAzNoxffeqtPUerxaDz+AGMfox4oLdSMW+?= =?iso-8859-15?Q?0G98JGmu6AQRMllE1Mk5ASwgj3dRepnTU8PqVIxnV81V3pIFM1L+Ikm7a?= =?iso-8859-15?Q?BiAnW+LMELwz+q8vZzIBqEo3JF/+fLFFYvzyAuhi+hR2T/UNZG8O1rhw9?= =?iso-8859-15?Q?aoZU3wg9sQAw811/VTAtTHI1lulr8DHRdJgzknWzrSNvfGqN2uziA1Lub?= =?iso-8859-15?Q?kN19YvtTdsFQ7mhjTrhA9OpcWeCcFOpgIYypoVuTvQnuPW/8mccruNCJF?= =?iso-8859-15?Q?uFP2iNHII9X3d4sXu88GoN6iozeWY/MonZFJP5Jxk1DUFSt+E+EcoKoXZ?= =?iso-8859-15?Q?LAn21Y3sGojBEcrokPlKPxAWe8uc0c5H/cnNHX9ob7rV+ikkgFEWEuvJq?= =?iso-8859-15?Q?uq1+kY2x1im6jdG34o2wMCnZs7keEkygcr050HnSqyPGzWLf0E0K/MNC/?= =?iso-8859-15?Q?jGWmlcDLIUAQ80Fee9WLTCITQdNs1pD6h3YDaKZlKQSRY5wZg+uw42FIc?= =?iso-8859-15?Q?YKS2FetM6Qnxus7znVZiZqXRgbFuAtj93iYBPi2FtRJwek48rw1VBRzqC?= =?iso-8859-15?Q?muATbwPTIfqC4rYVqiU+begvR8hOjtg/jQiGlMKz8957AhCkUglbc5DDr?= =?iso-8859-15?Q?TbD2dGo6aPT1TXqbxwvq7Szv9o3sKvYmfmSfTb81Us/vYQTOg2HZyRJf8?= =?iso-8859-15?Q?hcpK/BqjXG0cJmcu6daiRmUvt4HX88mqrhFtD/UMugo63/46DMH+xBFt9?= =?iso-8859-15?Q?LcL4jFxgHQBdfVXvZXToR0GQuicUCwP/CRT6fn8PcRjs8jZIiDWfbMYDH?= =?iso-8859-15?Q?y6fB5ujb4kioTsXR6UgEgbNeT3iFgbNqNGNNm8Yyq90L0edC7FqxMI?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA1PR17MB5365.namprd17.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700021); DIR:OUT; SFP:1102 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-15?Q?QGbyzglOF9ZMjYt0CX2Omk3Felidoo6+sEJW4MQByaybdsDv96abnNGeq?= =?iso-8859-15?Q?Uuf9Ex1wmtcMehN1qZyVa14L7vbBEpIaVqQ44ah5N6Rf77lanoBLtWPgc?= =?iso-8859-15?Q?O3YrXa+IAeQNLW5Kmq280+k9CHcv/AwiOFKFz+IeBX0Ht9XsSh03d3Qux?= =?iso-8859-15?Q?rfZMSLDP5t2efMJlWOB5g0v7JCbzFDF8dUn9QzJnV/cyiH/wrAPCctD3S?= =?iso-8859-15?Q?y4g85CO0dnxO6oYgWJ4iD29czHAMytq8yZyLW0cj7Z++ZNDRnGWb9EET+?= =?iso-8859-15?Q?p8sn2R8lj1sX9LMqvjiY/qGOzOuGysQsTDmQkd0thCuOw2T65rfiBqDqn?= =?iso-8859-15?Q?NTjifZViG67K/tpNtJHZhjWmq3MPHOPIYDxMq22S/m5fJWkAGq1tFl/YV?= =?iso-8859-15?Q?g3jC8RyaIagz0GVk4eUVDitNGgywLo3N3vripiYOuK5koqxfMjN630D4d?= =?iso-8859-15?Q?fROmoAwxHZ0LxscY835Y06nvk8cSWv6glToYCJ5EQBc/Xo4IEPgiu/1YJ?= =?iso-8859-15?Q?7pP+jaJymOXFXJANw5pLRSAYr8N8vDQB/FzIr65XijLUDt/AoV96ZfmWR?= =?iso-8859-15?Q?XPi5ZnZsfjijREDHYdiQoo/kAMWyMtP/g/E49iWtRfFAl4CmlKyUwXwKY?= =?iso-8859-15?Q?Ff5M9IkswKO9fORZT2eOwv8QtE6MvmzKF3RX8YIR63bO52/a9sYZ3vX5p?= =?iso-8859-15?Q?NsFcdvmRL9Y0n2oYvbdCQ9gmrODW/hcM1V+H1WLTZmgJV2d7zZS22NRWZ?= =?iso-8859-15?Q?zAnT+oMchiUWqQKVsiZLpmwm8Iz0rp+cU7xMHNQWNrMHri0xjIJe6qcvf?= =?iso-8859-15?Q?lsZFXpr3kZ872Lf+098hQh2bAjXM4uRQS9h/9G5G/CvClazlKL2lXZ2mu?= =?iso-8859-15?Q?3P+REPK1RwoovaneBdl4VbaLHGM9LfW1Z+z8yv8Gdn8kHK61pDfKuAAJX?= =?iso-8859-15?Q?ql/BIp70hEjWT+CV3R2FNYDLD4g9Uj5o4koDmoqXT7/XzJsx3iW3FfL/y?= =?iso-8859-15?Q?9RzwxDrFBzKkNDsJGId/PKpFLs7LBbYVKIdxR43Lj1muf8tty1JC0fKkW?= =?iso-8859-15?Q?++02EIkuopVdviT/FwPfAIRL4YQp04TX9Y4+/AHYasXDhSe7Oty6dqoUb?= =?iso-8859-15?Q?hCA72syiuZe964CQTeI+FvH4+vs7bGh0UXVLoc+CEDo5Fcb5NiZ4DcYdM?= =?iso-8859-15?Q?JiMsyczeNbz78+IKaJ/4vRtwWq+BdrUAe3isrf+45meTg8pDOVjtAIobc?= =?iso-8859-15?Q?3+DUHr5AMs6O+K14xlh2nP//3AMrb8oHWzbebo2m7NJabfaYsrR0aaNw0?= =?iso-8859-15?Q?4cpiHHluzFYs7WQd7TZI0znZcSNICN+c6dL+GI8RoFGVN17AQDC0Q8+gi?= =?iso-8859-15?Q?Vs9jZL3GSnOnLXe+gjxyTLVvsxyEcfn6AvftD7tLZ7vo51dXR2D8YIPfl?= =?iso-8859-15?Q?6FDP7Bk/3EkARrB1h2iulkBH0kngF1T3hEZlnNcxCJi1iEnXVo9v3J2yh?= =?iso-8859-15?Q?ZrEPvjrNNwjsKe4E0u+7Ff64BmMSA6QzHjgcpIRK9i1yEDAsLl4TRXu08?= =?iso-8859-15?Q?6gsoG5JF8Rpfz3th3hAOnTh5SDw8jRjn8PD9407Tsr5d8lhb8LYBryheB?= =?iso-8859-15?Q?Zgor/7KC50avZIl4oFbDHq3TGpmxXEQi1szh8rZG2AIiHwJ03K1nDKw8f?= =?iso-8859-15?Q?yDlr?= MIME-Version: 1.0 X-OriginatorOrg: labware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR17MB5365.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b5b34d7-4e86-4d5e-4b05-08de31d360ff X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2025 18:48:26.7929 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b5db0322-1aa0-4c0a-859c-ad0f96966f4c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HvVAzWtJdwfiiF8+1i1hfImsebdk6jFHgwBP/fXtHkD053NB4UcI2IqqN4VGQ8sQZqoUOATkrl80vL86vuAkLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR17MB4467 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: fafWqInebc-kWvmMgfJzZnQLfasf_IVZVlmwp-w-HLU_1764701309 X-Mimecast-Originator: labware.com Content-Language: en-US Content-Type: text/plain; charset=ISO-8859-15 Content-ID: Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Tue, 2025-12-02 at 10:29 -0700, Tom Tromey wrote: > > > > > > "Jan" =3D=3D Jan Vrany writes: >=20 > Jan> When loading a file with -readnow, GDB prints message like: > Jan>=A0=A0=A0=A0 Reading symbols from some_program... > Jan>=A0=A0=A0=A0 Expanding full symbols from some_program... >=20 > Jan> I assume the reason for the second message ("Expanding ...") is to l= et > Jan> the user know what's happening as symbol expansion may take time. >=20 > Yeah. >=20 > I wonder if instead of rewriting expand_all_symtabs in this series, you > could leave most of that patch in place but still have > readnow_functions::expand_all_symtabs actually do the work. Sure.=20 >=20 > Then when/if readnow_functions is moved out of the DWARF reader,=A0 I already have a patch that does this and planed to submit it once this one is in. The reason I stared digging around readnow_function is that search-via-psyms series broke my "Python JIT API" code as well as JIT=A0 reader precisely because they do not install any quick functions. Maybe better way to go about it might be: 1) introduce new quick functions, say "default_symbol_functions" with the code from this (V2) series. 2) then DWARF's readnow_functions may inherit from "default_symbol_functio= ns" and override what's desirable and then JIT reader would just use these new "default_symbol_functions". > the > DWARF reader could subclass it to just add the one new method. >=20 > This way the message would still arrive at the right time, which seems > friendlier to users. >=20 > Jan> This commit therefore checks if there are any unexpanded CUs and if > Jan> so, prints "Expanding full..." message as before. If all CUs are alr= eady > Jan> expanded, say just "Expanded full...". >=20 > Also if there are multiple debug readers for an objfile, we could get > the "wrong" message here through no fault of the reader itself, if that > makes sense. I'm lost. In what situation we'd get "wrong" message? Thanks!=A0 Jan >=20 > Tom