From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic312-26.consmr.mail.ir2.yahoo.com (sonic312-26.consmr.mail.ir2.yahoo.com [77.238.178.97]) by sourceware.org (Postfix) with ESMTPS id DA156385BF92 for ; Wed, 1 Apr 2020 17:37:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DA156385BF92 X-YMail-OSG: FMkErhAVM1mU1UNpx_xGinu5QR9R5aJf9lMWgyk_gU3fVyoJhqK69uG24CoQAxl XJnHHspb3DXOnhW0P7XhGrDXyhh9axphQdOb3onVu2dANUcrHT2h8DYzdeVny4v.2H3gL8A3A_Tv V8jGlEAOZSsMtoAYCTFVkp3u.Hv.5JAIQS3GNXAddH_L3v10PpwUfIOzFa7Db7J5lwBm.09QQ5h. 1Vz_J9tXQKb18sUOSyA651gTDNSuyF6mtGg2MCVzCVmqZRPvLBYp2H_ZKMr44cWPXbhyONkBleMu XXERhwPEE7Ctw8U6okjxD_wV6n331q7MTCyOMO4SI8DRkWlYthA4CxOuC2JyKbpOAUsfLQE5vhyn Pm6Uqcp6kAPurXSUomrkPO9Md3JgJIMgoTYNWSEFzaYgHXturSTlQqMRirSHzorPhiTuUMNf30AC QujPWhhZyZ5fyL1zGEs73ZwvXXxqwHgPTquiiYEN.yxhl4tIexp5hTZeL3t4TvHk6pdEbiobm8tF HRISDb5461SgB1.QyXRsySj2SCY3mtcdbbcrgAV53IfPnncNfRESYxj1lDFLSgDarVAetCT5yMxt YSa6MJvirSqeICAmJsb6o445RdDpVY1BnIPqsAzh_U3wJvVvwqPd30ZnuUx_im5EoQ5CdKhIc06S Pxy2mToFh2UDuX9CHshxGG6pISB1fbKEWVmR3ZwbJCi9am.mqM28OMP_GQ9Oj.vWe2646YSor4qm iX56kTOgi9A_dhh7RCr0TI6G9jyrHhRazkOZt5iuVZb_7V6MxTlI29_P37j_OplVfBUO3pP2DMod puVLwq9ruKAMaeyqpEZATIbdSZxJrSza8t4VbuKxPvPL3DOuCIikFKn5Oiz_xepZmZbQCStilGdo nKgG.oypZA04ndpxk11B3wAcofRW0ht71aLL_HQetFqcehbmWllaezD_LIqfb3zeCyipf.TB6kzO Py.lI4L2CDvDXQGn1VrQ23U43Pc4_BhLOyuO69cSe6ioSS7P_jmtCX.FFltmfG58TX0Fsv5FPADJ 0ArJeH6iuskRxtnG9FX0Cj87K2je.lwqVpDKYIDMWIJcsrfA_qQZNAQ6CxXSY3QAHTZaE99Ixkxz 93DNe6LQN08AERJ8WRHBwWvIP1vVl7i1kEpU2DDSGd39WGGT7Lo_N_tT7SGBuQnkNov04CXuljaD KLAhKE0NMMGqkbEn.SdMSzFIOrlLqrQUsHsrVAsZ13YxdPBABhzKYNCWkYI5gMNjdWBwd0GGralx wykRQayLLDEWjqygTmFI9kJXpHJjBZlqKOUpmP8xxvt4vkFba7NG0ySoFvF8LiUOudwpveHggTag xJpghhdUepQI- Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ir2.yahoo.com with HTTP; Wed, 1 Apr 2020 17:37:58 +0000 Date: Wed, 1 Apr 2020 17:36:30 +0000 (UTC) From: Hannes Domani To: Gdb-patches Message-ID: <576703007.1029840.1585762590985@mail.yahoo.com> In-Reply-To: <537466658.992778.1585761470024@mail.yahoo.com> References: <20200331220655.4436-1-ssbssa.ref@yahoo.de> <20200331220655.4436-1-ssbssa@yahoo.de> <871rp740ys.fsf@tromey.com> <537466658.992778.1585761470024@mail.yahoo.com> Subject: Re: [PATCH v2][PR gdb/24789] Allow pointer arithmetic with integer references MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.15585 YMailNorrin Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0 X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2020 17:38:01 -0000 Am Mittwoch, 1. April 2020, 19:17:58 MESZ hat Hannes Domani via Gdb-patche= s Folgendes geschrieben: > Am Mittwoch, 1. April 2020, 18:36:47 MESZ hat Tom Tromey = Folgendes geschrieben: > > > >>>>> "Hannes" =3D=3D Hannes Domani via Gdb-patches writes: > > > > Hannes> 2020-04-01=C2=A0 Hannes Domani=C2=A0 > > > > Hannes>=C2=A0=C2=A0=C2=A0=C2=A0 PR gdb/24789 > > Hannes>=C2=A0=C2=A0=C2=A0=C2=A0 * eval.c (is_integral_or_integral_refer= ence): New function. > > Hannes>=C2=A0=C2=A0=C2=A0=C2=A0 (evaluate_subexp_standard): Allow integ= er references in > > Hannes>=C2=A0=C2=A0=C2=A0=C2=A0 pointer arithmetic. > > > > Thank you. > > > > Hannes> +/* Return true if type is integral or reference to integral */ > > Hannes> + > > Hannes> +static bool > > Hannes> +is_integral_or_integral_reference (struct type *type) > > Hannes> +{ > > Hannes> +=C2=A0 if (is_integral_type (type)) > > Hannes> +=C2=A0=C2=A0=C2=A0 return true; > > Hannes> + > > Hannes> +=C2=A0 type =3D check_typedef (type); > > Hannes> +=C2=A0 return type !=3D nullptr > > Hannes> +=C2=A0=C2=A0=C2=A0 && TYPE_IS_REFERENCE (type) > > Hannes> +=C2=A0=C2=A0=C2=A0 && is_integral_type (TYPE_TARGET_TYPE (type= )); > > > > This needs parens around the multi-line expression, like: > > > > > >=C2=A0=C2=A0 return (type !=3D nullptr > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 && TYPE_IS_REFERENCE (type) > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 && is_integral_type (TYPE_TARGET_TY= PE (type))); > > > > > > The patch is ok with this tweak. > > Pushed with this change, thanks. That leads me to another question, who/when are PRs closed after pushing? So in this case this one: https://sourceware.org/bugzilla/show_bug.cgi?id=3D24789 And these are 2 other which I think should have been closed some time ago after someone implemented it: https://sourceware.org/bugzilla/show_bug.cgi?id=3D8684 https://sourceware.org/bugzilla/show_bug.cgi?id=3D14529 And these problems can no longer be reproduced since some versions: https://sourceware.org/bugzilla/show_bug.cgi?id=3D17667 https://sourceware.org/bugzilla/show_bug.cgi?id=3D22541 https://sourceware.org/bugzilla/show_bug.cgi?id=3D17521 Hannes