From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87223 invoked by alias); 6 Nov 2019 16:28:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87203 invoked by uid 89); 6 Nov 2019 16:28:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Nov 2019 16:28:48 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id xA6GScRB027242 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 6 Nov 2019 11:28:43 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca xA6GScRB027242 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1573057724; bh=a/BP4/w5ADfwbQFNs3KvgnDwZJimzmH3YFMZXh5T/MQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=TtNIucRVNvizPQPmgLjtIHfsNq99Y+N3qHhxVcndaQZqKX4HQczGLdtCIqjTN4+9D jO3BciAPQsuGPHOXpcS6y/I3jHmM5GtaCYetGd90xRZYfReft6p+4yYabMl/Somd0S Q6D234HTXE8uZOLe5eLF7pqooGguaEbMtOyixsAc= Received: from [172.16.0.155] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 6C8791E10B; Wed, 6 Nov 2019 11:28:38 -0500 (EST) Subject: Re: [review] Add gdb_compile_openmp to lib/gdb.exp To: gnutoolchain-gerrit@osci.io, Kevin Buettner , gdb-patches@sourceware.org Cc: Tom Tromey References: <20191106162415.D0CBD25B28@gnutoolchain-gerrit.osci.io> From: Simon Marchi Message-ID: <575f690e-fbcb-6fd3-e21c-a036989ed460@polymtl.ca> Date: Wed, 06 Nov 2019 16:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191106162415.D0CBD25B28@gnutoolchain-gerrit.osci.io> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2019-11/txt/msg00171.txt.bz2 On 2019-11-06 11:24 a.m., Pedro Alves (Code Review) wrote: > Pedro Alves has posted comments on this change. > > Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/503 > ...................................................................... > > > Patch Set 1: > > (1 comment) > > https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/503/1/gdb/testsuite/lib/gdb.exp > File gdb/testsuite/lib/gdb.exp: > > https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/503/1/gdb/testsuite/lib/gdb.exp@5961 > PS1, Line 5961: > 5887 | proc build_executable_from_specs {testname executable options args} { > | ... > 5956 | lappend objects "${binfile}${i}.o" > 5957 | incr i > 5958 | } > 5959 | set ret [$func $objects "${binfile}" executable $options] > 5960 | } > 5961 > if { $ret != "" } { > 5962 | untested $testname > 5963 | return -1 > 5964 | } > 5965 | > 5966 | return 0 > >>> (I wanted to select all lines from 5930 to 5961 to show the whole context in the email notificatio […] > > Nice, that worked! I think it would be a good idea to mention this in our Gerrit wiki, to invite/remind people do this? Attempt #2: Sure! (This is sent as an email to test replying to comments by email) > -- > Gerrit-Project: binutils-gdb > Gerrit-Branch: master > Gerrit-Change-Id: I94048b8b0940c707ce0529a6bcfa6e4eace49101 > Gerrit-Change-Number: 503 > Gerrit-PatchSet: 1 > Gerrit-Owner: Kevin Buettner > Gerrit-Reviewer: Tom Tromey > Gerrit-CC: Pedro Alves > Gerrit-CC: Simon Marchi > Gerrit-Comment-Date: Wed, 06 Nov 2019 16:24:15 +0000 > Gerrit-HasComments: Yes > Gerrit-Has-Labels: No > Comment-In-Reply-To: Pedro Alves > Comment-In-Reply-To: Simon Marchi > Gerrit-MessageType: comment >