From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127250 invoked by alias); 6 Jun 2016 21:12:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125141 invoked by uid 89); 6 Jun 2016 21:12:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=eyes, Eli X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 06 Jun 2016 21:12:01 +0000 Received: from EUSAAHC002.ericsson.se (Unknown_Domain [147.117.188.78]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id DB.91.03614.6E6E5575; Mon, 6 Jun 2016 23:11:02 +0200 (CEST) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.80) with Microsoft SMTP Server id 14.3.294.0; Mon, 6 Jun 2016 17:11:58 -0400 Subject: Re: [PATCH] Add method/format information to =record-started To: Eli Zaretskii References: <20160603155220.22286-1-simon.marchi@ericsson.com> <57557571.7040200@ericsson.com> <57557D26.2080009@ericsson.com> <57557F4D.8020409@ericsson.com> <83d1nutknu.fsf@gnu.org> CC: , From: Simon Marchi Message-ID: <5755E71E.1090504@ericsson.com> Date: Mon, 06 Jun 2016 21:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <83d1nutknu.fsf@gnu.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00117.txt.bz2 On 16-06-06 11:13 AM, Eli Zaretskii wrote: >> From: Simon Marchi >> Date: Mon, 6 Jun 2016 09:49:01 -0400 >> >> diff --git a/gdb/NEWS b/gdb/NEWS >> index dce79a2..253c8e5 100644 >> --- a/gdb/NEWS >> +++ b/gdb/NEWS >> @@ -67,6 +67,11 @@ maint selftest >> including JIT compiling fast tracepoint's conditional expression >> bytecode into native code. >> >> +* MI async record =record-started now includes the method and format used for >> + recording. For example: >> + >> + =record-started,thread-group="i1",method="btrace",format="bts" >> + >> *** Changes in GDB 7.11 > > This is OK. > >> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo >> index 7e89003..f50582a 100644 >> --- a/gdb/doc/gdb.texinfo >> +++ b/gdb/doc/gdb.texinfo >> @@ -26423,12 +26423,17 @@ breakpoint commands; @xref{GDB/MI Breakpoint Commands}. The >> Note that if a breakpoint is emitted in the result record of a >> command, then it will not also be emitted in an async record. >> >> -@item =record-started,thread-group="@var{id}" >> +@item =record-started,thread-group="@var{id}",method="@var{method}"[,format="@var{format}"] >> @itemx =record-stopped,thread-group="@var{id}" >> Execution log recording was either started or stopped on an >> inferior. The @var{id} is the @value{GDBN} identifier of the thread >> group corresponding to the affected inferior. >> >> +The @var{method} field indicates the method used to record execution. If the >> +method in use supports multiple recording formats, @var{format} will be present >> +and contain the currently used format. See @xref{Process Record and Replay} >> +for existing method and format values. ^^^ > > No need for "See" there, as @xref generates that automatically. Or > use "See @ref". > > OK for the documentation parts, with the above gotcha fixed. Oh it slipped passed my eyes when reading, but you're right. Thanks, this is now pushed.