From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29450 invoked by alias); 12 May 2016 12:42:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29433 invoked by uid 89); 12 May 2016 12:42:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,MIME_BASE64_BLANKS,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1348, H*r:sk:orsmga1, H*r:ip*10.253.24.23, H*RU:HELO X-HELO: mga09.intel.com Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 May 2016 12:41:50 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 12 May 2016 05:41:40 -0700 X-ExtLoop1: 1 Received: from heckel-mobl3.ger.corp.intel.com (HELO [172.28.205.63]) ([172.28.205.63]) by fmsmga001.fm.intel.com with ESMTP; 12 May 2016 05:41:40 -0700 Subject: Re: [PATCH 2/4] Fortran, typeprint: Take level of details into account when printing elements of a structure. To: Yao Qi References: <1462889739-30359-1-git-send-email-bernhard.heckel@intel.com> <1462889739-30359-3-git-send-email-bernhard.heckel@intel.com> <86futncwgb.fsf@gmail.com> Cc: gdb-patches@sourceware.org From: Bernhard Heckel Message-ID: <57347A02.4000802@intel.com> Date: Thu, 12 May 2016 12:42:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <86futncwgb.fsf@gmail.com> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00192.txt.bz2 T24gMTIvMDUvMjAxNiAxNDowNiwgWWFvIFFpIHdyb3RlOgo+IEJlcm5oYXJk IEhlY2tlbCA8YmVybmhhcmQuaGVja2VsQGludGVsLmNvbT4gd3JpdGVzOgo+ Cj4+IC0JICBmX3R5cGVfcHJpbnRfYmFzZSAoVFlQRV9GSUVMRF9UWVBFICh0 eXBlLCBpbmRleCksIHN0cmVhbSwgc2hvdywKPj4gLQkJCSAgICAgbGV2ZWwg KyA0KTsKPj4gLQkgIGZwdXRzX2ZpbHRlcmVkICgiIDo6ICIsIHN0cmVhbSk7 Cj4+IC0JICBmcHV0c19maWx0ZXJlZCAoVFlQRV9GSUVMRF9OQU1FICh0eXBl LCBpbmRleCksIHN0cmVhbSk7Cj4+IC0JICBmX3R5cGVfcHJpbnRfdmFyc3Bl Y19zdWZmaXggKFRZUEVfRklFTERfVFlQRSAodHlwZSwgaW5kZXgpLAo+PiAt CQkJCSAgICAgICBzdHJlYW0sIDAsIDAsIDAsIDApOwo+PiAgIAkgIGZwdXRz X2ZpbHRlcmVkICgiXG4iLCBzdHJlYW0pOwo+PiAtCX0KPj4gLSAgICAgIGZw cmludGZpX2ZpbHRlcmVkIChsZXZlbCwgc3RyZWFtLCAiRW5kIFR5cGUgIik7 Cj4+IC0gICAgICBmcHV0c19maWx0ZXJlZCAoVFlQRV9UQUdfTkFNRSAodHlw ZSksIHN0cmVhbSk7Cj4+ICsJICBmb3IgKGluZGV4ID0gMDsgaW5kZXggPCBU WVBFX05GSUVMRFMgKHR5cGUpOyBpbmRleCsrKQo+PiArCSAgICB7Cj4+ICsJ ICAgICAgZl90eXBlX3ByaW50X2Jhc2UgKFRZUEVfRklFTERfVFlQRSAodHlw ZSwgaW5kZXgpLCBzdHJlYW0sIHNob3cgLSAxLAo+PiArCQkJCSBsZXZlbCAr IDQpOwo+IEkgcmVhZCB0aGlzIHBhdGNoIGFnYWluLCBhbmQgaGFwcGVuIHRv IHNlZSB0aGF0IHdlIHBhc3MgInNob3cgLSAxIiB0bwo+IGZfdHlwZV9wcmlu dF9iYXNlIGluc3RlYWQgb2YgInNob3ciLiAgSSB0aGluayB0aGUgY2hhbmdl IGlzIGNvcnJlY3QsIGJ1dAo+IGl0IHNob3VsZG4ndCBmYWxsIGluIHRoaXMg cGF0Y2gsIHJpZ2h0Pwo+ClllcywgeW91IGFyZSByaWdodC4gU2hvdyAtMSBz aG91bGQgbm90IGdvIGludG8gdGhpcyBwYXRjaC4KVGh4CgoKSW50ZWwgRGV1 dHNjaGxhbmQgR21iSApSZWdpc3RlcmVkIEFkZHJlc3M6IEFtIENhbXBlb24g MTAtMTIsIDg1NTc5IE5ldWJpYmVyZywgR2VybWFueQpUZWw6ICs0OSA4OSA5 OSA4ODUzLTAsIHd3dy5pbnRlbC5kZQpNYW5hZ2luZyBEaXJlY3RvcnM6IENo cmlzdGluIEVpc2Vuc2NobWlkLCBDaHJpc3RpYW4gTGFtcHJlY2h0ZXIKQ2hh aXJwZXJzb24gb2YgdGhlIFN1cGVydmlzb3J5IEJvYXJkOiBOaWNvbGUgTGF1 ClJlZ2lzdGVyZWQgT2ZmaWNlOiBNdW5pY2gKQ29tbWVyY2lhbCBSZWdpc3Rl cjogQW10c2dlcmljaHQgTXVlbmNoZW4gSFJCIDE4NjkyOAo= >From gdb-patches-return-131487-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu May 12 12:45:16 2016 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 48268 invoked by alias); 12 May 2016 12:45:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 47698 invoked by uid 89); 12 May 2016 12:45:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1092 X-HELO: mail-pa0-f65.google.com Received: from mail-pa0-f65.google.com (HELO mail-pa0-f65.google.com) (209.85.220.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 12 May 2016 12:45:05 +0000 Received: by mail-pa0-f65.google.com with SMTP id zy2so7147079pac.2 for ; Thu, 12 May 2016 05:45:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=XfFtjpXjw7YcdFGBWN0iY87dbo4hMbn7Po+nfJdttJI=; b=b+5Ok1raIbSyJgDAbaN2nz8Xrz633HznxjPwEtUb03bIeZKpk6HLDAoosvoBlYF66w 2UizDWspvaGXvC2ioefedkzpkjhDg59JeLtyqNiWh51KyrJmk6xrRA3fH2NQ6nwKsL6z LJXQhfTJNQPtKLWhIGuVUnbf2a5p+UzWjVQshBejYqpD0m4YZmAEanJNzWPihq4aqCLD vIv7IBok4KbO4k/is/24QEbf+Bc6AYfcJBRNF4hyGDdXL2YPsEvpBJJXZxRR8CLxEuFY ZvqJrFYdoPuWh2PbOkyf2UkcKHv2MZiZcZdLuE5lvPk5xj7inyWcWE9yh8XIqsVwDk+q 82bA== X-Gm-Message-State: AOPr4FV0KNfD+260OKgFv5q6wKdk0Ws3xHPe5e3NZa0ykLcG3Dqb2eJMXWh9c/KiRrvCkw== X-Received: by 10.66.76.74 with SMTP id i10mr13629726paw.31.1463057103130; Thu, 12 May 2016 05:45:03 -0700 (PDT) Received: from E107787-LIN (gcc113.osuosl.org. [140.211.9.71]) by smtp.gmail.com with ESMTPSA id d184sm19760003pfc.27.2016.05.12.05.45.00 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 12 May 2016 05:45:01 -0700 (PDT) From: Yao Qi To: Bernhard Heckel Cc: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 3/4] Fortran, typeprint: Decrease level of details when printing elements of a structure. References: <1462889739-30359-1-git-send-email-bernhard.heckel@intel.com> <1462889739-30359-4-git-send-email-bernhard.heckel@intel.com> <86oa8cd870.fsf@gmail.com> <57343808.40807@intel.com> Date: Thu, 12 May 2016 12:45:00 -0000 In-Reply-To: <57343808.40807@intel.com> (Bernhard Heckel's message of "Thu, 12 May 2016 10:00:08 +0200") Message-ID: <86bn4bcunq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00193.txt.bz2 Content-length: 1091 Bernhard Heckel writes: > This is what the comment says: > SHOW nonzero means don't print this type as just its name; > show its real definition even if it has a name. > SHOW zero means print just typename or struct tag if there is one > SHOW negative means abbreviate structure elements. > SHOW is decremented for printing of structure elements. > > From that, I understood that I have to print the elements when show is >= =3D0. My understanding to the comments above is that we should print elements when show is > 0. When show is zero, "print just typename or struct tag", which means when we print t3v, (gdb) ptype t3v type =3D Type t3 <--- show is 1 integer(kind=3D4) :: t3_i <--- show is 0 Type t2 t2_n <--- show is 0 End Type t3 we should only print type name of t2, rather than its elements, right? > Am I wrong? If so, I have to change Patch2. I'd like to leave it to you or someone else who is familiar with the type print or fortran. --=20 Yao (=E9=BD=90=E5=B0=A7)