From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128798 invoked by alias); 28 Apr 2016 18:06:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128782 invoked by uid 89); 28 Apr 2016 18:06:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Toshihito, toshihito X-HELO: nm13.bullet.mail.ne1.yahoo.com Received: from nm13.bullet.mail.ne1.yahoo.com (HELO nm13.bullet.mail.ne1.yahoo.com) (98.138.90.76) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 28 Apr 2016 18:05:51 +0000 Received: from [98.138.100.113] by nm13.bullet.mail.ne1.yahoo.com with NNFMP; 28 Apr 2016 18:05:49 -0000 Received: from [98.138.104.112] by tm104.bullet.mail.ne1.yahoo.com with NNFMP; 28 Apr 2016 18:05:49 -0000 Received: from [127.0.0.1] by smtp221.mail.ne1.yahoo.com with NNFMP; 28 Apr 2016 18:05:49 -0000 X-Yahoo-SMTP: uLlXihWswBAw_asaF5e6lP5gQBt5Jmin From: Toshihito Kikuchi Subject: Re: [PATCH] Negative repeat count for 'x' command To: Pedro Alves , gdb-patches@sourceware.org References: <1095889805.138513.1453786618993.JavaMail.yahoo@mail.yahoo.com> <20160127160420.GM3338@embecosm.com> <56AA013F.8010601@redhat.com> <56B7D0E3.8020402@yahoo.de> <570B95AE.80406@redhat.com> <571035CC.7060802@yahoo.de> <5714DE73.5010104@redhat.com> Cc: Paul_Koning@Dell.com, andrew.burgess@embecosm.com, jhb@freebsd.org Message-ID: <572250E8.90207@yahoo.de> Date: Thu, 28 Apr 2016 18:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <5714DE73.5010104@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00645.txt.bz2 Hi Pedro, I've sent V3 patch today. > BTW, aren't these tests dependent on the host's charset? (show host-charset) Thank you for pointing this out. Yes, then I added 'set host-charset ASCII' before running string testcases. > An idea to generalize the x/i tests to all archs would be to > let go of the asm, and instead write the test function in C. Then > you'd first use forward x/i to store a few line's instructions in > a list/array, and afterwards you'd disassemble backwards, comparing > with the expected instructions stored in the stored list/array. > I wonder whether that'd work. This was great suggestion. I realized .exp test scripts can support complex logics more than expected. I added a new section 'backward disassemble general' to do that. A new section "address zero boundary" is also added to test around address zero. Since I don't have non-MMU machines, I verified it using by setting /proc/sys/vm/mmap_min_addr to 0. Thanks, Toshihito