RE: [PATCH 1/2] Fix write endianness/size problem for fast tracepoint enabled flag

Simon Marchi
2016-05-05T13:50:38Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="us-ascii", Size: 7786 bytes --]

>> gdb/gdbserver/ChangeLog:
>>
>> YYYY-MM-DD Par Olsson <par.olsson@windriver.com>
>>
>> * tracepoint.c (write_inferior_int8): New function.
>> (cmd_qtenable_disable): Write enable flag using
>> write_inferior_int8.
>
> The format of committed changelog entry looks odd to me,

Fixed, thanks.
From gdb-patches-return-131369-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu May 05 18:19:21 2016
Return-Path: <gdb-patches-return-131369-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Delivered-To: listarch-gdb-patches@sources.redhat.com
Received: (qmail 56286 invoked by alias); 5 May 2016 18:19:21 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Delivered-To: mailing list gdb-patches@sourceware.org
Received: (qmail 55548 invoked by uid 89); 5 May 2016 18:19:20 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 testsºYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*r:8.14.3, states, sleep
X-HELO: smtp.polymtl.ca
Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 05 May 2016 18:19:09 +0000
Received: from elxcz23q12-y4.polymtl.ca (Sansfil-Public-Lassonde-201-57.polymtl.ca [132.207.201.57]) by smtp.polymtl.ca (8.14.3/8.14.3) with ESMTP id u45IJ4ac032566; Thu, 5 May 2016 14:19:05 -0400
From: Simon Marchi <simon.marchi@ericsson.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@ericsson.com>
Subject: [PATCH v2] Add mi-threads-interrupt.exp test (PR 20039)
Date: Thu, 05 May 2016 18:19:00 -0000
Message-Id: <1462472343-17772-1-git-send-email-simon.marchi@ericsson.com>
X-Poly-FromMTA: (Sansfil-Public-Lassonde-201-57.polymtl.ca [132.207.201.57]) at Thu, 5 May 2016 18:19:04 +0000
X-IsSubscribed: yes
X-SW-Source: 2016-05/txt/msg00075.txt.bz2
Content-length: 5280

Add a new test for PR 20039. The test spawns new threads, then tries to
interrupt, continue, and interrupt again. This use case was fixed by
commit 5fe966540d6b748f825774868463003700f0c878 in master, but gdb 7.11
is affected (so if you try it on the gdb-7.11-branch right now, the test
will fail).

New in v2, the test now handles mi-async on mode properly. The failure
was specific to mi-async off, but I don't think it's bad to test the
same thing under async on mode. I added a little hack when running in
async mode to work around bug 20045.

I also removed one continue/interrupt pair, as a single one was enough to
trigger the problem.

gdb/testsuite/ChangeLog:

* gdb.mi/mi-threads-interrupt.c: New file.
* gdb.mi/mi-threads-interrupt.exp: New file.
---
gdb/testsuite/gdb.mi/mi-threads-interrupt.c | 61 ++++++++++++++++++++++
gdb/testsuite/gdb.mi/mi-threads-interrupt.exp | 75 +++++++++++++++++++++++++++
2 files changed, 136 insertions(+)
create mode 100644 gdb/testsuite/gdb.mi/mi-threads-interrupt.c
create mode 100644 gdb/testsuite/gdb.mi/mi-threads-interrupt.exp

diff --git a/gdb/testsuite/gdb.mi/mi-threads-interrupt.c b/gdb/testsuite/gdb.mi/mi-threads-interrupt.c
new file mode 100644
index 0000000..8747806
--- /dev/null
+++ b/gdb/testsuite/gdb.mi/mi-threads-interrupt.c
@@ -0,0 +1,61 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+ Copyright 2016 Free Software Foundation, Inc.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>. */
+
+#include <pthread.h>
+#include <unistd.h>
+
+#define NUM_THREADS 2
+
+static pthread_barrier_t barrier;
+
+static void *
+thread_func (void *v)
+{
+ int i;
+
+ pthread_barrier_wait (&barrier);
+
+ for (i = 0; i < 100; i++)
+ sleep (1);
+}
+
+static void
+all_threads_created (void)
+{
+}
+
+int
+main(void)
+{
+ int i;
+ pthread_t threads[NUM_THREADS];
+
+ /* +1 to account for the main thread */
+ pthread_barrier_init (&barrier, NULL, NUM_THREADS + 1);
+
+ for (i = 0; i < NUM_THREADS; i++)
+ pthread_create (&threads[i], NULL, thread_func, NULL);
+
+ pthread_barrier_wait (&barrier);
+
+ all_threads_created ();
+
+ for (i = 0; i < 100; i++)
+ sleep (1);
+
+ return 0;
+}
diff --git a/gdb/testsuite/gdb.mi/mi-threads-interrupt.exp b/gdb/testsuite/gdb.mi/mi-threads-interrupt.exp
new file mode 100644
index 0000000..af5d99b
--- /dev/null
+++ b/gdb/testsuite/gdb.mi/mi-threads-interrupt.exp
@@ -0,0 +1,75 @@
+# Copyright 2016 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+load_lib mi-support.exp
+set MIFLAGS "-i=mi"
+
+standard_testfile
+
+if {[gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable {debug}] != "" } {
+ return -1
+}
+
+# This tests the resolution of PR 20039.
+#
+# With a multi-threaded inferior and with MI/all-stop, it was not possible
+# to interrupt it with ctrl-C after a continue.
+
+proc test_continue_interrupt { } {
+ global binfile
+ global async
+
+ gdb_exit
+ if {[mi_gdb_start]} {
+ continue
+ }
+
+ # Load the binary in gdb...
+ mi_gdb_load $binfile
+
+ # ... and run it.
+ #
+ # Note this test relies on mi_runto deleting the breakpoint.
+ # A step-over here would mask the bug.
+ mi_runto "all_threads_created"
+
+ # Consistency check.
+ mi_check_thread_states {"stopped" "stopped" "stopped"} "check thread states"
+
+ # Continue.
+ mi_gdb_test "565-exec-continue" "565\\^running\r\n\\*running,thread-id=\"all\"" "continue"
+ if { $async } {
+ # Workaround for PR 20045, where -exec-continue will output two (gdb) prompts
+ # when in "mi-async on" mode. This mi_gdb_test will consume the extra (gdb).
+ # Once that bug is fixed, this can be removed.
+ mi_gdb_test
+ }
+
+ # Wait a bit to make sure all MI events are sent, before sending the
+ # interruption request.
+ sleep 1
+
+ # Send the interrupt request.
+ if { $async } {
+ mi_gdb_test "888-exec-interrupt" "888\\^done" "interrupt"
+ } else {
+ send_gdb "\003"
+ }
+
+ # Wait for the *stopped.
+ mi_expect_interrupt "interrupt reported"
+}
+
+test_continue_interrupt
--
2.8.2