Re: [PATCH 1/2] Fix write endianness/size problem for fast tracepoint enabled flag

Yao Qi
2016-03-31T10:51:55Z

Simon Marchi <simon.marchi@ericsson.com> writes:

> I am sending this fix on behalf of Par Olsson, as a follow-up of this
> one:
>
> https://www.sourceware.org/ml/gdb-patches/2015-10/msg00196.html

Hi Simon,
The patch in the url above is to change 'enabled' field to uint32_t, so
I guess you got the patch below from Par Olsson off list?

The reason I ask this is that I find the author doesn't have the copyright
assignment. We can take it as a tiny patch, if no one has objections.

>
> static int
> +write_inferior_int8 (CORE_ADDR symaddr, int8_t val)
> +{
> + return write_inferior_memory (symaddr, (unsigned char *) &val, sizeof (val));

This line is too long.

> +}

The patch itself is good to me.

--
Yao (齐尧)