From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68757 invoked by alias); 27 Apr 2016 13:39:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68739 invoked by uid 89); 27 Apr 2016 13:39:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 27 Apr 2016 13:39:05 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7D88CC062CE7; Wed, 27 Apr 2016 13:39:04 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3RDd2ct022175; Wed, 27 Apr 2016 09:39:03 -0400 Subject: Re: [PATCH] c_value_print: Revert 'val' to a reference for TYPE_CODE_STRUCT To: Martin Galvan References: <1461707298-26514-1-git-send-email-martin.galvan@tallertechnologies.com> <57208DFF.3020801@redhat.com> Cc: gdb-patches , Tom Tromey , Daniel Gutson From: Pedro Alves Message-ID: <5720C0F6.9060806@redhat.com> Date: Wed, 27 Apr 2016 13:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00591.txt.bz2 On 04/27/2016 02:21 PM, Martin Galvan wrote: > On Wed, Apr 27, 2016 at 7:01 AM, Pedro Alves wrote: >> What's the motivation behind this? Does it change anything user visible? > > AFAIK not directly, but I'm going to need it for the synthetic reference bug > fix. I see. > Since this is an isolated change I thought I could send it for > review now. Since you didn't mention whether the change had any user-visible impact, I was left wondering if we could add a testcase to the testsuite that exposes the need for the change. From the original log it kind of sounded like it would be possible. It's better to be explicit in such cases, and say something like, "this has no effect currently, so can be seen as a small code cleanup, but once we do X, we'll print the wrong thing", or some such, and mention that this causes no testsuite regressions, in the email/commit log. The code change is OK. Thanks, Pedro Alves