From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108649 invoked by alias); 27 Apr 2016 11:47:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108553 invoked by uid 89); 27 Apr 2016 11:47:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1459, impressive, Great, our X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 27 Apr 2016 11:47:05 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 74530C049D52; Wed, 27 Apr 2016 11:47:03 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3RBl2J0014426; Wed, 27 Apr 2016 07:47:02 -0400 Subject: Re: [PATCH 0/8] Add Rust language support To: Tom Tromey , gdb-patches@sourceware.org References: <1461725371-17620-1-git-send-email-tom@tromey.com> From: Pedro Alves Message-ID: <5720A6B6.8010505@redhat.com> Date: Wed, 27 Apr 2016 11:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1461725371-17620-1-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00586.txt.bz2 On 04/27/2016 03:49 AM, Tom Tromey wrote: > Hi. It's been a while. Hi. Great to see you around. > This patch series adds support for the Rust programming languages to > gdb. See https://www.rust-lang.org/ for more information on Rust > itself. > > This is a reasonably full-featured port. It has a few known bugs and > holes, but nothing very serious. This is awesome! I've read the series and it looks mostly OK to me. Just a few minor nits here and there. > I've tested it using Rust 1.8, as available in the Fedora COPR. It's > known not to work with Rust nightly, due to some debuginfo regressions > there. > > I ran the new tests with gcov. The test cases cover 98% of > rust-exp.y, and 82% of rust-lang.c -- mostly missing things like > rust_print_subexp; I intentionally didn't write tests for the > expression-dumping debug functions. Impressive. > > I wrote most of the code, but Manish Goregaokar did some as well -- > more than enough to require an assignment. Both of our copyright > assignments are in process. > > I've built the series both with gcc and with g++. > Thank you. > I'd like to make a new rust component in bugzilla once this is > approved. I think I can make this for you, if you need it. > If anybody cares, I have a list of the ugly bits in gdb I encountered > while writing this series. I think it's all generally well known > though. I'd be curious. Thanks, Pedro Alves