From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50002 invoked by alias); 27 Apr 2016 11:40:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 49992 invoked by uid 89); 27 Apr 2016 11:40:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 27 Apr 2016 11:40:42 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4EC7EC05E174; Wed, 27 Apr 2016 11:40:41 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3RBea8a015662; Wed, 27 Apr 2016 07:40:37 -0400 Subject: Re: [PATCH 5/8] Add array start and end strings to generic_val_print_decorations To: Tom Tromey , gdb-patches@sourceware.org References: <1461725371-17620-1-git-send-email-tom@tromey.com> <1461725371-17620-6-git-send-email-tom@tromey.com> From: Pedro Alves Message-ID: <5720A534.6020206@redhat.com> Date: Wed, 27 Apr 2016 11:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1461725371-17620-6-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00582.txt.bz2 On 04/27/2016 03:49 AM, Tom Tromey wrote: > For Rust value-printing, I wanted to use generic_val_print_array, but > I also wanted to control the starting and ending strings. > > This patch adds new strings to generic_val_print_decorations, updates > generic_val_print_array to use them, and updates all the existing > instances of generic_val_print_decorations. LGTM. Thanks, Pedro Alves