From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47929 invoked by alias); 27 Apr 2016 11:40:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47896 invoked by uid 89); 27 Apr 2016 11:40:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=news X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 27 Apr 2016 11:40:26 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F0B3847F; Wed, 27 Apr 2016 11:40:24 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3RBeNlT010495; Wed, 27 Apr 2016 07:40:24 -0400 Subject: Re: [PATCH 4/8] Add self-test framework to gdb To: Tom Tromey , gdb-patches@sourceware.org References: <1461725371-17620-1-git-send-email-tom@tromey.com> <1461725371-17620-5-git-send-email-tom@tromey.com> From: Pedro Alves Message-ID: <5720A527.2010609@redhat.com> Date: Wed, 27 Apr 2016 11:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1461725371-17620-5-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00581.txt.bz2 On 04/27/2016 03:49 AM, Tom Tromey wrote: > I wanted to unit test the Rust lexer, so I added a simple unit testing > command to gdb. > > The intent is that self tests will only be compiled into gdb in > development mode. In release mode they simply won't exist. So, this > exposes $development to C code as GDB_SELF_TEST. > > In development mode, test functions are registered with the self test > module. A test function is just a function that does some checks, and > aborts on failure. I chose this rather than something fancier because > I think any such failure will require debugging anyhow. IIUC, it'll internal error, not abort/crash directly, right? > Then this adds a new "maint selftest" command which invokes the test > functions, and a new dejagnu test case that invokes it. Looks good to me. Could you include a NEWS change for "maintenance selftest" ? Thanks, Pedro Alves