From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17786 invoked by alias); 26 Apr 2016 12:57:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17729 invoked by uid 89); 26 Apr 2016 12:57:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=snapshot, Hx-languages-length:935, extensively X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 26 Apr 2016 12:57:35 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 103F9C05E170; Tue, 26 Apr 2016 12:57:34 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3QCvWtV023282; Tue, 26 Apr 2016 08:57:33 -0400 Subject: Re: [PATCH 1/7] New test case gdb.trace/signal.exp To: Yao Qi References: <1458749384-19793-1-git-send-email-yao.qi@linaro.org> <1458749384-19793-2-git-send-email-yao.qi@linaro.org> <5707E1CC.2010609@redhat.com> <86a8l0leqy.fsf@gmail.com> <570BAECD.30508@redhat.com> <86inz9j4oo.fsf@gmail.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <571F65BC.4030500@redhat.com> Date: Tue, 26 Apr 2016 12:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <86inz9j4oo.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00551.txt.bz2 On 04/22/2016 11:52 AM, Yao Qi wrote: > Pedro Alves writes: > >>> +# Record the hit times of each tracepoint in this array. >>> +array set tracepoint_hits { } >>> + >>> +set test "tfind 0" >>> +gdb_test_multiple $test $test { >> >> Why do we need this separate "tfind 0" step? I'd think the >> "tfind" loop below would be sufficient? > > I don't know the first "tfind" can find the first snapshot , and I think > "tfind 0" should be the first one in all other "tfind X" commands. > > The usage like this is not documented. I didn't know it wasn't documented. I think the testsuite uses it extensively. > In current doc: > > tfind > > No argument means find the next trace snapshot. > > We probably need to change the doc to > > No argument means find the next trace snapshot or find the first > one if no trace snapshot is selected. Yeah. Thanks, Pedro Alves