From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-131162-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 36332 invoked by alias); 22 Apr 2016 15:54:33 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 36316 invoked by uid 89); 22 Apr 2016 15:54:32 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=vtt, VTT, Hx-languages-length:1216, 47
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 22 Apr 2016 15:54:22 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 8E7B9201EA;	Fri, 22 Apr 2016 15:54:20 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3MFsJ11003990;	Fri, 22 Apr 2016 11:54:19 -0400
Subject: Re: [PATCH] Fix fails in gdb.trace/unavailable.exp
To: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
References: <1461065672-16391-1-git-send-email-yao.qi@linaro.org>
From: Pedro Alves <palves@redhat.com>
Message-ID: <571A492B.1050704@redhat.com>
Date: Fri, 22 Apr 2016 15:54:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1
MIME-Version: 1.0
In-Reply-To: <1461065672-16391-1-git-send-email-yao.qi@linaro.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-04/txt/msg00534.txt.bz2

On 04/19/2016 12:34 PM, Yao Qi wrote:
> I am seeing some test fails in gdb.trace/unavailable.exp on aarch64-linux,
> like this,
> 
> print derived_whole^M
> $43 = (Derived) {<Middle> = {<Base> = {x = 2}, _vptr.Middle = 0x401860 <VTT for Derived>, y = 3}, _vptr.Derived = 0x401848 <vtable for Derived+32>, z = 4}^M
> (gdb) FAIL: gdb.trace/unavailable.exp: collect globals: print object on: print derived_whole
> 
> print derived_whole^M
> $47 = {<Middle> = {<Base> = {x = 2}, _vptr.Middle = 0x401860 <VTT for Derived>, y = 3}, _vptr.Derived = 0x401848 <vtable for Derived+32>, z = 4}^M
> (gdb) FAIL: gdb.trace/unavailable.exp: collect globals: print object off: print derived_whole
> 
> these fails are also found by recent x86_64-linux buildbot,
> https://sourceware.org/ml/gdb-testers/2016-q2/msg00622.html
> 
> The fix is exactly the same as this one
> http://www.sourceware.org/ml/gdb-patches/2015-10/msg00252.html (the
> extra "VTT" after hex), in which we match extra things after $hex.
> 
> gdb/testsuite:
> 
> 2016-04-19  Yao Qi  <yao.qi@linaro.org>
> 
> 	* gdb.trace/unavailable.exp (gdb_collect_globals_test_1): Match
> 	more after $hex.

LGTM.

Thanks,
Pedro Alves