From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-131150-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 106077 invoked by alias); 22 Apr 2016 13:31:53 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 106068 invoked by uid 89); 22 Apr 2016 13:31:52 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=marks, Hx-languages-length:1406, wanting, spring
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 22 Apr 2016 13:31:47 +0000
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id E5B6E85543;	Fri, 22 Apr 2016 13:31:45 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3MDVih0007157;	Fri, 22 Apr 2016 09:31:45 -0400
Subject: Re: [PATCH] Improve maint print symbols,psymbols,msymbols
To: Doug Evans <xdje42@gmail.com>, gdb-patches@sourceware.org, eliz@gnu.org
References: <m3d1pkrxwa.fsf@sspiff.org>
From: Pedro Alves <palves@redhat.com>
Message-ID: <571A27C0.1070507@redhat.com>
Date: Fri, 22 Apr 2016 13:31:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1
MIME-Version: 1.0
In-Reply-To: <m3d1pkrxwa.fsf@sspiff.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-04/txt/msg00522.txt.bz2

On 04/20/2016 06:30 PM, Doug Evans wrote:
> Hi.
> 
> More old sandbox spring cleaning.
> 
> At the time I needed this, I used it a lot.

Thanks, I think this is quite useful and helpful.

> I've since also added msymbol improvements if only for consistency sake.
> It's helpful to have more control over what to print,
> and to have the output appear on the screen
> without having to go looking for it. Bleah.

Yeah...

No real comments on the patch itself.  Only a small
passer-by comment below.

> +      else if (strcmp (argv[i], "-source") == 0)
> +	{
> +	  if (argv[i + 1] == NULL)
> +	    error (_("Missing source file"));
> +	  source_arg = argv[++i];
> +	}
> +      else if (strcmp (argv[i], "-objfile") == 0)
> +	{
> +	  if (argv[i + 1] == NULL)
> +	    error (_("Missing objfile name"));
> +	  objfile_arg = argv[++i];
> +	}
> +      else if (argv[i][0] == '-')
> +	{
> +	  /* Future proofing: Don't allow OUTFILE to begin with "-".  */
> +	  error (_("Unknown option: %s"), argv[i]);
> +	}

We don't do this often, but it's usual for tools to
understand "--" as meaning end of "-" options.  I'd
instead do:

      else if (strcmp (argv[i], "--") == 0)
        {
          /* Explicit "--" marks end of options. */
          break;
        }
      else if (argv[i][0] == '-')
        error (_("Unknown option: %s"), argv[i]);
      else
        break;

So anyone wanting a filename that begins with "-" could still have it.

Thanks,
Pedro Alves