From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32474 invoked by alias); 14 Apr 2016 15:27:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32457 invoked by uid 89); 14 Apr 2016 15:27:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 14 Apr 2016 15:27:18 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 37DFFC084AE3; Thu, 14 Apr 2016 15:27:17 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3EFRFVL022042; Thu, 14 Apr 2016 11:27:16 -0400 Subject: Re: [PATCH 1/2] Change gdb_load_shlibs to gdb_load_shlib To: Simon Marchi , Yao Qi References: <1460502865-10999-1-git-send-email-simon.marchi@ericsson.com> <864mb4o7qq.fsf@gmail.com> <570FB48A.8000201@ericsson.com> Cc: gdb-patches@sourceware.org, antoine.tremblay@ericsson.com From: Pedro Alves Message-ID: <570FB6D3.1010707@redhat.com> Date: Thu, 14 Apr 2016 15:27:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <570FB48A.8000201@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00333.txt.bz2 On 04/14/2016 04:17 PM, Simon Marchi wrote: > On 16-04-14 05:33 AM, Yao Qi wrote: >> Simon Marchi writes: >> >>> -proc gdb_load_shlibs { args } { >>> - foreach file $args { >>> - gdb_remote_download target [shlib_target_file $file] >>> - } >>> +proc gdb_load_shlib { file } { >>> + set dest [gdb_remote_download target [shlib_target_file $file]] >> >> Why don't define a new proc gdb_load_shlib but leave gdb_load_shlibs >> there? gdb_load_shlibs can invoke gdb_load_shlib in a loop, and callers >> of gdb_load_shlibs are not changed. > > It would have been the lazy but clever way to do it, for sure. I hadn't > thought of that. > > I am not sure I like it though, because it makes multiple procs that do kind > of the same thing, but with subtle differences. That's what causes confusion > later. It's the same feeling I had about gdb_download and gdb_remote_download... > > Pedro (and others), what do you think? I agree that that may end up causing confusion. Thanks, Pedro Alves