From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-130960-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 111525 invoked by alias); 14 Apr 2016 15:17:45 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 111510 invoked by uid 89); 14 Apr 2016 15:17:44 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=Hx-languages-length:929
X-HELO: usplmg20.ericsson.net
Received: from usplmg20.ericsson.net (HELO usplmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 14 Apr 2016 15:17:34 +0000
Received: from EUSAAHC001.ericsson.se (Unknown_Domain [147.117.188.75])	by usplmg20.ericsson.net (Symantec Mail Security) with SMTP id F9.E5.09012.3FDAF075; Thu, 14 Apr 2016 16:49:24 +0200 (CEST)
Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.77) with Microsoft SMTP Server id 14.3.248.2; Thu, 14 Apr 2016 11:17:31 -0400
Subject: Re: [PATCH 1/2] Change gdb_load_shlibs to gdb_load_shlib
To: Yao Qi <qiyaoltc@gmail.com>
References: <1460502865-10999-1-git-send-email-simon.marchi@ericsson.com> <864mb4o7qq.fsf@gmail.com>
CC: <gdb-patches@sourceware.org>, <palves@redhat.com>,	<antoine.tremblay@ericsson.com>
From: Simon Marchi <simon.marchi@ericsson.com>
Message-ID: <570FB48A.8000201@ericsson.com>
Date: Thu, 14 Apr 2016 15:17:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <864mb4o7qq.fsf@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2016-04/txt/msg00332.txt.bz2

On 16-04-14 05:33 AM, Yao Qi wrote:
> Simon Marchi <simon.marchi@ericsson.com> writes:
> 
>> -proc gdb_load_shlibs { args } {
>> -    foreach file $args {
>> -	gdb_remote_download target [shlib_target_file $file]
>> -    }
>> +proc gdb_load_shlib { file } {
>> +    set dest [gdb_remote_download target [shlib_target_file $file]]
> 
> Why don't define a new proc gdb_load_shlib but leave gdb_load_shlibs
> there?  gdb_load_shlibs can invoke gdb_load_shlib in a loop, and callers
> of gdb_load_shlibs are not changed.

It would have been the lazy but clever way to do it, for sure.  I hadn't
thought of that.

I am not sure I like it though, because it makes multiple procs that do kind
of the same thing, but with subtle differences.  That's what causes confusion
later.  It's the same feeling I had about gdb_download and gdb_remote_download...

Pedro (and others), what do you think?