From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93429 invoked by alias); 13 Apr 2016 18:18:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92652 invoked by uid 89); 13 Apr 2016 18:18:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=remotely, mass X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 13 Apr 2016 18:18:12 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 33C12C04B311; Wed, 13 Apr 2016 18:18:11 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3DII9mW022753; Wed, 13 Apr 2016 14:18:10 -0400 Subject: Re: [PATCH 1/2] Change gdb_load_shlibs to gdb_load_shlib To: Simon Marchi , gdb-patches@sourceware.org References: <1460502865-10999-1-git-send-email-simon.marchi@ericsson.com> Cc: qiyaoltc@gmail.com, antoine.tremblay@ericsson.com From: Pedro Alves Message-ID: <570E8D61.3010100@redhat.com> Date: Wed, 13 Apr 2016 18:18:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1460502865-10999-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00297.txt.bz2 On 04/13/2016 12:14 AM, Simon Marchi wrote: > Note: this series should be applied on top of > https://sourceware.org/ml/gdb-patches/2016-04/msg00252.html > > ------- > > This patch renames gdb_load_shlibs to gdb_load_shlib, and changes its > arguments so that it can only take a single library at the time. > > The following patch requires to be able to get the destination path of a > loaded shared library, so it's more straightforward if the procedure can > only accept one argument. > > On top of the mass renaming, there are a handful of locations where I > had to split up a gdb_load_shlibs in two gdb_load_shlib. > I'd have been nicer and more focused if you split this in two: #1 - make gdb_load_shlibs accept only one shlib. #2 - do the trivial mass rename. > -proc gdb_load_shlibs { args } { > - foreach file $args { > - gdb_remote_download target [shlib_target_file $file] > - } > +proc gdb_load_shlib { file } { > + set dest [gdb_remote_download target [shlib_target_file $file]] > > if {[is_remote target]} { > # If the target is remote, we need to tell gdb where to find the > @@ -4237,8 +4235,10 @@ proc gdb_load_shlibs { args } { > # We could set this even when not testing remotely, but a user > # generally won't set it unless necessary. In order to make the tests > # more like the real-life scenarios, we don't set it for local testing. > - gdb_test "set solib-search-path [file dirname [lindex $args 0]]" "" "" > + gdb_test "set solib-search-path [file dirname [lindex $file 0]]" "" "" $file is no longer a list, so [lindex $file 0] can just be $file. With: gdb_load_shlib $libobj1 gdb_load_shlib $libobj2 We'll now only end up with $libobj2's dirname in the solib-search-path. This usually won't be a problem since the dirnames will be the same, though I guess some test might be doing something with subdirs. Grepping a bit I found solib-search.exp, though it's currently disabled on remote testing. Do we need to maintain a list of dirnames, and clear it somewhere? Thanks, Pedro Alves